[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1675 not sure why only one profile keeps failing with all rest api tests, and profile itself have `-DskipTests` flag --- If your project is set up for it, you can reply to this email and have y

[GitHub] zeppelin pull request #1720: Fix case where user use zeppelin in normal mode...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1720: Fix case where user use zeppelin in normal mode with t...

Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1720 @minahlee @khalidhuseynov thanks you for review, fixed the test and hopefully merging it as a hotfix soon --- If your project is set up for it, you can reply to this email and have your r

[GitHub] zeppelin issue #1720: Fix case where user use zeppelin in normal mode with t...

Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1720 I see two tests failing `testGetAllNotes`, `testGetNote` under the corresponding class test. Other than that looks good. --- If your project is set up for it, you can reply to this email a

[GitHub] zeppelin issue #1711: [ZEPPELIN-1721] Let each visualization define 'setting...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1711 Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] Visit and switch notebook revis...

Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1675 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1675 created issue under [ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745) for second part --- If your project is set up for it, you can reply to this email and have your re

[jira] [Created] (ZEPPELIN-1745) Offline or non-editable view of notes when viewing revisions and as a feature itself

Khalid Huseynov created ZEPPELIN-1745: - Summary: Offline or non-editable view of notes when viewing revisions and as a feature itself Key: ZEPPELIN-1745 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1745

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1675 @khalidhuseynov sounds good. Let's wait for CI becomes green. Other than that, Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1675 @Leemoonsoo yes right currently it's editable and runnable, which is updated in PR description. Actually I want to add additional `offline` or `report-offline` mode and basically switch to

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1675 Tested and it works well. Great work @khalidhuseynov. But when i visit revision, shouldn't it be immutable? i can still edit and run. --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 @krskoondra Thanks for the nice feature. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1714 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1715 Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 I've tested more and it was fine most times. But occasionally it doesn't work well. I think it should be tested more! I don't know why for now but I will figure it out and ping when it's ready :)

[GitHub] zeppelin pull request #1722: [HOTFIX] substitute null check for the refactor...

GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1722 [HOTFIX] substitute null check for the refactored Revision class ### What is this PR for? This is to fix minor bug introduced by #1697 ### What type of PR is it? Bug Fix |

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1675 this is ready for review. @Leemoonsoo let me know if you have any feedback regarding this one. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1692 @cloverhearts Nice! Hope the new version will be released soon :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692 Thank you very much, @tae-jun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1692 There is an input problem other than English, such as Japanese and Korean. To solve this problem, Zeppelin needs to upgrade the Ace editor. We have responded to the latest ace editor fi

[GitHub] zeppelin issue #1719: [ZEPPELIN-965] missing lastExecuteTime function

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1719 Tested. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1721: [ZEPPELIN-969] order by note name in job menu

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1721 Working as expected. LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1717: [ZEPPELIN-1744] replace to movement for paragraph in j...

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1717 Working well. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 Thanks @Leemoonsoo! I appreciate your review 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 @astroshim Thank you, have a good day! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1716 It's working as expected. Thank you for great improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1720: Fix case where user use zeppelin in normal mode with t...

Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1720 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i