Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda Yeah makes sense. Looks GOOD to me ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Thanks for detailed review!
Those things are about regex and mixed boolean condition (without parens),
so I am sure i can keep the original intention. ð..
---
If your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2236
Merge into master if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda Great work! Quickly looked through the most of file changes and it
looks good. Zeppelin web is getting bigger, everyone will feel the necessity of
this kind of lint rule.
btw
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2248
@1ambda I just updated it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Hoon Park created ZEPPELIN-2404:
---
Summary: Prettify Interpreter Setting
Key: ZEPPELIN-2404
URL: https://issues.apache.org/jira/browse/ZEPPELIN-2404
Project: Zeppelin
Issue Type: Bug
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2248
Works as described. LGTM except 2 comments I left
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2240
Thanks for explain.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2245
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Could you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2249
@zjffdu do you mind update corresponding docs, too?
`docs/displaysystem/back-end-angular.md`
And front-end expose angular display system apis. Do you think this guy
need to
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2098
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Yes, I thought of few options but this was bit con
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2229
From my earlier comment, I'm interested in others thought on having very
Hive specific logic in the generic JDBC interpreter?
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@AhyoungRyu Could you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2252
[ZEPPELIN-1940] lint rule set is NOT applied at all.
### What is this PR for?
eslint ruleset is NOT applied at all due to invalid `.eslintrc`.
This PR includes
- fixes
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2251
[ZEPPELIN-2403] added interpreter property types
### What is this PR for?
Added types to properties of interpreters. Those are types for properties
customization. Properties must have
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2133
@Leemoonsoo Thanks for review!
Right! Label would be better :+1:
Let me update again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2248
I added `command+L` and changed `Alt` and `Option` feature to flexibly
remove some binding shortcut key.
And, I updated the document as your comment.
Could you review again @1ambda ?
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2250
Using paste mode would be better. We have so many if-else code to
manipulate code which is already covered by paste mode.
If we evaluate using paste mode, evaluation orders will be
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2223
Thanks @benoyantony will merge it if no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/2250
[WIP][ZEPPELIN-2085] Interpret scala code in paste mode
### What is this PR for?
Don't split scala code to lines.
Interpreter code becomes more and more complicated because some lines
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2240
@Leemoonsoo Thanks for suggestion, the second approach works, but I didn't
find a way to take `InterpreterContext` automatically. Another scenario is that
user may do need to run the current
Tinkoff DWH created ZEPPELIN-2403:
-
Summary: Add types to property of interpreter
Key: ZEPPELIN-2403
URL: https://issues.apache.org/jira/browse/ZEPPELIN-2403
Project: Zeppelin
Issue Type:
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2245
@Leemoonsoo Please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2245
@Leemoonsoo @felixcheung Please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
27 matches
Mail list logo
