[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2265 @AhyoungRyu I'v just updated code. But Jenkins is not triggered. - (Travis) https://travis-ci.org/1ambda/zeppelin/builds/224840876 --- If your project is set up for it, you can

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2265 It seems that `unpkg.com` is broken. Before, i was able to download it (CI as well) ``` $ headroom.js git:(ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down) ✗ pwd /Us

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2265 @1ambda Yeah right right I misapprehended actually. It was my bad. Btw I wanted to test this locally but failed when I run `yarn install` and got this below 404 error. ``` [{

[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...

2017-04-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2270 Tested. Works really nicely! really cool! LGTM and merge to master if no further discussions! --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] zeppelin issue #2271: [ZEPPELIN-2414] Memory leak under scoped mode of Spark...

2017-04-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2271 Thanks @hammertank for the contribution. What do you think wrap interpreter using [ClassLoaderInterpreter](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/j

[GitHub] zeppelin pull request #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPAT...

2017-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2273: [ZEPPELIN-2439] Use babel-preset-env to specify...

2017-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...

2017-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #2276: [ZEPPELIN-2410]: Using UUID from filename in re...

2017-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...

2017-04-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2270 @soralee Thanks for review. @Leemoonsoo I update code and GIF in PR description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2229 actually, I wasn't referring to the function name at all. instead of having this fairly hive specific, how about a function like this to take the user name property name and value ``

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2274 great - just my preference - I actually like the tighter spacing and without line separator look better... --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2274 LGTM!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Thanks @tae-jun for seeing :slightly_smiling_face: And, @1ambda I updated this as your comments! ![image](https://cloud.githubusercontent.com/assets/8110458/25309416/dada13ba-2807-11e7-985

[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...

2017-04-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2270 Tested and it's work nicely! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-04-22 Thread alourie
Github user alourie commented on the issue: https://github.com/apache/zeppelin/pull/2238 Hi @Leemoonsoo! I have it in my task list, will get to it probably next week. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2274 Cool! Significantly better than before 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Thank you @1ambda @felixcheung for seeing this! Yeah, I like @1ambda's opinions! Let me update those as @1ambda's comments. --- If your project is set up for it, you can reply to this email a

[GitHub] zeppelin issue #2275: [ZEPPELIN-2442] button to create note into folder (nav...

2017-04-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2275 @felixcheung thanks for review Yes, but unfortunately the tooltip does not work correctly in this menu. I'll think how to fix it. --- If your project is set up for it, you can reply to t