[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2361 @1ambda could you check uploaded `before/after` image files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2358 About `clone note` and `create note`, both look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in...

2017-05-21 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2361 [ZEPPELIN-2131] Restrict `shift + arrow` key in focused cell ### What is this PR for? Selection of text in cell by Shift-Arrow should be restricted to focussed cell. ### What

[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2360 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2360 @1ambda Thanks for improving dialog! I'll test it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2359 @1ambda I'll test it out and give you a feedback! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2358 @1ambda Thanks for improving dialog! I'll test it out and give you a feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style

2017-05-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2357 @1ambda, Sure! Nice feature! Let me test it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2356 Awesome @1ambda I love this feature. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2360 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2356 @zjffdu Could you help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2359 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2357 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2358 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2356 [ZEPPELIN-2460] Highlight active line in editor ### What is this PR for? Highlight active line. ### What type of PR is it? [Improvement] ### Todos * [x] -

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Adding a servlet to the zeppelin project

2017-05-21 Thread Minudika Malshan
Hi all, I am writing a custom interpreter and it renders an html page which is consisted of a html form as the result. I also have written the servlet to handle the request from that html page and added it to the WEB-INF/web.xml file. But when I trigger the action, it gives me a 404 error

[GitHub] zeppelin pull request #2353: [branch-0.7] missed try catch.

2017-05-21 Thread cloverhearts
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2353: [branch-0.7] missed try catch.

2017-05-21 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2353 merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...

2017-05-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2317 LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...

2017-05-21 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...

2017-05-21 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2359 [ZEPPELIN-2575] Improve `rename note` dialog style ### What is this PR for? Improve `rename notebook` dialog style. See the attached screenshots. ### What type of PR is

[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...

2017-05-21 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2358 [ZEPPELIN-2428] Improve `create new note` dialog style ### What is this PR for? Improve `create new notebook` dialog style. See the attached screenshots. ### What type of PR is

[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...

2017-05-21 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2341: ZEPPELIN-2543: Add ability to change the log level at ...

2017-05-21 Thread karuppayya
Github user karuppayya commented on the issue: https://github.com/apache/zeppelin/pull/2341 @1ambda Thanks for the feedback. I had added API to Zeppelin rest API name space. Let me know if that is fine Also adding documentation was in my TODO list, done now.

[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...

2017-05-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2317 @1ambda Thanks for the review! 😄 I didn't know that you asked me to add a test 😢 Was it added after the editing? But, since you said it is not necessary, I will just

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-05-21 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @1ambda I have added the log. Regarding you second comment, I am not sure what you mean. Is there something I should change? Is it not working as expected? --- If your project is set up for

[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2317 Mostly about documentation. Not necessary to write a new test. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2341: ZEPPELIN-2543: Add ability to change the log level at ...

2017-05-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2341 IMO, we can add documentation for this API in http://zeppelin.apache.org/docs/0.7.1/rest-api/rest-configuration.html --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2356 [ZEPPELIN-2460] Highlight active line in editor ### What is this PR for? Highlight active line. ### What type of PR is it? [Improvement] ### Todos * [x] -

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2360: Improve about dialgo

2017-05-21 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2360 Improve about dialgo ### What is this PR for? Improve `about` dialog style. See the attached screenshots. ### What type of PR is it? [Improvement] ### Todos

[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...

2017-05-21 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2359 [ZEPPELIN-2575] Improve `rename note` dialog style ### What is this PR for? Improve `rename notebook` dialog style. See the attached screenshots. ### What type of PR is it?

[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...

2017-05-21 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2358 [ZEPPELIN-2428] Improve `create new note` dialog style ### What is this PR for? Improve `create new notebook` dialog style. See the attached screenshots. ### What type of PR is

[jira] [Created] (ZEPPELIN-2574) Improve About Dialog Style

2017-05-21 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2574: --- Summary: Improve About Dialog Style Key: ZEPPELIN-2574 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2574 Project: Zeppelin Issue Type: Improvement

[jira] [Created] (ZEPPELIN-2575) Improve Rename Dialog Style

2017-05-21 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2575: --- Summary: Improve Rename Dialog Style Key: ZEPPELIN-2575 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2575 Project: Zeppelin Issue Type: Improvement

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

2017-05-21 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2356 [ZEPPELIN-2460] Highlight active line in editor ### What is this PR for? Highlight active line. ### What type of PR is it? [Improvement] ### Todos * [x] -