[GitHub] zeppelin issue #2415: [ZEPPELIN-2661]Test: personalized mode action

2017-07-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2415 LGTM. Merge if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 I am not sure whether this is a good idea to put custom initialization code in interpreter setting. Because I think one goal of notebook is to allow user to reproduce it easily without change

[GitHub] zeppelin issue #2272: ZEPPELIN-2397. Add toJson and fromJson method for seri...

2017-07-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2272 @jongyoul @felixcheung Comments are address, please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2418 Sorry @jongyoul I did a investigation on netty, it looks like we could use Channel directly. In that way I would prefer to use netty. But still I think we need to have a good design for the

[jira] [Created] (ZEPPELIN-2715) spark.jars.packages doesn't take effect

2017-07-01 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2715: Summary: spark.jars.packages doesn't take effect Key: ZEPPELIN-2715 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2715 Project: Zeppelin Issue Type:

[GitHub] zeppelin issue #2453: [ZEPPELIN-2659] Let WebEnvironment initialize Security...

2017-07-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2453 Tested and LGTM. Thanks @sctincman for the contribution. Merge to master if no further comment. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2333: Notebook: (Web) HDFS as a backend storage (Read & Writ...

2017-07-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2333 maybe add one property to allow user to choose which method to use. And HdfsNoteBookRepo can delegate the real work to `WebHdfsNotebookRepo` and `NativeHdfsNotebookRepo` --- If your project is

[GitHub] zeppelin issue #2457: [ZEPPELIN-2713] Fix NPE of notebook creat rest api if ...

2017-07-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2457 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2454: [ZEPPELIN-2710] Programmatically update progress bar

2017-07-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2454 Merge to master if no further comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2452: [ZEPPELIN-2706] Fix unable to remove selected keys in ...

2017-07-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2452 Merge to master if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature