[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

2017-07-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Thanks for the contribution @yanboliang. I left a comment. Could you check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy Thanks for the contribution. Tested and works well, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2473: [fix] Check runtimeInfos is not null

2017-07-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2473 Hi, Thanks for the contribution. 1. Could you make the failed job be green? - https://travis-ci.org/ebuildy/zeppelin/jobs/251686246 2. Please make a JIRA ticket for this issue. ---

[GitHub] zeppelin issue #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUserList....

2017-07-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2487 LGTM merge if no more discussion. referred https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet#Defense_Option_1:_Prepared_Statements_.28with_Parameterized_Queries.29

[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-07-13 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2428 ping - please advise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

2017-07-13 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/zeppelin/pull/2475 cc @Leemoonsoo @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUserList....

2017-07-13 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/zeppelin/pull/2487 cc @Leemoonsoo @jongyoul Would you mind to have a look? This is just an enhancement for preventing from SQL injection. Thanks. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @Leemoonsoo Regarding the ZeppelinContext, could you try that again ? It is covered in unit test, so should be able to work. I force committed it yesterday, the latest commit Id is

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Thanks a lots :slightly_smiling_face: Let me test it out again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Embedding notebooks and paragraphs

2017-07-13 Thread Andrew Musselman
Hi Zeppelin team, I'm wondering if you have a sense of how hard it would be to embed the input portion of a paragraph, and/or an entire notebook, into another web UI. I see https://issues.apache.org/jira/browse/ZEPPELIN-1268 but it still seems to deal with just the output portion of the

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Thanks for testing @Leemoonsoo . These special characters are for font color, create ZEPPELIN-2756 for that which might need help from @1ambda --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-07-13 Thread alourie
Github user alourie commented on the issue: https://github.com/apache/zeppelin/pull/2238 @Leemoonsoo my Jira ID is alourie, but please assign it to Rob Marshall, who opened the ticket. He did all the development, I just helped with the PR/CI :-) --- If your project is set up for

[GitHub] zeppelin pull request #2488: Add z.show() feature to docs

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-07-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2238 LGTM. Merge this PR to master if no further discussions. @alourie Could you let me know your JIRA id? i'd like to mark https://issues.apache.org/jira/browse/ZEPPELIN-1501 resolved with

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-13 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 hmm I'll see if I can somehow split "report mode" and "view only mode". I didnt experience the Helium issue, personally --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

2017-07-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2374 hmm I see. I can see "continuously" can make sense. It's a bit vague though. Perhaps "on all changes"? sorry that might not be better :) --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

2017-07-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 @soralee Thanks for the review. We need to keep the zeppelin-web module clean. :) Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-07-13 Thread alourie
Github user alourie commented on the issue: https://github.com/apache/zeppelin/pull/2238 @Leemoonsoo oh wow, who knew. So now it works. All checks passed :-) Thanks for the help! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/2458 Nop sorry, this is very good suggestions, I was at Berlin for work, I am doing this now! Thanks you, --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Hey, @ebuildy! If you don't want to improve my suggestion(#2458 (comment)), please let us know so that we will start merge process, I guess. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

2017-07-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2472 Cool, I also experienced as like what your describing at especially filename and messy folders. And Tested and LGTM. Everything is working. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

2017-07-13 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2374 @felixcheung actually that means to persist in default way, since Zeppelin persists on most of user activities so it seems to be "continuously". another way would be to call it "default" i

[GitHub] zeppelin issue #2486: [ZEPPELIN-2768]. Bump up Spark version to 2.2.0

2017-07-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2486 Will merge it if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-13 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2448 @1ambda actually it would rename on first save, it can be run, edit paragraph, or rename. Regarding renaming for all notes in the beginning it was discussed actually above and I think we

[GitHub] zeppelin issue #2482: [ZEPPELIN-2765] Configurable X-FRAME-OPTIONS for Zeppe...

2017-07-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2482 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #2481: [HOTFIX][ZEPPELIN-2760] fix JDBC regression cau...

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2471: [ZEPPELIN-2744] [minor] Increase error handling...

2017-07-13 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2329 @jongyoul Any updates ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

2017-07-13 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2446 @1ambda ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin pull request #2490: Zeppelin 2718 Find and replace code in note

2017-07-13 Thread tinkoff-dwh
GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2490 Zeppelin 2718 Find and replace code in note ### What is this PR for? Add feature for find and replace code in all paragraphs of note ### What type of PR is it? [Feature]