[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-16 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 @1ambda I did some investtigation on that, and puts some links in https://issues.apache.org/jira/browse/ZEPPELIN-2756, hope it would be helpful for you. --- If your project is set up for it, you

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 Hi, @malayhm Could you take a look the comment I left? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2474 Let create a PR to fix the ASCII issue, we can test this PR based on the ASCII PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2478 Thanks for the great feature! since this is a big change, I guess it takes a time to review and requires multiple reviewers. Let me take a look. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta Tested locally and it works well. Could you rebase using the current master? since the base branch looks quite old. LGTM except for it. --- If your project is set up for

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Left a comment, except for it, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUs...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 CI is green, I think jenkins was restarted somehow. - https://travis-ci.org/ebuildy/zeppelin/builds/253975556 LGTM merge if no more discussion. --- If your project is set up for

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-16 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy could you check CI? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #2455: ZEPPELIN-1515. Notebook: HDFS as a backend stor...

2017-07-16 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/2455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2455: ZEPPELIN-1515. Notebook: HDFS as a backend stor...

2017-07-16 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/2455 ZEPPELIN-1515. Notebook: HDFS as a backend storage (Use hadoop client jar) ### What is this PR for? This PR is trying to add hdfs as another implementation for `NotebookRepo`. There's

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-16 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Thanks @Leemoonsoo for catching that. This is due to I miss cursor for code completion. Just pushed another commit to fix that and add more unit test for it. ``` // there's no

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2474 Is it expected completion list? ![image](https://user-images.githubusercontent.com/1540981/28252185-32d695a8-6ac9-11e7-9f29-2257700990d0.png) --- If your project is set up for it, you

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2474 Yes, that works. It is covered in unit test (https://github.com/apache/zeppelin/pull/2474/files#diff-d9c8252d37a199d13b7157e88041c0e9R124). Also I manually verified it --- If your project is

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-07-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2474 Tested 88a1f2f and ZeppelinContext works well. Does auto completion supposed to work? --- If your project is set up for it, you can reply to this email and have your reply appear on

[DISCUSS] Release 0.8.0

2017-07-16 Thread Park Hoon
Hi, @user and @dev. Recently, The last major release was about 5 months ago and many new features bug fixes have been implemented / applied for few months. Even though all features discussed in the thread before (“Roadmap for 0.8.0”[1]), some are available now. So I think we can release 0.8.0