Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3011
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3011
LGTM, wait for CI pass
---
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3011
[HOTFIX][ZEPPELIN-3526] fix when no shiro.ini exists
### What is this PR for?
This is a side effect of ZEPPELIN-3526, occurs when there's no shiro.ini in
the classpath.
###
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@Tagar thanks for your comments.
The thought here was to make the best of a bad situation. If and when the
`delete()` fails, no recovery action is possible at the user level. So
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2993
---
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3003
---
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3004
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3009
Thanks for the review will merge this soon.
---
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3008
---
Github user milooy commented on the issue:
https://github.com/apache/zeppelin/pull/2994
@r-kamath @Leemoonsoo
What do I need to do more to merge the PR?
---
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2999
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Agreed @zjffdu.
I also made two other (similar) changes. If the `tempFile.delete()` fails,
then `tempFile.deleteOnExit()` is invoked to request the system to handle it if
possible
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3010
---
13 matches
Mail list logo