[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-13 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 Yes it is! :) ---

Re: [DISCUSS] Make interpreters' repository

2018-12-13 Thread Jeff Zhang
Thanks @Jongyoul Lee , let's clean the interface first. Jongyoul Lee 于2018年12月14日周五 下午1:51写道: > Thanks, Jeff and Felix, > > I simply thought it would be better to construct a more clear view for > devs. But, as you mentioned, it could scatter our concentrations. Let's try > to do efforts to

Re: [DISCUSS] Make interpreters' repository

2018-12-13 Thread Jongyoul Lee
Thanks, Jeff and Felix, I simply thought it would be better to construct a more clear view for devs. But, as you mentioned, it could scatter our concentrations. Let's try to do efforts to clean up our code and test scenarios inside one repository. Thank you guys. On Fri, Dec 14, 2018 at 12:03

Re: [DISCUSS] Moving to gitbox

2018-12-13 Thread Jongyoul Lee
Yes, right. That's because Infra suggests that we leave a mail thread to make a consensus about it. On Fri, Dec 14, 2018 at 12:14 PM Felix Cheung wrote: > Hi Jongyoul - is this the same as the earlier thread? > > > > From: Jongyoul Lee > Sent: Tuesday,

[GitHub] zeppelin issue #3262: [ZEPPELIN-3902]upgrade jetty version

2018-12-13 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3262 Thank you so much for your first contribution. :-) Will merge it ---

[GitHub] zeppelin issue #3262: [ZEPPELIN-3902]upgrade jetty version

2018-12-13 Thread fred521
Github user fred521 commented on the issue: https://github.com/apache/zeppelin/pull/3262 My email daizhi...@gmail.com Actually I have done a lot of fixes this year. Trying to merge back now. Thanks again On Thu, Dec 13, 2018 at 21:29

[GitHub] zeppelin issue #3262: [ZEPPELIN-3902]upgrade jetty version

2018-12-13 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3262 @fred521 BTW, Could you please tell me your jira id or email address? I need to register you as a contributor ---

[GitHub] zeppelin pull request #3262: [ZEPPELIN-3902]upgrade jetty version

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3262 ---

[GitHub] zeppelin issue #3262: [ZEPPELIN-3902]upgrade jetty version

2018-12-13 Thread fred521
Github user fred521 commented on the issue: https://github.com/apache/zeppelin/pull/3262 Cool @jongyoul thanks, done with that please let me know if anything else I will need to follow > @fred521 Thanks. The last thing. Can you update your title including

[GitHub] zeppelin issue #3262: upgrade jetty version

2018-12-13 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3262 @fred521 Thanks. The last thing. Can you update your title including '[ZEPPELIN-3902]'? ---

[GitHub] zeppelin issue #3262: upgrade jetty version

2018-12-13 Thread fred521
Github user fred521 commented on the issue: https://github.com/apache/zeppelin/pull/3262 > @fred521 I've found one of your tests failed. https://travis-ci.org/fred521/zeppelin/builds/467287988 Could you please check it again? Thanks seems randomly failed for the network

[GitHub] zeppelin issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visual...

2018-12-13 Thread fred521
Github user fred521 commented on the issue: https://github.com/apache/zeppelin/pull/3254 UI-Grid actually creates a lot of performance issue, why not deprecate it but still introducing new feature? In my service, I completely wiped out UI-Grid ---

Re: [DISCUSS] Moving to gitbox

2018-12-13 Thread Felix Cheung
Hi Jongyoul - is this the same as the earlier thread? From: Jongyoul Lee Sent: Tuesday, December 11, 2018 6:28 PM To: dev Subject: [DISCUSS] Moving to gitbox Hi, devs, I'd like to make a consensus to move our repository from git-wip to gitbox. Please give

Re: [DISCUSS] Make interpreters' repository

2018-12-13 Thread Jeff Zhang
Agree with Felix, this is what I also concern in my last email. @Jongyoul Lee Could you explain more about how separate repo help here ? Thanks Felix Cheung 于2018年12月14日周五 上午11:00写道: > In my opinion, definitely a clean interface will be very useful and having > a better way to test is good.

Re: [DISCUSS] Make interpreters' repository

2018-12-13 Thread Felix Cheung
In my opinion, definitely a clean interface will be very useful and having a better way to test is good. But sounds to me like these should be possible without a code repo separation? The downside of separate repo (I assume still under ASF) is the spreading the attention of committers and

[GitHub] zeppelin issue #3262: upgrade jetty version

2018-12-13 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3262 @fred521 I've found one of your tests failed. https://travis-ci.org/fred521/zeppelin/builds/467287988 Could you please check it again? ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 @monsieurp Is `Patrice Clement` your jira account ? I'd like to assign this ticket to you. ---

[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3239 ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-13 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 @zffdu: Sorry for not responding earlier. IMHO, deleting `common.max_count` should be dealt with in a separate PR / bug report since it is completely unrelated to the feature here. Until then,

[GitHub] zeppelin issue #3262: upgrade jetty version

2018-12-13 Thread fred521
Github user fred521 commented on the issue: https://github.com/apache/zeppelin/pull/3262 Hi @jongyoul can you help to merge it? the CI passed Thanks ---

[GitHub] zeppelin issue #3262: upgrade jetty version

2018-12-13 Thread fred521
Github user fred521 commented on the issue: https://github.com/apache/zeppelin/pull/3262 Thanks @felixcheung I have updated it ---

[GitHub] zeppelin pull request #3199: ZEPPELIN-3792. Support Kerberos Realm

2018-12-13 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/3199 ---

[GitHub] zeppelin pull request #3263: ZEPPELIN-3907. Add code statement into Spark Jo...

2018-12-13 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3263 ZEPPELIN-3907. Add code statement into Spark JobGroup Id for SparkInterpreter ### What is this PR for? Straightforward change to add code statement into Spark JobGroupId, so that we can