[GitHub] [zeppelin] Reamer commented on pull request #3895: [ZEPPELIN-5015]. upgrade shiro

2020-09-12 Thread GitBox
Reamer commented on pull request #3895: URL: https://github.com/apache/zeppelin/pull/3895#issuecomment-691030563 LGTM manually tested. Can you share the travis-ci link. This is an automated message from the Apache Git

[GitHub] [zeppelin] kortemik commented on pull request #3901: Change license to be compatible with license of com.hadoop.gplcompres…

2020-09-12 Thread GitBox
kortemik commented on pull request #3901: URL: https://github.com/apache/zeppelin/pull/3901#issuecomment-690992968 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] Reamer edited a comment on pull request #3895: [ZEPPELIN-5015]. upgrade shiro

2020-09-12 Thread GitBox
Reamer edited a comment on pull request #3895: URL: https://github.com/apache/zeppelin/pull/3895#issuecomment-691030563 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] Reamer commented on a change in pull request #3833: [ZEPPELIN-4910]. Don‘t convert relative path to local absolute path when using hadoop filesystem

2020-09-12 Thread GitBox
Reamer commented on a change in pull request #3833: URL: https://github.com/apache/zeppelin/pull/3833#discussion_r487024087 ## File path: zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java ## @@ -35,7 +35,8

[GitHub] [zeppelin] Reamer commented on pull request #3895: [ZEPPELIN-5015]. upgrade shiro

2020-09-12 Thread GitBox
Reamer commented on pull request #3895: URL: https://github.com/apache/zeppelin/pull/3895#issuecomment-691030563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] kortemik commented on pull request #3901: Change license to be compatible with license of com.hadoop.gplcompres…

2020-09-12 Thread GitBox
kortemik commented on pull request #3901: URL: https://github.com/apache/zeppelin/pull/3901#issuecomment-690992968 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] Reamer edited a comment on pull request #3895: [ZEPPELIN-5015]. upgrade shiro

2020-09-12 Thread GitBox
Reamer edited a comment on pull request #3895: URL: https://github.com/apache/zeppelin/pull/3895#issuecomment-691030563 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] Reamer commented on a change in pull request #3833: [ZEPPELIN-4910]. Don‘t convert relative path to local absolute path when using hadoop filesystem

2020-09-12 Thread GitBox
Reamer commented on a change in pull request #3833: URL: https://github.com/apache/zeppelin/pull/3833#discussion_r487024087 ## File path: zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java ## @@ -35,7 +35,8

[GitHub] [zeppelin] Reamer commented on pull request #3895: [ZEPPELIN-5015]. upgrade shiro

2020-09-12 Thread GitBox
Reamer commented on pull request #3895: URL: https://github.com/apache/zeppelin/pull/3895#issuecomment-691030563 LGTM manually tested. Can you share the travis-ci link. This is an automated message from the Apache Git

[GitHub] [zeppelin] kortemik commented on pull request #3901: Change license to be compatible with license of com.hadoop.gplcompres…

2020-09-12 Thread GitBox
kortemik commented on pull request #3901: URL: https://github.com/apache/zeppelin/pull/3901#issuecomment-690992968 There we have it https://github.com/twitter/scalding/pull/1932 (: This is an automated message from the

[GitHub] [zeppelin] zjffdu opened a new pull request #3905: Revert "[ZEPPELIN-4681]. Shade thrift in zeppelin-interpreter-shaded"

2020-09-12 Thread GitBox
zjffdu opened a new pull request #3905: URL: https://github.com/apache/zeppelin/pull/3905 This reverts commit 39af1878c7b7d5423b5abdca1fde2bea940bb0d8. ### What is this PR for? thrift is used explicitly in zeppelin, we should not shade it. e.g. TException could not be found

[jira] [Created] (ZEPPELIN-5037) Upgrade spark to 3.0.1

2020-09-12 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5037: Summary: Upgrade spark to 3.0.1 Key: ZEPPELIN-5037 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5037 Project: Zeppelin Issue Type: Improvement

[GitHub] [zeppelin] zjffdu opened a new pull request #3904: [ZEPPELIN-5035]. ZeppelinClient#getSession should return null when there's no such session

2020-09-12 Thread GitBox
zjffdu opened a new pull request #3904: URL: https://github.com/apache/zeppelin/pull/3904 ### What is this PR for? Currently it would throw exception when there's no such session, it would make the api user confused. It is better to just return null when there's no such session.

[GitHub] [zeppelin] zjffdu opened a new pull request #3903: [ZEPPELIN-5036]. zeppelin.interpreter.dep.mvnRepo doesn't take effect

2020-09-12 Thread GitBox
zjffdu opened a new pull request #3903: URL: https://github.com/apache/zeppelin/pull/3903 ### What is this PR for? Simple PR to fix the issue of `zeppelin.interpreter.dep.mvnRepo` doesn't take effect. Should use ZeppelinConfiguration instead of System.getProperty ### What

[jira] [Created] (ZEPPELIN-5036) zeppelin.interpreter.dep.mvnRepo doesn't take effect

2020-09-12 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5036: Summary: zeppelin.interpreter.dep.mvnRepo doesn't take effect Key: ZEPPELIN-5036 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5036 Project: Zeppelin

[GitHub] [zeppelin] zjffdu opened a new pull request #3902: [ZEPPELIN-5034]. spark.driver.extraClassPath in spark-defaults.xml is override by zeppelin

2020-09-12 Thread GitBox
zjffdu opened a new pull request #3902: URL: https://github.com/apache/zeppelin/pull/3902 ### What is this PR for? The issue is that `spark.driver.extraClassPath` in spark-defaults.conf won't take effect because it would be override by zeppelin. Because in interpreter.sh