[GitHub] [zeppelin] zjffdu commented on pull request #4021: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
zjffdu commented on pull request #4021: URL: https://github.com/apache/zeppelin/pull/4021#issuecomment-759875599 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] amit-shahi commented on pull request #3356: [ZEPPELIN-3994] Notebook serving

2021-01-13 Thread GitBox
amit-shahi commented on pull request #3356: URL: https://github.com/apache/zeppelin/pull/3356#issuecomment-759726707 @zjffdu How do I set zeppelin.run.mode as local in zeppelin-site.xml? This is an automated message from

[GitHub] [zeppelin] amit-shahi commented on pull request #3356: [ZEPPELIN-3994] Notebook serving

2021-01-13 Thread GitBox
amit-shahi commented on pull request #3356: URL: https://github.com/apache/zeppelin/pull/3356#issuecomment-759559224 @zjffdu When I try to execute this YAML https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml thru kubectl apply -f zeppelin-server.yaml, I see this

[GitHub] [zeppelin] Reamer commented on pull request #4020: [ZEPPELIN-5130] Cleanup in ShiroAuthentication and related realms

2021-01-13 Thread GitBox
Reamer commented on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759556334 @zjffdu Thank you for your thoughts. You are right that this PR does not really match the [JIRA ticket ZEPPELIN-5198](https://issues.apache.org/jira/browse/ZEPPELIN-5198) that

[GitHub] [zeppelin] Reamer opened a new pull request #4021: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
Reamer opened a new pull request #4021: URL: https://github.com/apache/zeppelin/pull/4021 ### What is this PR for? This PR includes - remove PrincipalImpl out of ShiroAuthenticationServiceTest.java ### What type of PR is it? - Refactoring ### What is the Jira issue?

[jira] [Created] (ZEPPELIN-5200) Docker Images not working

2021-01-13 Thread Andreas Eberle (Jira)
Andreas Eberle created ZEPPELIN-5200: Summary: Docker Images not working Key: ZEPPELIN-5200 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5200 Project: Zeppelin Issue Type: Bug

[GitHub] [zeppelin] Reamer commented on pull request #4020: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
Reamer commented on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759505787 > Maybe you can use a more proper title for this PR. It includes lots of stuff which is not related with PrincipalImpl Ich werde diese PR teilen.

[GitHub] [zeppelin] amit-shahi commented on pull request #3356: [ZEPPELIN-3994] Notebook serving

2021-01-13 Thread GitBox
amit-shahi commented on pull request #3356: URL: https://github.com/apache/zeppelin/pull/3356#issuecomment-759506138 @zjffdu Ok, I will create a thread on the mailing list. This is an automated message from the Apache Git

[GitHub] [zeppelin] Reamer edited a comment on pull request #4020: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
Reamer edited a comment on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759505787 > Maybe you can use a more proper title for this PR. It includes lots of stuff which is not related with PrincipalImpl I'll split this PR.

[GitHub] [zeppelin] Reamer edited a comment on pull request #4020: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
Reamer edited a comment on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759489519 I will merge this into master and branch-0.9 on Monday (18/01/2021) if no further comments are received.

[GitHub] [zeppelin] zjffdu edited a comment on pull request #4020: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
zjffdu edited a comment on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759497010 Maybe you can use a more proper title for this PR. It includes lots of stuff which is not related with PrincipalImpl

[GitHub] [zeppelin] zjffdu commented on pull request #4020: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
zjffdu commented on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759497010 Maybe you can use a more proper title for this PR. It includes lots of stuff which is not related with PrinciplaImpl

[GitHub] [zeppelin] Reamer commented on pull request #4020: [ZEPPELIN-5198] Remove PrincipalImpl, which is not part of the java API

2021-01-13 Thread GitBox
Reamer commented on pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020#issuecomment-759489519 I will incorporate this into master and branch-0.9 on Monday (18/01/2021) if no further comments are received.

[GitHub] [zeppelin] asfgit closed pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

2021-01-13 Thread GitBox
asfgit closed pull request #4018: URL: https://github.com/apache/zeppelin/pull/4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] zjffdu commented on pull request #3356: [ZEPPELIN-3994] Notebook serving

2021-01-13 Thread GitBox
zjffdu commented on pull request #3356: URL: https://github.com/apache/zeppelin/pull/3356#issuecomment-759458102 @amit-shahi Let's discuss that in user mail list. This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] amit-shahi commented on pull request #3356: [ZEPPELIN-3994] Notebook serving

2021-01-13 Thread GitBox
amit-shahi commented on pull request #3356: URL: https://github.com/apache/zeppelin/pull/3356#issuecomment-759456625 @zjffdu Thanks. I'm using this k8 YAML https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml Is there a different image for interpreter