[GitHub] [zeppelin] Reamer commented on pull request #4002: [ZEPPELIN-5178] notebook search not working on JDK11

2021-01-18 Thread GitBox
Reamer commented on pull request #4002: URL: https://github.com/apache/zeppelin/pull/4002#issuecomment-762660519 > We don't have CI for JDK11, maybe we should add that I have created a ticket for this: https://issues.apache.org/jira/browse/ZEPPELIN-5207

[jira] [Created] (ZEPPELIN-5207) JDK 11 Support - CI

2021-01-18 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5207: Summary: JDK 11 Support - CI Key: ZEPPELIN-5207 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5207 Project: Zeppelin Issue Type: Sub-task

[jira] [Created] (ZEPPELIN-5206) JDK 11 Support

2021-01-18 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5206: Summary: JDK 11 Support Key: ZEPPELIN-5206 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5206 Project: Zeppelin Issue Type: New Feature

[GitHub] [zeppelin] Reamer commented on pull request #4002: [ZEPPELIN-5178] notebook search not working on JDK11

2021-01-18 Thread GitBox
Reamer commented on pull request #4002: URL: https://github.com/apache/zeppelin/pull/4002#issuecomment-762657648 I would like to merge this PR. Does anyone know what we have to write in the licence file? This is an

[GitHub] [zeppelin] asfgit closed pull request #4020: [ZEPPELIN-5130] Cleanup in ShiroAuthentication and related realms

2021-01-18 Thread GitBox
asfgit closed pull request #4020: URL: https://github.com/apache/zeppelin/pull/4020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Reamer commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI

2021-01-18 Thread GitBox
Reamer commented on pull request #4014: URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762340556 CI job that failed due to this race condition: https://github.com/apache/zeppelin/pull/3930/checks?check_run_id=1695607676

[GitHub] [zeppelin] Reamer commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI

2021-01-18 Thread GitBox
Reamer commented on pull request #4014: URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762123094 I will merge this pull request into master and branch-0.9 on Wednesday (20.01.2021) if no further comments are received.

[GitHub] [zeppelin] Reamer commented on a change in pull request #4014: [ZEPPELIN-5188] /note1 race condition CI

2021-01-18 Thread GitBox
Reamer commented on a change in pull request #4014: URL: https://github.com/apache/zeppelin/pull/4014#discussion_r559432841 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java ## @@ -1685,7 +1685,7 @@ public void onOutputUpdated(String

[GitHub] [zeppelin] zjffdu commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI

2021-01-18 Thread GitBox
zjffdu commented on pull request #4014: URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762113862 Thanks @Reamer LGTM This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] Reamer commented on pull request #4022: [ZEPPELIN-5200] Update dockerfile

2021-01-18 Thread GitBox
Reamer commented on pull request #4022: URL: https://github.com/apache/zeppelin/pull/4022#issuecomment-762112244 I also set the following environment variable in my Dockerfile, but I am using Spark from a different location. Are the Python libraries that Zeppelin provides loaded? ```

[GitHub] [zeppelin] Reamer commented on pull request #4022: [ZEPPELIN-5200] Update dockerfile

2021-01-18 Thread GitBox
Reamer commented on pull request #4022: URL: https://github.com/apache/zeppelin/pull/4022#issuecomment-762097399 > After I run 'python -m pip freeze', I could not find grpcio. I can find grpcio with `python -m pip freeze`. ``` 09:57 $ docker run -ti --rm zep-test bash I have

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4024: [ZEPPELIN-5199]. Should login via keytab first in jdbc interpreter

2021-01-18 Thread GitBox
zjffdu commented on a change in pull request #4024: URL: https://github.com/apache/zeppelin/pull/4024#discussion_r559402320 ## File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java ## @@ -207,6 +207,16 @@ protected boolean runKerberosLogin() {

[GitHub] [zeppelin] Reamer commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI

2021-01-18 Thread GitBox
Reamer commented on pull request #4014: URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762084849 > @Reamer In what kind of situation save will happen after removing ? I think this is a race condition during our integration tests. Checkout the JIRA ticket

[GitHub] [zeppelin] Reamer commented on a change in pull request #4024: [ZEPPELIN-5199]. Should login via keytab first in jdbc interpreter

2021-01-18 Thread GitBox
Reamer commented on a change in pull request #4024: URL: https://github.com/apache/zeppelin/pull/4024#discussion_r559093375 ## File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java ## @@ -207,6 +207,16 @@ protected boolean runKerberosLogin() {