[GitHub] [zeppelin] zjffdu commented on a change in pull request #4037: [ZEPPELIN-5218]. Don't exit shell interpreter if there's more logging produced

2021-02-04 Thread GitBox
zjffdu commented on a change in pull request #4037: URL: https://github.com/apache/zeppelin/pull/4037#discussion_r570735715 ## File path: shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java ## @@ -78,6 +106,10 @@ public void close() { } } }

[GitHub] [zeppelin] asfgit closed pull request #4042: [ZEPPELIN-5232]. Default value of zeppelin server memory & interpreter memory should be 1024m

2021-02-04 Thread GitBox
asfgit closed pull request #4042: URL: https://github.com/apache/zeppelin/pull/4042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] asfgit closed pull request #4038: [ZEPPELIN-5217]. Move %flink.cmd as a separated interpreter module

2021-02-04 Thread GitBox
asfgit closed pull request #4038: URL: https://github.com/apache/zeppelin/pull/4038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] asfgit closed pull request #4039: [ZEPPELIN-5204]. NPE when runAsOne is true in flink interpreter

2021-02-04 Thread GitBox
asfgit closed pull request #4039: URL: https://github.com/apache/zeppelin/pull/4039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] zjffdu commented on pull request #4045: ZEPPELIN-4952: Markdown interpreter can be used to store XSS in notebooks

2021-02-04 Thread GitBox
zjffdu commented on pull request #4045: URL: https://github.com/apache/zeppelin/pull/4045#issuecomment-773772187 LGTM, thanks @prabhjyotsingh Let's wait for its CI pass This is an automated message from the Apache Git

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4035: [ZEPPELIN-5225] Remote interpreter soft shutdown

2021-02-04 Thread GitBox
zjffdu commented on a change in pull request #4035: URL: https://github.com/apache/zeppelin/pull/4035#discussion_r570640802 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java ## @@ -0,0 +1,234 @@ +/* + *

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4035: [ZEPPELIN-5225] Remote interpreter soft shutdown

2021-02-04 Thread GitBox
zjffdu commented on a change in pull request #4035: URL: https://github.com/apache/zeppelin/pull/4035#discussion_r570639528 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java ## @@ -0,0 +1,234 @@ +/* + *

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4035: [ZEPPELIN-5225] Remote interpreter soft shutdown

2021-02-04 Thread GitBox
zjffdu commented on a change in pull request #4035: URL: https://github.com/apache/zeppelin/pull/4035#discussion_r570639170 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java ## @@ -0,0 +1,234 @@ +/* + *

[GitHub] [zeppelin] zjffdu commented on pull request #4039: [ZEPPELIN-5204]. NPE when runAsOne is true in flink interpreter

2021-02-04 Thread GitBox
zjffdu commented on pull request #4039: URL: https://github.com/apache/zeppelin/pull/4039#issuecomment-773685690 Will merge if no more comment This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] zjffdu commented on pull request #4042: [ZEPPELIN-5232]. Default value of zeppelin server memory & interpreter memory should be 1024m

2021-02-04 Thread GitBox
zjffdu commented on pull request #4042: URL: https://github.com/apache/zeppelin/pull/4042#issuecomment-773685421 Will merge if no more comment This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] zjffdu commented on pull request #4040: [ZEPPELIN-5228]. IPySpark unsupported environment would cause other spark interpreter fail

2021-02-04 Thread GitBox
zjffdu commented on pull request #4040: URL: https://github.com/apache/zeppelin/pull/4040#issuecomment-773685337 Will merge if no more comment This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] Reamer commented on pull request #4035: [ZEPPELIN-5225] Remote interpreter soft shutdown

2021-02-04 Thread GitBox
Reamer commented on pull request #4035: URL: https://github.com/apache/zeppelin/pull/4035#issuecomment-773321274 CI passed. I will merge this into master and branch-0.9 on Monday 08.02.2021 if no further comments are received.

[jira] [Created] (ZEPPELIN-5236) ConcurrentModificationException in NotebookAuthorizationInfoSaving

2021-02-04 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5236: Summary: ConcurrentModificationException in NotebookAuthorizationInfoSaving Key: ZEPPELIN-5236 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5236 Project:

[GitHub] [zeppelin] prabhjyotsingh commented on pull request #4045: ZEPPELIN-4952: Markdown interpreter can be used to store XSS in notebooks

2021-02-04 Thread GitBox
prabhjyotsingh commented on pull request #4045: URL: https://github.com/apache/zeppelin/pull/4045#issuecomment-773211578 @zjffdu can you help review this one. This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] prabhjyotsingh opened a new pull request #4045: ZEPPELIN-4952: Markdown interpreter can be used to store XSS in notebooks

2021-02-04 Thread GitBox
prabhjyotsingh opened a new pull request #4045: URL: https://github.com/apache/zeppelin/pull/4045 ### What is this PR for? Markdown interpreter can be used to store XSS in notebooks The %md interpreter can be used to store XSS in notebooks. These cells are automatically loaded by the

[GitHub] [zeppelin] prabhjyotsingh commented on pull request #4041: ZEPPELIN-5231: Livy Interpreter doesn't support Japanese Character - Encoding Issue

2021-02-04 Thread GitBox
prabhjyotsingh commented on pull request #4041: URL: https://github.com/apache/zeppelin/pull/4041#issuecomment-773149708 @zjffdu sure that makes sense, have just added the same. This is an automated message from the Apache