[GitHub] [zeppelin] rickchengx commented on pull request #4174: [ZEPPELIN-5442] Allow users to set a separate namespace for the interpreter

2021-08-09 Thread GitBox
rickchengx commented on pull request #4174: URL: https://github.com/apache/zeppelin/pull/4174#issuecomment-895749927 Hi, @Reamer Thanks for the comments. I have moved the common functions (`isRunningOnKubernetes()`, `readFile()`, `getInterpreterNamespace()` and

[GitHub] [zeppelin] zjffdu commented on pull request #4197: [ZEPPELIN-5478] Update flink version

2021-08-09 Thread GitBox
zjffdu commented on pull request #4197: URL: https://github.com/apache/zeppelin/pull/4197#issuecomment-895688893 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] zjffdu commented on pull request #4199: [ZEPPELIN-5481] Support to run R interpreter in yarn mode with customized conda env

2021-08-09 Thread GitBox
zjffdu commented on pull request #4199: URL: https://github.com/apache/zeppelin/pull/4199#issuecomment-895688812 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] zjffdu commented on pull request #4198: [ZEPPELIN-5479] %python.sql doesn't work with ipython interpreter

2021-08-09 Thread GitBox
zjffdu commented on pull request #4198: URL: https://github.com/apache/zeppelin/pull/4198#issuecomment-895688714 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] rickchengx commented on a change in pull request #4174: [ZEPPELIN-5442] Allow users to set a separate namespace for the interpreter

2021-08-09 Thread GitBox
rickchengx commented on a change in pull request #4174: URL: https://github.com/apache/zeppelin/pull/4174#discussion_r685626738 ## File path: k8s/zeppelin-server.yaml ## @@ -213,14 +213,15 @@ rules: resources: ["roles", "rolebindings"] verbs: ["bind", "create", "get",

[GitHub] [zeppelin] zjffdu edited a comment on pull request #4200: ZEPPELIN-1554: Upgrade jekyll

2021-08-09 Thread GitBox
zjffdu edited a comment on pull request #4200: URL: https://github.com/apache/zeppelin/pull/4200#issuecomment-895279241 @epugh Sorry, I forgot to mention that you can check the [README.md](https://github.com/apache/zeppelin/tree/master/docs) for how to generate docs. Building docs via

[GitHub] [zeppelin] zjffdu commented on pull request #4200: ZEPPELIN-1554: Upgrade jekyll

2021-08-09 Thread GitBox
zjffdu commented on pull request #4200: URL: https://github.com/apache/zeppelin/pull/4200#issuecomment-895279241 @epugh Sorry to mention that you can check the [README.md](https://github.com/apache/zeppelin/tree/master/docs) for how to generate docs. Building docs via docker would be

[GitHub] [zeppelin] epugh opened a new pull request #4200: ZEPPELIN-1554: Upgrade jekyll

2021-08-09 Thread GitBox
epugh opened a new pull request #4200: URL: https://github.com/apache/zeppelin/pull/4200 ### What is this PR for? I wanted to generate the `docs` site on my Mac, and found a bunch of old dependencies that needed updating. I don't know if this is related to ZEPPELIN-1554, which

[GitHub] [zeppelin] Reamer commented on a change in pull request #4199: [ZEPPELIN-5481] Support to run R interpreter in yarn mode with customized conda env

2021-08-09 Thread GitBox
Reamer commented on a change in pull request #4199: URL: https://github.com/apache/zeppelin/pull/4199#discussion_r685169039 ## File path: rlang/src/main/java/org/apache/zeppelin/r/IRInterpreter.java ## @@ -152,6 +153,17 @@ protected void initIRKernel() throws IOException,

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4199: [ZEPPELIN-5481] Support to run R interpreter in yarn mode with customized conda env

2021-08-09 Thread GitBox
zjffdu commented on a change in pull request #4199: URL: https://github.com/apache/zeppelin/pull/4199#discussion_r685154342 ## File path: rlang/src/main/java/org/apache/zeppelin/r/IRInterpreter.java ## @@ -152,6 +153,17 @@ protected void initIRKernel() throws IOException,

[GitHub] [zeppelin] Reamer commented on a change in pull request #4186: [ZEPPELIN-5468]Fast return when invalid ticket of no session case

2021-08-09 Thread GitBox
Reamer commented on a change in pull request #4186: URL: https://github.com/apache/zeppelin/pull/4186#discussion_r685128717 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java ## @@ -263,19 +263,17 @@ public void onMessage(NotebookSocket

[GitHub] [zeppelin] asfgit closed pull request #4183: [ZEPPELIN-5464] Zeppelin server needs to obtain the permission to create configmaps under k8s mode

2021-08-09 Thread GitBox
asfgit closed pull request #4183: URL: https://github.com/apache/zeppelin/pull/4183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on a change in pull request #4174: [ZEPPELIN-5442] Allow users to set a separate namespace for the interpreter

2021-08-09 Thread GitBox
Reamer commented on a change in pull request #4174: URL: https://github.com/apache/zeppelin/pull/4174#discussion_r685015571 ## File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sStandardInterpreterLauncher.java ## @@

[GitHub] [zeppelin] Reamer closed pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

2021-08-09 Thread GitBox
Reamer closed pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

2021-08-09 Thread GitBox
Reamer commented on pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-895027038 Closed in favor of #4173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer commented on a change in pull request #4199: [ZEPPELIN-5481] Support to run R interpreter in yarn mode with customized conda env

2021-08-09 Thread GitBox
Reamer commented on a change in pull request #4199: URL: https://github.com/apache/zeppelin/pull/4199#discussion_r684964985 ## File path: rlang/src/main/java/org/apache/zeppelin/r/IRInterpreter.java ## @@ -152,6 +153,17 @@ protected void initIRKernel() throws IOException,