[GitHub] [zeppelin] zjffdu commented on pull request #4208: [ZEPPELIN-5497] Memory leak of GenericObjectPool

2021-08-25 Thread GitBox
zjffdu commented on pull request #4208: URL: https://github.com/apache/zeppelin/pull/4208#issuecomment-906021293 @Reamer I am afraid we can not use `try-with-resource` here, because `PooledRemoteClient` will be used in the whole lifecycle of `RemoteInterpreterProcess` (used in multiple

[GitHub] [zeppelin] rickchengx commented on pull request #4174: [ZEPPELIN-5442] Allow users to set a separate namespace for the interpreter

2021-08-25 Thread GitBox
rickchengx commented on pull request #4174: URL: https://github.com/apache/zeppelin/pull/4174#issuecomment-906001473 > > Now by default, user can create the interpreter pod in the `default` namespace. > > Is it necessary to add a namespace? Now the `zeppelin-server.yaml` has

[GitHub] [zeppelin] rickchengx commented on a change in pull request #4174: [ZEPPELIN-5442] Allow users to set a separate namespace for the interpreter

2021-08-25 Thread GitBox
rickchengx commented on a change in pull request #4174: URL: https://github.com/apache/zeppelin/pull/4174#discussion_r696215340 ## File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java ## @@

[GitHub] [zeppelin] Reamer commented on a change in pull request #4207: [ZEPPELIN-5494] Make shell interpreter concurrency configurable

2021-08-25 Thread GitBox
Reamer commented on a change in pull request #4207: URL: https://github.com/apache/zeppelin/pull/4207#discussion_r695852869 ## File path: shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java ## @@ -213,7 +214,17 @@ public int getProgress(InterpreterContext

[GitHub] [zeppelin] Reamer commented on pull request #4208: [ZEPPELIN-5497] Memory leak of GenericObjectPool

2021-08-25 Thread GitBox
Reamer commented on pull request #4208: URL: https://github.com/apache/zeppelin/pull/4208#issuecomment-905393394 We should implement the [`AutoCloseable` interface](https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html) in this class. Maybe we can use the

[GitHub] [zeppelin] zjffdu opened a new pull request #4208: [ZEPPELIN-5497] Memory leak of GenericObjectPool

2021-08-25 Thread GitBox
zjffdu opened a new pull request #4208: URL: https://github.com/apache/zeppelin/pull/4208 ### What is this PR for? Should close `clientPool` explicitly, otherwise it won't be garbage collected. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task

[jira] [Created] (ZEPPELIN-5498) Add jetbrains-pty4j repository to spark-submit module

2021-08-25 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5498: Summary: Add jetbrains-pty4j repository to spark-submit module Key: ZEPPELIN-5498 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5498 Project: Zeppelin

[jira] [Created] (ZEPPELIN-5497) Memory leak of GenericObjectPool

2021-08-25 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5497: Summary: Memory leak of GenericObjectPool Key: ZEPPELIN-5497 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5497 Project: Zeppelin Issue Type: Bug