[GitHub] [zeppelin] jongyoul commented on a change in pull request #4223: [WIP] [ZEPPELIN-5518] Adopt JSR356 for Websocket

2021-09-16 Thread GitBox
jongyoul commented on a change in pull request #4223: URL: https://github.com/apache/zeppelin/pull/4223#discussion_r710229365 ## File path: pom.xml ## @@ -589,6 +590,12 @@ + Review comment: I'm fixing not to set dependency management block on

[jira] [Created] (ZEPPELIN-5526) interpreter setting still in error status when remove the invalid dependency

2021-09-16 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5526: Summary: interpreter setting still in error status when remove the invalid dependency Key: ZEPPELIN-5526 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5526

[GitHub] [zeppelin] jongyoul commented on a change in pull request #4223: [WIP] [ZEPPELIN-5518] Adopt JSR356 for Websocket

2021-09-16 Thread GitBox
jongyoul commented on a change in pull request #4223: URL: https://github.com/apache/zeppelin/pull/4223#discussion_r710161557 ## File path: pom.xml ## @@ -589,6 +590,12 @@ + Review comment: Basically, I agree with you but it's related to

[GitHub] [zeppelin] jongyoul commented on a change in pull request #4223: [WIP] [ZEPPELIN-5518] Adopt JSR356 for Websocket

2021-09-16 Thread GitBox
jongyoul commented on a change in pull request #4223: URL: https://github.com/apache/zeppelin/pull/4223#discussion_r710161557 ## File path: pom.xml ## @@ -589,6 +590,12 @@ + Review comment: Basically, I agree with you but it's related to

[GitHub] [zeppelin] Reamer commented on a change in pull request #4223: [WIP] [ZEPPELIN-5518] Adopt JSR356 for Websocket

2021-09-16 Thread GitBox
Reamer commented on a change in pull request #4223: URL: https://github.com/apache/zeppelin/pull/4223#discussion_r710154902 ## File path: pom.xml ## @@ -589,6 +590,12 @@ + Review comment: I would place this dependency management in the

[GitHub] [zeppelin] Reamer commented on pull request #4224: [ZEPPELIN-5522] Remove unnecessary maven-dependency-plugin maven plugin calls

2021-09-16 Thread GitBox
Reamer commented on pull request #4224: URL: https://github.com/apache/zeppelin/pull/4224#issuecomment-920933348 We create an uber-jar/fat-jar for each interpreter via the `maven-shade-plugin`. Therefore, these libraries are no longer necessary. As you can see in

[GitHub] [zeppelin] jongyoul commented on pull request #4224: [ZEPPELIN-5522] Remove unnecessary maven-dependency-plugin maven plugin calls

2021-09-16 Thread GitBox
jongyoul commented on pull request #4224: URL: https://github.com/apache/zeppelin/pull/4224#issuecomment-920906994 AFAIK, `maven-dependency-plugin` copies all dependencies to interpreter/lib directory. Isn't it needed anymore? Otherwise, please let me know if I miss something. -- This

[jira] [Created] (ZEPPELIN-5525) Python vanillar interpreter doesn't' work in Python 3.8

2021-09-16 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5525: Summary: Python vanillar interpreter doesn't' work in Python 3.8 Key: ZEPPELIN-5525 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5525 Project: Zeppelin