[GitHub] [zeppelin] zjffdu edited a comment on pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu edited a comment on pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#issuecomment-938678025 > LGTM, but keep in mind that I don't use Flink at all. It's not easy to add integration test for this, so I just tested it manually. -- This is an automated me

[GitHub] [zeppelin] zjffdu commented on pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#issuecomment-938678025 > LGTM, but keep in mind that I don't use Flink at all. Although we don't have integration test, I have tested it manually. -- This is an automated message from the Apa

[GitHub] [zeppelin] Reamer removed a comment on pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
Reamer removed a comment on pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#issuecomment-938645752 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [zeppelin] Reamer commented on pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
Reamer commented on pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#issuecomment-938645752 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724986978 ## File path: zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java ## @@ -59,14 +62,29 @@

[jira] [Created] (ZEPPELIN-5553) Remove older version flink support

2021-10-08 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5553: Summary: Remove older version flink support Key: ZEPPELIN-5553 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5553 Project: Zeppelin Issue Type: Improve

[jira] [Created] (ZEPPELIN-5552) zeppelin-0.9.0删除paragraph报错

2021-10-08 Thread niofei (Jira)
niofei created ZEPPELIN-5552: Summary: zeppelin-0.9.0删除paragraph报错 Key: ZEPPELIN-5552 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5552 Project: Zeppelin Issue Type: Bug Report

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724929124 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -321,7 +326,10 @@ public stati

[GitHub] [zeppelin] Reamer commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
Reamer commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724923739 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -321,7 +326,10 @@ public stati

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724909451 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -321,7 +326,10 @@ public stati

[GitHub] [zeppelin] Reamer commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
Reamer commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724873588 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -142,6 +141,7 @@ private Sc

[GitHub] [zeppelin] Reamer commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
Reamer commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724873411 ## File path: zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java ## @@ -59,14 +62,29 @@

[GitHub] [zeppelin] Reamer commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
Reamer commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724869639 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -701,8 +712,10 @@ public void

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724837493 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -142,6 +141,7 @@ private Sc

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724837493 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -142,6 +141,7 @@ private Sc

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4116: [ZEPPELIN-5352] Support flink in k8s mode

2021-10-08 Thread GitBox
zjffdu commented on a change in pull request #4116: URL: https://github.com/apache/zeppelin/pull/4116#discussion_r724837493 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java ## @@ -142,6 +141,7 @@ private Sc

[jira] [Created] (ZEPPELIN-5551) Zeppelin does not support JDBC interpreter for trino v358 and above

2021-10-08 Thread Jaeho Yoo (Jira)
Jaeho Yoo created ZEPPELIN-5551: --- Summary: Zeppelin does not support JDBC interpreter for trino v358 and above Key: ZEPPELIN-5551 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5551 Project: Zeppel