huage1994 commented on code in PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#discussion_r1122608228
########## zeppelin-plugins/notebookrepo/s3/pom.xml: ########## @@ -109,15 +131,11 @@ <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> </exclusion> - <exclusion> + <exclusion> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-core</artifactId> </exclusion> - <exclusion> - <groupId>com.fasterxml.jackson.dataformat</groupId> - <artifactId>jackson-dataformat-xml</artifactId> - </exclusion> - <exclusion> + <exclusion> Review Comment: Everything is good except the indentation is misaligned in three places ########## zeppelin-plugins/notebookrepo/s3/pom.xml: ########## @@ -129,14 +147,22 @@ <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-databind</artifactId> </exclusion> - <exclusion> + <exclusion> Review Comment: ```suggestion <exclusion> ``` ########## zeppelin-plugins/notebookrepo/s3/pom.xml: ########## @@ -109,15 +131,11 @@ <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> </exclusion> - <exclusion> + <exclusion> Review Comment: ```suggestion <exclusion> ``` ########## zeppelin-plugins/notebookrepo/s3/pom.xml: ########## @@ -109,15 +131,11 @@ <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> </exclusion> - <exclusion> + <exclusion> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-core</artifactId> </exclusion> - <exclusion> - <groupId>com.fasterxml.jackson.dataformat</groupId> - <artifactId>jackson-dataformat-xml</artifactId> - </exclusion> - <exclusion> + <exclusion> Review Comment: ```suggestion <exclusion> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org