xiaomin0322 commented on PR #4579:
URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1522705230
> Could you please improve your description of the pull request. Have a look
at #4568 for a good example.
Adjusted
--
This is an automated message from the Apache Git
Reamer opened a new pull request, #4590:
URL: https://github.com/apache/zeppelin/pull/4590
### What is this PR for?
This pull request adds a cache cleanup method that attempts to remove an
item from the cache that is not the eldest item and also does not have a read
flag.
###
Philipp Dallig created ZEPPELIN-5903:
Summary: NoteCache still growing
Key: ZEPPELIN-5903
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5903
Project: Zeppelin
Issue Type: Bug
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176399171
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:
##
@@ -342,17 +341,14 @@ public Scheduler getScheduler() {
//
zjffdu commented on PR #4589:
URL: https://github.com/apache/zeppelin/pull/4589#issuecomment-1521652049
Thanks for the contribution @zhugezifang , could you update the PR
description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
huage1994 commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:
##
@@ -342,17 +341,14 @@ public Scheduler getScheduler() {
//
huage1994 commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:
##
@@ -342,17 +341,14 @@ public Scheduler getScheduler() {
//
Reamer commented on PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#issuecomment-1521465572
ping @akishichinibu Any JUnit tests to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Reamer commented on PR #4579:
URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1521464643
Could you please improve your description of the pull request.
Have a look at #4568 for a good example.
--
This is an automated message from the Apache Git Service.
To respond to the
xiaomin0322 commented on PR #4579:
URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1521444700
> @xiaomin0322 Could you update the jira title to be more specific? `Dev
zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when
getting progress from
Reamer commented on code in PR #4589:
URL: https://github.com/apache/zeppelin/pull/4589#discussion_r1176204154
##
zeppelin-web/src/app/notebook/paragraph/result/result.controller.js:
##
@@ -895,6 +895,9 @@ function ResultCtrl($scope, $rootScope, $route, $window,
$routeParams,
Reamer commented on code in PR #4586:
URL: https://github.com/apache/zeppelin/pull/4586#discussion_r1176200080
##
spark/interpreter/pom.xml:
##
@@ -518,6 +518,20 @@
+
+ spark-3.4
+
+true
Review Comment:
Only one Spark Profile should have
Reamer commented on PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1521223455
> BTW it's weird that the `RemoteSchedulerTest` used to runs fine on Junit
4, Do you know why?
Unfortunately no.
However, since only the timing matters due to the six threads
Reamer commented on PR #4581:
URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1521210881
> when does it get merged ?
When all tests have been successfully completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
14 matches
Mail list logo
