[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-26 Thread via GitHub
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1523879863 Fixed the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zhugezifang commented on a diff in pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang commented on code in PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#discussion_r1177928181 ## zeppelin-web/src/app/notebook/paragraph/result/result.controller.js: ## @@ -895,6 +895,9 @@ function ResultCtrl($scope, $rootScope, $route, $window,

[GitHub] [zeppelin] zhugezifang commented on pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang commented on PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#issuecomment-1523472252 > Thanks for the contribution @zhugezifang , could you update the PR description? ok thanks, i updated it -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] zhugezifang closed pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang closed pull request #4589: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-26 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1523168683 > LGTM Would be merged if no more comment. 华哥合吧,嘿嘿 !@huage1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] huage1994 merged pull request #4572: [MINOR] Update doc for flink 1.16

2023-04-26 Thread via GitHub
huage1994 merged PR #4572: URL: https://github.com/apache/zeppelin/pull/4572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] huage1994 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-26 Thread via GitHub
huage1994 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1523131644 LGTM Would be merged if no more comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-26 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1523121562 This PR would be ready for review after #4582 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-26 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1177624768 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //