[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1584017096 > > and the data cache is really for hive like this large data database (not for mysql), as we know , hive sql will tranlate to mapreduce job, complex hive sql have shuffle and reduc

[jira] [Created] (ZEPPELIN-5927) Solve the concurrency calls to `saveNoteAuth`

2023-06-08 Thread yousj (Jira)
yousj created ZEPPELIN-5927: --- Summary: Solve the concurrency calls to `saveNoteAuth` Key: ZEPPELIN-5927 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5927 Project: Zeppelin Issue Type: Bug

[GitHub] [zeppelin] jongyoul commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
jongyoul commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582577943 > and the data cache is really for hive like this large data database (not for mysql), as we know , hive sql will tranlate to mapreduce job, complex hive sql have shuffle and reducer ,i

[GitHub] [zeppelin] jongyoul commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
jongyoul commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582561003 Sorry for the late and short comment but how about making debug paragraph as a new interpreter? I mean, for instance, `%jdbc.debug`. Debugging jdbc paragraph itself is reasonable but I'

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582337500 Thanks for your reply. I understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582193016 I don't think so, because this function is used by all save operations. e.g. when note files are created. These would then block each other. -- This is an automated message from the Apa

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582091105 > A few thoughts about your work: > > * All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. > * It seems tha

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582067198 > A few thoughts about your work: > > * All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. > * It seems tha

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582065412 @Reamer hi,firstly thanks for your advice "All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there" it contains

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582052448 Mybe a synchronized at the `org.apache.zeppelin.util.FileUtils#atomicWriteToFile(java.lang.String, java.io.File, java.util.Set)` is a better option. -- This is an automated mess

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582001696 Feel free to prepare a PullRequest with JIRA ticket. Your StackTrace should be included in the JIRA ticket. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [zeppelin] Reamer commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
Reamer commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-158298 A few thoughts about your work: - All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. - It seems that in case of a

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581997675 Yes, i also think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment