[GitHub] [zeppelin] Reamer commented on a diff in pull request #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

2023-05-05 Thread via GitHub
Reamer commented on code in PR #4595: URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1185898124 ## zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java: ## @@ -20,21 +20,22 @@ import

[GitHub] [zeppelin] huage1994 commented on pull request #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

2023-05-05 Thread via GitHub
huage1994 commented on PR #4595: URL: https://github.com/apache/zeppelin/pull/4595#issuecomment-1535934652 LGTM except for some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

2023-05-05 Thread via GitHub
huage1994 commented on code in PR #4595: URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1185841009 ## zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java: ## @@ -20,21 +20,22 @@ import

[GitHub] [zeppelin] Reamer opened a new pull request, #4595: [ZEPPELIN-5907][JUnit 5 Migration] Module zeppelin-interpreter

2023-05-05 Thread via GitHub
Reamer opened a new pull request, #4595: URL: https://github.com/apache/zeppelin/pull/4595 ### What is this PR for? This PR is to migrate the tests in zeppelin-interpreter module from JUnit 4 to JUnit 5, which is a part of [JUnit 5 Migration

[jira] [Created] (ZEPPELIN-5907) [JUnit 5 Migration] Module: zeppelin-interpreter

2023-05-05 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5907: Summary: [JUnit 5 Migration] Module: zeppelin-interpreter Key: ZEPPELIN-5907 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5907 Project: Zeppelin

[GitHub] [zeppelin] Reamer commented on pull request #4592: [ZEPPELIN-5905] Use wildcard generic for job and remove generic for JobListener

2023-05-05 Thread via GitHub
Reamer commented on PR #4592: URL: https://github.com/apache/zeppelin/pull/4592#issuecomment-1535779121 Additional Review needed after I have rebased the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (ZEPPELIN-5906) SQL interpreter not able to run UDAF with Aggregator API

2023-05-04 Thread Shreyas (Jira)
Shreyas created ZEPPELIN-5906: - Summary: SQL interpreter not able to run UDAF with Aggregator API Key: ZEPPELIN-5906 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5906 Project: Zeppelin

[GitHub] [zeppelin] zhugezifang opened a new pull request, #4594: [ZEPPELIN-5896]feat:add sql debug feat

2023-05-04 Thread via GitHub
zhugezifang opened a new pull request, #4594: URL: https://github.com/apache/zeppelin/pull/4594 ### What is this PR for? This pull request add sql debug feat into zeppelin ### What type of PR is it? Feature ### Todos * [ ] - Task ### What is the Jira issue?

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-05-04 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1534337348 > @huage1994 Please rebase your current branch. I merged #4582 right now. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] huage1994 merged pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-05-03 Thread via GitHub
huage1994 merged PR #4579: URL: https://github.com/apache/zeppelin/pull/4579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-05-02 Thread via GitHub
Reamer commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1530969486 @huage1994 Please rebase your current branch. I merged #4582 right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] Reamer merged pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-05-02 Thread via GitHub
Reamer merged PR #4593: URL: https://github.com/apache/zeppelin/pull/4593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer merged pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-05-02 Thread via GitHub
Reamer merged PR #4590: URL: https://github.com/apache/zeppelin/pull/4590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer merged pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-05-02 Thread via GitHub
Reamer merged PR #4582: URL: https://github.com/apache/zeppelin/pull/4582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-29 Thread via GitHub
jongyoul commented on PR #4593: URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1528737189 Thank you for the contribution, especially in frontend part :-) We are looking forward to your continuous contributions. -- This is an automated message from the Apache Git Service.

[GitHub] [zeppelin] Reamer commented on pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-28 Thread via GitHub
Reamer commented on PR #4593: URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1527517415 Thank you for your participation. I am looking forward to your PullRequest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] zhugezifang commented on pull request #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4593: URL: https://github.com/apache/zeppelin/pull/4593#issuecomment-1527513402 > LGTM thanks, and i also want to add the feature of sql-debug to zeppelin ,it is a brief description in https://issues.apache.org/jira/browse/ZEPPELIN-5896 --

[GitHub] [zeppelin] zhugezifang opened a new pull request, #4593: [ZEPPELIN-5898]fix:download csv data error

2023-04-28 Thread via GitHub
zhugezifang opened a new pull request, #4593: URL: https://github.com/apache/zeppelin/pull/4593 ### What is this PR for? This pull request fix the bug of download csv data error ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is

[GitHub] [zeppelin] zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527297261 > > @Reamer hi,i also want to add this feature into zeppelin,and could I get your support? > > Of course. I was able to reproduce the problem and understood the problem. Your

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527196813 > @Reamer hi,i also want to add this feature into zeppelin,and could I get your support? Of course. I was able to reproduce the problem and understood the problem. Your change

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
Reamer commented on code in PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180032048 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java: ## @@ -162,6 +162,14 @@ public void testLruCache() throws IOException {

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527116417 > > I do not understand the fix. Could you please explain it. > > excuce me,there is a webchat group or other group of zeppelin,we can discuss it more timely。 > > and i

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527114539 > I don't think it's a specific JSON problem, but rather a delimiter problem. The CSV is broken because in the JSON example there is a `,` in the text field and this is also used as

[GitHub] [zeppelin] huage1994 commented on pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
huage1994 commented on PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#issuecomment-1527113642 The changes look very good. I just have a minor code suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] Reamer commented on pull request #4592: [ZEPPELIN-5905] Use wildcard generic for job and remove generic for JobListener

2023-04-28 Thread via GitHub
Reamer commented on PR #4592: URL: https://github.com/apache/zeppelin/pull/4592#issuecomment-1527107097 This PR is dependent on #4582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer opened a new pull request, #4592: [ZEPPELIN-5905] Use wildcard generic for job and remove generic for JobListener

2023-04-28 Thread via GitHub
Reamer opened a new pull request, #4592: URL: https://github.com/apache/zeppelin/pull/4592 ### What is this PR for? This PR uses generics for the job class. I have not managed to use the generics for the JobListener class everywhere, so for simplicity I have removed the generic. The

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
huage1994 commented on code in PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180017995 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java: ## @@ -162,6 +162,14 @@ public void testLruCache() throws IOException {

[jira] [Created] (ZEPPELIN-5905) Polish generics for Job and JobListener

2023-04-28 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5905: Summary: Polish generics for Job and JobListener Key: ZEPPELIN-5905 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5905 Project: Zeppelin Issue

[GitHub] [zeppelin] Reamer commented on pull request #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-28 Thread via GitHub
Reamer commented on PR #4590: URL: https://github.com/apache/zeppelin/pull/4590#issuecomment-1527052137 Need a review. I have tested this function in my environment and it does what it is supposed to. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-28 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1527049901 I don't think it's a specific JSON problem, but rather a delimiter problem. The CSV is broken because in the JSON example there is a `,` in the text field and this is also used as a

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1526884790 > I do not understand the fix. Could you please explain it. excuce me,the is a webchat group or other group of zeppelin,we can discuss it more timely。 and i want to add

[GitHub] [zeppelin] zhugezifang opened a new pull request, #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang opened a new pull request, #4591: URL: https://github.com/apache/zeppelin/pull/4591 ### What is this PR for? This pull request fix the bug of download csv data error ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is

[GitHub] [zeppelin] zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang closed pull request #4591: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1526879184 > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1526872815 > I do not understand the fix. Could you please explain it. let we look the example of https://issues.apache.org/jira/browse/ZEPPELIN-5898 when i query the result in

[GitHub] [zeppelin] Reamer commented on pull request #4562: [ZEPPELIN-5880] Credentials roles

2023-04-27 Thread via GitHub
Reamer commented on PR #4562: URL: https://github.com/apache/zeppelin/pull/4562#issuecomment-1525944565 Added some Screenshots :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-27 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1525923732 If no further comments are received till Tuesday 02.05, I will merge this PullRequest. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] realknorke commented on pull request #4586: [ZEPPELIN-5902] Support Spark 3.4

2023-04-27 Thread via GitHub
realknorke commented on PR #4586: URL: https://github.com/apache/zeppelin/pull/4586#issuecomment-1525682236 Thanks for the pull request. Its possible to connect to a 3.4.0 Spark cluster. BUT Spark Connect is not working. ``` %spark-connect spark.read.option("basePath",

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1525674173 I do not understand the fix. Could you please explain it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (ZEPPELIN-5904) unable to read environment variable in shiro.ini

2023-04-27 Thread Pramod Khillari (Jira)
Pramod Khillari created ZEPPELIN-5904: - Summary: unable to read environment variable in shiro.ini Key: ZEPPELIN-5904 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5904 Project: Zeppelin

[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1525302501 > Still > > > Thanks for the contribution @zhugezifang , could you update the PR description? ok,updated it -- This is an automated message from the Apache Git

[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error

2023-04-27 Thread via GitHub
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1524855876 Still > Thanks for the contribution @zhugezifang , could you update the PR description? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-27 Thread via GitHub
Reamer commented on code in PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178683279 ## zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java: ## @@ -123,7 +123,7 @@ void

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-27 Thread via GitHub
Reamer commented on code in PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178681796 ## zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java: ## @@ -123,7 +123,7 @@ void

[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-26 Thread via GitHub
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1523879863 Fixed the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zhugezifang commented on a diff in pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang commented on code in PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#discussion_r1177928181 ## zeppelin-web/src/app/notebook/paragraph/result/result.controller.js: ## @@ -895,6 +895,9 @@ function ResultCtrl($scope, $rootScope, $route, $window,

[GitHub] [zeppelin] zhugezifang commented on pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang commented on PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#issuecomment-1523472252 > Thanks for the contribution @zhugezifang , could you update the PR description? ok thanks, i updated it -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] zhugezifang closed pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-26 Thread via GitHub
zhugezifang closed pull request #4589: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-26 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1523168683 > LGTM Would be merged if no more comment. 华哥合吧,嘿嘿 !@huage1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] huage1994 merged pull request #4572: [MINOR] Update doc for flink 1.16

2023-04-26 Thread via GitHub
huage1994 merged PR #4572: URL: https://github.com/apache/zeppelin/pull/4572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] huage1994 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-26 Thread via GitHub
huage1994 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1523131644 LGTM Would be merged if no more comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-26 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1523121562 This PR would be ready for review after #4582 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-26 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1177624768 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-25 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1522705230 > Could you please improve your description of the pull request. Have a look at #4568 for a good example. Adjusted -- This is an automated message from the Apache Git

[GitHub] [zeppelin] Reamer opened a new pull request, #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup

2023-04-25 Thread via GitHub
Reamer opened a new pull request, #4590: URL: https://github.com/apache/zeppelin/pull/4590 ### What is this PR for? This pull request adds a cache cleanup method that attempts to remove an item from the cache that is not the eldest item and also does not have a read flag. ###

[jira] [Created] (ZEPPELIN-5903) NoteCache still growing

2023-04-25 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5903: Summary: NoteCache still growing Key: ZEPPELIN-5903 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5903 Project: Zeppelin Issue Type: Bug

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176399171 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] zjffdu commented on pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-25 Thread via GitHub
zjffdu commented on PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#issuecomment-1521652049 Thanks for the contribution @zhugezifang , could you update the PR description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
huage1994 commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] Reamer commented on pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0

2023-04-25 Thread via GitHub
Reamer commented on PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#issuecomment-1521465572 ping @akishichinibu Any JUnit tests to add? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] Reamer commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-25 Thread via GitHub
Reamer commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1521464643 Could you please improve your description of the pull request. Have a look at #4568 for a good example. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] xiaomin0322 commented on pull request #4579: [ZEPPELIN-5893] NPE in ParagraphResult when getting progress from paragraphJson

2023-04-25 Thread via GitHub
xiaomin0322 commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1521444700 > @xiaomin0322 Could you update the jira title to be more specific? `Dev zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when getting progress from

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4589: [ZEPPELIN-5898]fix:down csv data error

2023-04-25 Thread via GitHub
Reamer commented on code in PR #4589: URL: https://github.com/apache/zeppelin/pull/4589#discussion_r1176204154 ## zeppelin-web/src/app/notebook/paragraph/result/result.controller.js: ## @@ -895,6 +895,9 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams,

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4586: [ZEPPELIN-5902] Support Spark 3.4

2023-04-25 Thread via GitHub
Reamer commented on code in PR #4586: URL: https://github.com/apache/zeppelin/pull/4586#discussion_r1176200080 ## spark/interpreter/pom.xml: ## @@ -518,6 +518,20 @@ + + spark-3.4 + +true Review Comment: Only one Spark Profile should have

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-25 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1521223455 > BTW it's weird that the `RemoteSchedulerTest` used to runs fine on Junit 4, Do you know why? Unfortunately no. However, since only the timing matters due to the six threads

[GitHub] [zeppelin] Reamer commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-25 Thread via GitHub
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1521210881 > when does it get merged ? When all tests have been successfully completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] zhugezifang closed pull request #4588: [ZEPPELIN-5898]fix:down csv data error

2023-04-24 Thread via GitHub
zhugezifang closed pull request #4588: [ZEPPELIN-5898]fix:down csv data error URL: https://github.com/apache/zeppelin/pull/4588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: unsubscribing

2023-04-24 Thread Andrew Musselman
Peng, send a mail to unsubscribe as explained on https://zeppelin.apache.org/community.html If you click the "unsubscribe" link in the Dev list section it should format mail for you too. On Mon, Apr 24, 2023 at 4:08 PM peng wrote: > unsubscribing > >

unsubscribing

2023-04-24 Thread peng
unsubscribing

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4587: Bump xlsx from 0.14.5 to 0.18.5 in /zeppelin-web-angular

2023-04-24 Thread via GitHub
dependabot[bot] opened a new pull request, #4587: URL: https://github.com/apache/zeppelin/pull/4587 Bumps [xlsx](https://github.com/SheetJS/sheetjs) from 0.14.5 to 0.18.5. Changelog Sourced from https://github.com/SheetJS/sheetjs/blob/github/CHANGELOG.md;>xlsx's changelog.

[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-04-24 Thread via GitHub
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1520648767 when does it get merged ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] huage1994 commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-23 Thread via GitHub
huage1994 commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1518980665 Thanks @Reamer so much for fixing the failed test case ! It's a great job. It's weird that the `RemoteSchedulerTest` runs well under Junit 4, Do you know why? -- This is

[GitHub] [zeppelin] zjffdu commented on pull request #4579: [ZEPPELIN-5893] Dev zeppelin client bug

2023-04-21 Thread via GitHub
zjffdu commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1518472971 @xiaomin0322 Could you update the jira title to be more specific? `Dev zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when getting progress from

[jira] [Created] (ZEPPELIN-5902) Support Spark 3.4

2023-04-21 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5902: Summary: Support Spark 3.4 Key: ZEPPELIN-5902 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5902 Project: Zeppelin Issue Type: Improvement

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4585: Bump spark-core_2.12 from 3.1.2 to 3.4.0 in /spark/interpreter

2023-04-21 Thread via GitHub
dependabot[bot] opened a new pull request, #4585: URL: https://github.com/apache/zeppelin/pull/4585 Bumps spark-core_2.12 from 3.1.2 to 3.4.0. [![Dependabot compatibility

[jira] [Created] (ZEPPELIN-5901) Pod launch fails when user name has special char.

2023-04-21 Thread Jeet (Jira)
Jeet created ZEPPELIN-5901: -- Summary: Pod launch fails when user name has special char. Key: ZEPPELIN-5901 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5901 Project: Zeppelin Issue Type: Bug

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173980444 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,11 +89,14 @@ public void run() { runningJob =

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173974707 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -82,10 +88,11 @@ public void runJobInScheduler(Job job) { * RUNNING

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173972774 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -53,22 +55,26 @@ public void runJobInScheduler(Job job) {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173962995 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -34,14 +36,14 @@ public class RemoteScheduler extends AbstractScheduler {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173961893 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { //

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173959970 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java: ## @@ -70,6 +70,14 @@ public boolean isPending() { public boolean isCompleted() {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173957427 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -133,21 +134,14 @@ protected void runJob(Job runningJob) {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,6 +89,7 @@ public void run() { runningJob =

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,6 +89,7 @@ public void run() { runningJob =

[GitHub] [zeppelin] Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter

2023-04-21 Thread via GitHub
Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter URL: https://github.com/apache/zeppelin/pull/4584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1518056388 As this PR changes a very important component of Zeppelin, I need an accurate review. If you want me to describe the changes in more detail, please let me know. -- This is an

[GitHub] [zeppelin] Samrat002 opened a new pull request, #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter

2023-04-21 Thread via GitHub
Samrat002 opened a new pull request, #4584: URL: https://github.com/apache/zeppelin/pull/4584 ### What is this PR for? - It introduces new flink 1.17.0 interpreter support in zeppelin. - Flink-1.17 is

[GitHub] [zeppelin] Reamer opened a new pull request, #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer opened a new pull request, #4582: URL: https://github.com/apache/zeppelin/pull/4582 ### What is this PR for? This PR changes the RemoteScheduler The main change is the executor of the RemoteScheduler. It's now a separate FIFO Executor (one Thread). As a result, jobs are now

[jira] [Created] (ZEPPELIN-5900) Fix RemoteSchedulerTest.testAbortOnPending

2023-04-21 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5900: Summary: Fix RemoteSchedulerTest.testAbortOnPending Key: ZEPPELIN-5900 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5900 Project: Zeppelin

[GitHub] [zeppelin] Reamer commented on pull request #4581: Sanitize user labels for k8s

2023-04-21 Thread via GitHub
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1517384284 Hello @grizzly-monkey, thanks for your Pull Request. We already have a sanitize method. Have a look at `K8sUtils:generateK8sName`. Please use this method or adapt the method to your

[GitHub] [zeppelin] grizzly-monkey opened a new pull request, #4581: Sanitize user labels for k8s

2023-04-20 Thread via GitHub
grizzly-monkey opened a new pull request, #4581: URL: https://github.com/apache/zeppelin/pull/4581 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. K8S labels has specific requirement to name labels which can be found here

Zeppelin Spark Interpreter based on Spark Connect

2023-04-20 Thread Ankit Gupta
Hey Starting spark 3.4.0 they have introduced a decoupled client-server architecture for spark. How about we can start thinking of porting the zeppelin interpreter to use the same architecture for spark interpreter. References: https://spark.apache.org/docs/latest/spark-connect-overview.html

[jira] [Created] (ZEPPELIN-5899) zeppelin run error

2023-04-19 Thread duanxiaoqiu (Jira)
duanxiaoqiu created ZEPPELIN-5899: - Summary: zeppelin run error Key: ZEPPELIN-5899 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5899 Project: Zeppelin Issue Type: Bug

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-18 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1512627023 There still seems to be a problem. I'm working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-18 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1512535026 > Hi @huage1994, I have opened [huage1994#2](https://github.com/huage1994/zeppelin/pull/2). These changes should ensure that the tests go through. I have also removed

[jira] [Created] (ZEPPELIN-5898) down csv data error

2023-04-17 Thread duanxiaoqiu (Jira)
duanxiaoqiu created ZEPPELIN-5898: - Summary: down csv data error Key: ZEPPELIN-5898 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5898 Project: Zeppelin Issue Type: Bug

Re: [DISCUSS] Change mailing list scheme

2023-04-14 Thread Danny Cranmer
+1, in the Flink community we have split out builds/issues/commits into dedicated mailing lists [1]. Thanks, Danny [1] https://flink.apache.org/community/ On Thu, Apr 13, 2023 at 11:27 PM Jeff Zhang wrote: > +1, thanks for the proposal Jongyoul > > On Thu, Apr 13, 2023 at 8:12 PM Philipp

<    1   2   3   4   5   6   7   8   9   10   >