[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda It's wired. This is what I can see when I build my branch. ![record](https://cloud.githubusercontent.com/assets/10060731/24363529/1863c144-134b-11e7-85c7-ae5c6acc8dd

[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...

2017-03-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 @Leemoonsoo Thanks! Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu

2017-03-25 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2189 [branch-0.7] Minor styling for Helium menu ### What is this PR for? Since Helium online registry is available in develop version(0.8.0-SNAPSHOT) for now, people only can use their local

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-25 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee And as you can see in the above gif image that i took, the tooltip in scatter chart is shown like "(age, value)". But before #2042 it looks like below. ![im

[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 @Leemoonsoo Right it should be passed without refreshing. So I removed that part and added `waitForParagraph(1, "FINISHED");` before every selections for the stability. Now CI is

[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-24 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2174 [ZEPELIN-2209] Add pagination to Helium menu ### What is this PR for? Like I did in #2126, added pagination to Helium menu in Zeppelin. 10 pkgs will be shown per 1 page

[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee Thanks for the explanation. I tested this branch to make sure it works well or not, but when I select "Line chart" below error ms

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1976 @del680202 Also tested on both latest branch-0.7 and rc2 but couldn't reproduce. Here is my steps. 1. Activate shiro -> login 2. Run a paragraph with python intp(globall

[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2180 CI failure is not related with this change since it's based on `gh-pages` branch. Merge into `gh-pages` if there are no more comments. --- If your project is set up for it, yo

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1976 @del680202 Thanks for your time and effort to test it out. >But I seem when I edit&save interpreter config then the zombie process will be occurred I checked it with

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 @tinkoff-dwh Thanks! Looks good :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee Yeah I can see the error when we have large data. ![again](https://cloud.githubusercontent.com/assets/10060731/24282230/8307f99a-10a1-11e7-964e-d3b57be7943a.gif) I tested

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 > I can add the close button @tinkoff-dwh Yeah that's better. Having close button will be better for other cases as well. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @Remilito Will be appreciated if you can take a look this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee Thanks for digging it up! Seems https://github.com/novus/nvd3/pull/1934 fixed this issue and merged in Jan. Hopefully they have a plan to release another minor version soon

[GitHub] zeppelin issue #1872: [ZEPPELIN-1922] Exclude jackson-core and jackson-datab...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1872 @epahomov Could you close this PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1907: [MINOR] Add enough padding at the bottom of notebook

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1907 Hi @cuspymd, what do you think about @astroshim 's comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 Tested and basically agree with @Leemoonsoo. But one thing I just noticed is this new message can be seen in report mode. ![screen shot 2017-03-24 at 12 20 56 pm](https

[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2181 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2184: [MINOR][ZEPPELIN-2306] Improve alignment of components...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2184 Merge into master if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button group

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2185 @Leemoonsoo Thanks! Merge into master and branch-0.7 if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...

2017-03-23 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2185 [MINOR][ZEPPELIN-2308] Fix vis icon button group ### What is this PR for? Since "Save" button which shows up when there is change in the package bundle ordering is includ

[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...

2017-03-23 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2185 [MINOR][ZEPPELIN-2308] Fix vis icon button group ### What is this PR for? Since "Save" button which shows up when there is change in the package bundle ordering is included in s

[GitHub] zeppelin pull request #2184: [MINOR][ZEPPELIN-2306] Improve alignment of com...

2017-03-23 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2184 [MINOR][ZEPPELIN-2306] Improve alignment of components in Helium header ### What is this PR for? If there are 2 more enabled `VISUALIZATION` pkgs, the ordering control section will be

[GitHub] zeppelin issue #2178: [ZEPPELIN-2302] Add info level logs when installing no...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2178 Looks better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2181 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2180 @sravan-s Thanks for the suggestion. Addressed in 34dfec8a41a0e998fcc8c030860a6c796d11df86 :) https://cloud.githubusercontent.com/assets/10060731/24241202/5cdc7386-0ff7-11e7-91ed

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda I fixed it in the latest commit bc7643c46dc6690b5b1f1a91249bcf4ee0e93a43. You can simply check whether it was fixed or not by comparing `INTERPRETER` type of packages are well located

[GitHub] zeppelin pull request #2180: [gh-pages][ZEPPELIN-2303] Fix lately published ...

2017-03-23 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2180 [gh-pages][ZEPPELIN-2303] Fix lately published package ordering ### What is this PR for? I added pagination under Helium package list in https://zeppelin.apache.org/helium_packages.html

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Just noticed that `orderBy: publishedDate` doesn't work well properly now. Let me updated again and will let you know when it's resolved. (Actually same problem i

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1976 @del680202 >When I enable authentication with shiro or switch interpreter mode to Per user & isolated, Restart does not work and it is possible to make zombie process. Thi

[GitHub] zeppelin issue #2119: [ZEPPELIN-2243] Use uppercase for shortcut description

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2119 Thanks @1ambda Merge into master and branch-0.7 if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialog...

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2144 Merge into master if no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Looks awesome! Let me test it and i'll get back to you soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin pull request #1339: [ZEPPELIN-1332] Remove spark-dependencies & sug...

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/1339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1339 I'm closing this PR since there'll be better solution for this (e.g. [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993)) :) --- If your project is set up for i

[GitHub] zeppelin issue #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialog...

2017-03-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2144 Cool! Tested again and it works well as expected. LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-21 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Will be really appreciated if you can help review this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-21 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2174 [ZEPELIN-2209] Add pagination to Helium menu ### What is this PR for? Like I did in #2126, added pagination to Helium menu in Zeppelin. 10 pkgs will be shown per 1 page

[GitHub] zeppelin issue #2172: [hotfix][gh-pages] Put blog post's description back

2017-03-21 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2172 @Leemoonsoo Thanks! CI failure is irrelevant with `gh-pages` change. Merge into gh-pages if there are no more comments. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...

2017-03-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 All CI tests have passed now. Ready for review again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2161 I tested two scenarios that you described and both(turn on & off Shiro) are working well. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...

2017-03-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 I rebased but failed again in Selenium test. All test cases that I added passed in my local but it's failed in here. Seem I need to do something more to avoid this.. --- If your proje

[GitHub] zeppelin issue #2151: [ZEPPELIN-465] [On-hold] Be able to run paragraph and ...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2151 @Remilito Thanks for the useful feature. I think it'll be better to display only essential buttons in the paragraph. How about placing it under paragraph control dropdown menu inste

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro There are some unrelated commits in here after you rebased. Can you try to fix it? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2150 @andreaTP There are some conflict files after #2093 merged. Can you resolve them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2085 @tinkoff-dwh Saw your latest update. As you did, ``` ## Usage For example in database exist user `user1` with some password and exists user with same name into

[GitHub] zeppelin issue #2155: [HOTFIX] Dynamic form in python interpreter

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2155 Tested both with & without this patch. It works well now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select f...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Really appreciated your time & effort in the weekend. Sadly i have no idea what could be the reason for your problem with limited information. But i think we need only to focu

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro BTW you don't need to test #2156(base branch: `branch-0.7`) anymore since I updated this PR(base branch: `master`) as like #2156. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Not sure how your local git repo status is now, but if you think you can't make it back to normal status, I would recommend you to remove local Zeppelin dir and reclone it. Whe

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 After rebasing from master, I restarted 2nd build job several times but it keeps failed because of timeout. https://api.travis-ci.org/jobs/212613496/log.txt?deansi=true ``` The job

[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2156 @Leemoonsoo Thanks! CI has been passed after rebasing from `branch-0.7`. Will merge into `branch-0.7` as a hotfix if there are no more comments on this. --- If your project is set up for

[GitHub] zeppelin issue #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select form t...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2148 It was merged yesterday but seems wan't closed automatically by asfgit. So I'm closing this manually now. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin pull request #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 FYI, quick show for `edit on double click` with markdown interpreter ![edit on double click](https://cloud.githubusercontent.com/assets/10060731/24077344/853c25be-0c8d-11e7-9df1

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Just noticed that the behaviour that you mentioned was intended one. In Zeppelin, we support `editOnDoubleClick` \w Markdown interpreter. With this feature, you can hide/show the

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Seems sth screwed up in your git. It's okay I can try to reproduce it now :) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Thank you for the quick checking! I made some change in #2156(it's base branch is `branch-0.7` while this PR was created on `master`) for the checkbox. The every checkin

[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2156 @Leemoonsoo Yeah it makes sense. So I updated again as you said. - When two types of dynamic form in the paragraph ![record](https://cloud.githubusercontent.com/assets/10060731

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 2nd and 3rd build jobs keep failed even after restarting them several times. And the reasons are as below ``` 1. Restart Zeppelin 2. Create interpreter setting in 'Interp

[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2156 @Leemoonsoo You mean the `checkbox` dynamic form? The `Run on selection change` is only for `select form`. Do you think this can make user confused? --- If your project is set up

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro I feel so sorry to you since it was my bad. Just created hotfix patch #2154 to fix below two issues that you reported. - Select form is not shown up when multiple dynamic forms

[GitHub] zeppelin pull request #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select f...

2017-03-18 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2156 [HOTFOX][Branch-0.7] Fix multi dynamic select forms behaviour ### What is this PR for? This PR is same with #2154 with base branch `branch-0.7`. Please refer to #2154&#

[GitHub] zeppelin pull request #2154: [HOT FIX][MASTER] Fix multi dynamic select form...

2017-03-18 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2154 [HOT FIX][MASTER] Fix multi dynamic select forms behaviour ### What is this PR for? After #2100 merged, we can control the behaviour of running select form using `Run on selection change

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro Thanks for letting me know. Let me check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select form t...

2017-03-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2148 CI failed in two cases with below reason which is irrelevant with this change. ``` No output has been received in the last 10m0s, this potentially indicates a stalled build or

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 Seems some review comments are mixed up in github side :( I just removed some of them and left comment again. Please let me know if you're confused. --- If your project is set up f

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro Thanks for your great contribution! I left some comments. Could you take a look at them? Please let me know if there is something that I missed :) --- If your project is set up

[GitHub] zeppelin issue #2119: [ZEPPELIN-2243] Use uppercase for shortcut description

2017-03-16 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2119 @1ambda Sadly one file has some conflicts after #2100 merged.. Could you resolve this? I'll merge this right after then. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin pull request #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select...

2017-03-16 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2148 [branch-0.7][ZEPPELIN-2060] Make dynamic select form turn on or off using checkbox ### What is this PR for? This PR is same with #2100 with base branch `branch-0.7

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-16 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 @Leemoonsoo Thanks for reveiw. Merge into branch-0.7 and master if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic form va...

2017-03-16 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2072 I'm closing this PR since https://issues.apache.org/jira/browse/ZEPPELIN-2060 will be handled in #2100. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic ...

2017-03-16 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2072 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-16 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 CI is green now. Ready to review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #2100: [ZEPPELIN-2060] Make dynamic select form turn o...

2017-03-16 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2100: [ZEPPELIN-2060] Make dynamic select form turn o...

2017-03-16 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2100 [ZEPPELIN-2060] Make dynamic select form turn on or off using checkbox ### What is this PR for? I added "Auto Run" checkbox for select dynamic form to make user turn on / off

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 @tinkoff-dwh Then you can make this CI status green by reopening-closing this PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 CI failed when it runs `yarn run test` and it seems relevant with this change. Let me update again. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2143: [ZEPPELIN-2266] Parse helium description as HTML

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2143 @1ambda Looks good to me 👍 It's not in the scope of this PR, but as ppl are getting have more interest in Helium, i think we need a guide which explains how ppl can add h

[GitHub] zeppelin issue #2105: [ZEPPELIN-2215] Progress bar for Spell execution

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2105 Merge into master if there are no more comment on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 @Leemoonsoo I made `runOnSelectionChange` can be persisted under `note.json`'s `config` field like below. https://cloud.githubusercontent.com/assets/10060731/23981188/fe8a5fbe-0a47

[GitHub] zeppelin issue #2119: [ZEPPELIN-2243] Use uppercase for shortcut description

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2119 Merge into branch-0.7 and master if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 @Leemoonsoo Didn't realize that. Thanks for letting me know. Let me update again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 Cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2126 Thanks again @1ambda. Will merge into gh-pages if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 CI is also green now :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 @Leemoonsoo I added two test cases as you said in this commit: 66c6c21d1bb435f5ade327a8f68cf3e8897e1fb3 - Check "Run on selection change" menu appears or not, when select form i

[GitHub] zeppelin issue #2100: [ZEPPELIN-2060] Make dynamic select form turn on or of...

2017-03-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2100 @Leemoonsoo @felixcheung Sorry for my late update. To provide more intuitive label, I changed it from `Auto run` -> `Run on selection change` and added tooltip msg to let user know they st

[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...

2017-03-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2126 @1ambda @felixcheung Thanks! I updated the overview sentences as well. - before ![screen shot 2017-03-14 at 4 07 45 pm](https://cloud.githubusercontent.com/assets/10060731

[GitHub] zeppelin issue #2127: [gh-pages] Initialize bootstrap tooltip

2017-03-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2127 @1ambda Thanks for testing it out! Merge into gh-pages if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2105: [ZEPPELIN-2215] Progress bar for Spell execution

2017-03-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2105 Looks good! Regarding `%`, if the percentage means nothing, then it's okay with not showing it i think. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2119: [ZEPPELIN-2243] Use uppercase for shortcut description

2017-03-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2119 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #2127: [gh-pages] Initialize bootstrap tooltip

2017-03-12 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2127 [gh-pages] Initialize bootstrap tooltip ### What is this PR for? Currently can't see a tooltip msg when I hover mouse on ![screen shot 2017-03-13 at 11 37 36 am](

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217][WIP] AdvancedTransformation for Visual...

2017-03-12 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Okay then feel free to ping me when they're done :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

2017-03-12 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2101 Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    1   2   3   4   5   6   7   8   9   10   >