[GitHub] [zeppelin] EricGao888 closed pull request #4160: [ZEPPELIN-5434] Upgrade jetty to 9.4.42.v20210604

2022-05-29 Thread GitBox
EricGao888 closed pull request #4160: [ZEPPELIN-5434] Upgrade jetty to 9.4.42.v20210604 URL: https://github.com/apache/zeppelin/pull/4160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] saLeox opened a new pull request, #4374: [ZEPPELIN-5744] Allow NoteManager for concurrent operation

2022-05-27 Thread GitBox
saLeox opened a new pull request, #4374: URL: https://github.com/apache/zeppelin/pull/4374 ### What is this PR for? When multi users perform some notebook/folder operation, like rename or move, some notebooks become not accessible from zeppelin page, while they are still existing on the

[GitHub] [zeppelin] dependabot[bot] closed pull request #4365: Bump grunt from 0.4.5 to 1.5.2 in /zeppelin-web

2022-05-25 Thread GitBox
dependabot[bot] closed pull request #4365: Bump grunt from 0.4.5 to 1.5.2 in /zeppelin-web URL: https://github.com/apache/zeppelin/pull/4365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4365: Bump grunt from 0.4.5 to 1.5.2 in /zeppelin-web

2022-05-25 Thread GitBox
dependabot[bot] commented on PR #4365: URL: https://github.com/apache/zeppelin/pull/4365#issuecomment-1137934313 Superseded by #4373. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4373: Bump grunt from 0.4.5 to 1.5.3 in /zeppelin-web

2022-05-25 Thread GitBox
dependabot[bot] opened a new pull request, #4373: URL: https://github.com/apache/zeppelin/pull/4373 Bumps [grunt](https://github.com/gruntjs/grunt) from 0.4.5 to 1.5.3. Release notes Sourced from https://github.com/gruntjs/grunt/releases";>grunt's releases. v1.5.3 Merg

[GitHub] [zeppelin] fhygh commented on pull request #278: HBase Shell Interpreter

2022-05-23 Thread GitBox
fhygh commented on PR #278: URL: https://github.com/apache/zeppelin/pull/278#issuecomment-1135458967 @felixcheung hello, i saw you using hbase-1.0.2 works fine, but i using hbase 2.4.12 got the same error: -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-23 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1135320025 > How did it happen? How did you fix the error? The type of default value of ZEPPELIN_INTERPRETER_CONNECT_TIMEOUT was int before. When the ZEPPELIN_INTERPRETER_CONNECT_TIMEOUT

[GitHub] [zeppelin] Reamer commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-23 Thread GitBox
Reamer commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1134796637 > > This PR currently seems to cause the test ` K8sStandardInterpreterLauncherTest` to fail, though they looks like to be not related. It's ok to run ` K8sStandardInterpreterLauncherTest`

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-22 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1134256118 > This PR currently seems to cause the test ` K8sStandardInterpreterLauncherTest` to fail, though they looks like to be not related. It's ok to run ` K8sStandardInterpreterLauncherTest

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4372: Bump gson from 2.8.6 to 2.8.9 in /bigquery

2022-05-20 Thread GitBox
dependabot[bot] opened a new pull request, #4372: URL: https://github.com/apache/zeppelin/pull/4372 Bumps [gson](https://github.com/google/gson) from 2.8.6 to 2.8.9. Release notes Sourced from https://github.com/google/gson/releases";>gson's releases. Gson 2.8.9 Make

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4371: Bump gson from 2.8.6 to 2.8.9

2022-05-20 Thread GitBox
dependabot[bot] opened a new pull request, #4371: URL: https://github.com/apache/zeppelin/pull/4371 Bumps [gson](https://github.com/google/gson) from 2.8.6 to 2.8.9. Release notes Sourced from https://github.com/google/gson/releases";>gson's releases. Gson 2.8.9 Make

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4370: Bump gson from 2.8.2 to 2.8.9 in /zeppelin-integration

2022-05-20 Thread GitBox
dependabot[bot] opened a new pull request, #4370: URL: https://github.com/apache/zeppelin/pull/4370 Bumps [gson](https://github.com/google/gson) from 2.8.2 to 2.8.9. Release notes Sourced from https://github.com/google/gson/releases";>gson's releases. Gson 2.8.9 Make

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-19 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1132495431 CI seems to be unstable recently 🤒 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer commented on pull request #4369: [ZEPPELIN-5737] try to avoid deadlock

2022-05-19 Thread GitBox
Reamer commented on PR #4369: URL: https://github.com/apache/zeppelin/pull/4369#issuecomment-1131586497 With manual tests, which previously created the deadlock, I can no longer create the deadlock with these changes. But maybe there are other things that don't work anymore because of the c

[GitHub] [zeppelin] Reamer opened a new pull request, #4369: [ZEPPELIN-5737] try to avoid deadlock

2022-05-16 Thread GitBox
Reamer opened a new pull request, #4369: URL: https://github.com/apache/zeppelin/pull/4369 ### What is this PR for? This pull request is to prevent a deadlock which occurs in connection with a fast cancel in the LazyOpenInterpreter. This PR should also correct the closing of interp

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-16 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127457238 > Another improvement `timeUnitToMill` should throw an exception instead of returning `-1`. This exception should be caught and reacted to. 👍 Thanks a lot for your advice!

[GitHub] [zeppelin] Reamer commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-16 Thread GitBox
Reamer commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127452381 > How do you think about it? Much better. Another improvement `timeUnitToMill` should throw an exception instead of returning `-1`. This exception should be caught and react

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-16 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127446019 > I do not like this solution and would "veto" it. The readability and simplicity of the code suffers greatly with this change. I would prefer a conversion directly at the call (e.g.

[GitHub] [zeppelin] Reamer commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-15 Thread GitBox
Reamer commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127283568 I do not like this solution and would "veto" it. The readability and simplicity of the code suffers greatly with this change. I would prefer a conversion directly at the call (e.g. htt

[GitHub] [zeppelin] zjffdu commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-15 Thread GitBox
zjffdu commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127206670 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [zeppelin] zjffdu commented on pull request #4367: Small typos in Spark introduction

2022-05-14 Thread GitBox
zjffdu commented on PR #4367: URL: https://github.com/apache/zeppelin/pull/4367#issuecomment-112817 No problem @antonvasilev52 Thanks for your contribution, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] antonvasilev52 commented on pull request #4367: Small typos in Spark introduction

2022-05-13 Thread GitBox
antonvasilev52 commented on PR #4367: URL: https://github.com/apache/zeppelin/pull/4367#issuecomment-1126249032 @zjffdu, updated. I'm sorry that I didn't do it right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125990383 > @huage1994 Could you add unit test in ZeppelinConfigurationTest? Sure. I would add it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] zjffdu commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
zjffdu commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125981646 @huage1994 Could you add unit test in ZeppelinConfigurationTest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [zeppelin] huage1994 commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
huage1994 commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125951606 > Thank you but it looks like braking configuration after upgrading it. Do you have any plan to support old configuration in a new version? Otherwise, do users need to change it by han

[GitHub] [zeppelin] Reamer merged pull request #4348: [ZEPPELIN-5712] Improve Interpreter Pod name

2022-05-13 Thread GitBox
Reamer merged PR #4348: URL: https://github.com/apache/zeppelin/pull/4348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] jongyoul commented on pull request #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
jongyoul commented on PR #4368: URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1125928609 Thank you but it looks like braking configuration after upgrading it. Do you have any plan to support old configuration in a new version? Otherwise, do users need to change it by hand?

[GitHub] [zeppelin] huage1994 opened a new pull request, #4368: [ZEPPELIN-5730] Support time unit setting in zeppelin conf.

2022-05-13 Thread GitBox
huage1994 opened a new pull request, #4368: URL: https://github.com/apache/zeppelin/pull/4368 ### What is this PR for? This PR is to upport time unit setting in zeppelin conf, such as `5s` ,`3m` ,`1h`. ### What type of PR is it? Feature ### Todos * [ ] - Task

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-05-13 Thread GitBox
Reamer commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r872092418 ## zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoPlugin.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-05-13 Thread GitBox
Reamer commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r872091416 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java: ## @@ -54,11 +57,11 @@ public InterpreterClien

[GitHub] [zeppelin] zjffdu merged pull request #4335: [ZEPPELIN-5600] Support Flink 1.15

2022-05-12 Thread GitBox
zjffdu merged PR #4335: URL: https://github.com/apache/zeppelin/pull/4335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] zjffdu commented on pull request #4367: Small typos in Spark introduction

2022-05-12 Thread GitBox
zjffdu commented on PR #4367: URL: https://github.com/apache/zeppelin/pull/4367#issuecomment-1125505965 LGTM, @antonvasilev52 Could you update the PR description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zeppelin] zjffdu commented on pull request #4335: [ZEPPELIN-5600] Support Flink 1.15

2022-05-12 Thread GitBox
zjffdu commented on PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#issuecomment-1125029998 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zjffdu merged pull request #4364: [ZEPPELIN-5731] DOCS: The title `Zeppelin on Yarn` is somewhat misleading.

2022-05-08 Thread GitBox
zjffdu merged PR #4364: URL: https://github.com/apache/zeppelin/pull/4364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] zjffdu merged pull request #4366: [ZEPPELIN-5729] Increase default value of zeppelin.interpreter.connect.timeout

2022-05-08 Thread GitBox
zjffdu merged PR #4366: URL: https://github.com/apache/zeppelin/pull/4366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-05-03 Thread GitBox
zjffdu commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r864330520 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache.o

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-05-03 Thread GitBox
zjffdu commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r864330520 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache.o

[GitHub] [zeppelin] kbendick commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-05-03 Thread GitBox
kbendick commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r863970691 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache

[GitHub] [zeppelin] kbendick commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-05-03 Thread GitBox
kbendick commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r863970691 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-04-29 Thread GitBox
zjffdu commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r861786630 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache.o

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-04-29 Thread GitBox
zjffdu commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r861786630 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache.o

[GitHub] [zeppelin] antonvasilev52 opened a new pull request, #4367: Small typos in Spark introduction

2022-04-29 Thread GitBox
antonvasilev52 opened a new pull request, #4367: URL: https://github.com/apache/zeppelin/pull/4367 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contributio

[GitHub] [zeppelin] kbendick commented on a diff in pull request #4335: [DRFAT] [ZEPPELIN-5600] Support Flink 1.15

2022-04-28 Thread GitBox
kbendick commented on code in PR #4335: URL: https://github.com/apache/zeppelin/pull/4335#discussion_r861435319 ## flink/flink-scala-parent/pom.xml: ## @@ -41,10 +41,19 @@ 2.3.4 4.0.0 1.15.0 + + _${flink.scala.binary.version} https://archive.apache

[GitHub] [zeppelin] zjffdu commented on pull request #4366: [ZEPPELIN-5729] Increase default value of zeppelin.interpreter.connect.timeout

2022-04-27 Thread GitBox
zjffdu commented on PR #4366: URL: https://github.com/apache/zeppelin/pull/4366#issuecomment-563227 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [zeppelin] huage1994 opened a new pull request, #4366: [ZEPPELIN-5729] Increase default value of zeppelin.interpreter.connect.timeout

2022-04-27 Thread GitBox
huage1994 opened a new pull request, #4366: URL: https://github.com/apache/zeppelin/pull/4366 ### What is this PR for? The default value of zeppelin.interpreter.connect.timeout is 60 seconds. This is too small in the case of running spark in yarn-cluster mode. BTY, the description for

[GitHub] [zeppelin] zjffdu merged pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-26 Thread GitBox
zjffdu merged PR #4360: URL: https://github.com/apache/zeppelin/pull/4360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] zjffdu merged pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-26 Thread GitBox
zjffdu merged PR #4362: URL: https://github.com/apache/zeppelin/pull/4362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4365: Bump grunt from 0.4.5 to 1.5.2 in /zeppelin-web

2022-04-26 Thread GitBox
dependabot[bot] opened a new pull request, #4365: URL: https://github.com/apache/zeppelin/pull/4365 Bumps [grunt](https://github.com/gruntjs/grunt) from 0.4.5 to 1.5.2. Release notes Sourced from https://github.com/gruntjs/grunt/releases";>grunt's releases. v1.5.2 Upda

[GitHub] [zeppelin] EricGao888 commented on pull request #4160: [ZEPPELIN-5434] Upgrade jetty to 9.4.42.v20210604

2022-04-26 Thread GitBox
EricGao888 commented on PR #4160: URL: https://github.com/apache/zeppelin/pull/4160#issuecomment-1110030412 Not sure whether there has been a solution to this issue or not. If no more update, I will close this PR. Thx. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [zeppelin] zjffdu commented on pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-26 Thread GitBox
zjffdu commented on PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#issuecomment-1109737678 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zjffdu commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-26 Thread GitBox
zjffdu commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1109736979 CI is passed, will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] huage1994 opened a new pull request, #4364: [ZEPPELIN-5731] DOCS:The title `Zeppelin on Yarn` is somewhat misleading.

2022-04-26 Thread GitBox
huage1994 opened a new pull request, #4364: URL: https://github.com/apache/zeppelin/pull/4364 ### What is this PR for? The title `Zeppelin on Yarn` is somewhat misleading. It should be consistent with the other title `Zeppelin Interpreter on Docker`. Also fix a small syntax pro

[GitHub] [zeppelin] jongyoul merged pull request #4308: [ZEPPELIN-5655] OSSNotebookRepo support version control.

2022-04-24 Thread GitBox
jongyoul merged PR #4308: URL: https://github.com/apache/zeppelin/pull/4308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] zjffdu commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-24 Thread GitBox
zjffdu commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1107965581 @jasmine-song Could you rebase your PR? CI issue is fixed recenlty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] huage1994 commented on pull request #4308: [ZEPPELIN-5655] OSSNotebookRepo support version control.

2022-04-24 Thread GitBox
huage1994 commented on PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1107788289 Thanks @jongyoul for the comments, they has been resolved. The only failed CI seems to be not related. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-23 Thread GitBox
huage1994 commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r857061596 ## jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java: ## @@ -604,6 +604,10 @@ private String appendProxyUserToURL(String url, String user, String prop

[GitHub] [zeppelin] huage1994 commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-23 Thread GitBox
huage1994 commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1107701488 Thanks @zjffdu a lot. I have added test and rebased my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-23 Thread GitBox
zjffdu commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r856894290 ## jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java: ## @@ -604,6 +604,10 @@ private String appendProxyUserToURL(String url, String user, String propert

[GitHub] [zeppelin] zjffdu commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-23 Thread GitBox
zjffdu commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1107474552 @huage1994 CI issue is fixed, please rebase your PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-23 Thread GitBox
huage1994 commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r856872638 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive stateme

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-21 Thread GitBox
zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855715888 ## zeppelin-zengine/pom.xml: ## @@ -40,6 +40,7 @@ 1.3 2.6.0 4.5.4.201711221230-r +3.6.0 Review Comment: It is also defined in root pom.xml --

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-21 Thread GitBox
zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855715546 ## zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoPlugin.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-21 Thread GitBox
zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855714012 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java: ## @@ -54,11 +57,11 @@ public InterpreterClien

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-21 Thread GitBox
zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855713929 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java: ## @@ -54,11 +57,11 @@ public InterpreterClien

[GitHub] [zeppelin] zjffdu commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-21 Thread GitBox
zjffdu commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1105921869 > 😅 I just add a method in Zeppelin Client and do nothing else. It's so strange that the CI tasks failed. And I re-run CI tasks twice in my own forked zeppelin repository, they st

[GitHub] [zeppelin] Reamer commented on pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-21 Thread GitBox
Reamer commented on PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#issuecomment-1105447197 @zjffdu For a first feedback I would be very grateful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [zeppelin] huage1994 commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-21 Thread GitBox
huage1994 commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1105024368 😂 I just add a method in Zeppelin Client and do nothing else. It's so strange that the CI tasks failed. And I re-run CI tasks twice in my own forked zeppelin repository, they still

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.

2022-04-21 Thread GitBox
huage1994 commented on code in PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#discussion_r855016501 ## docs/setup/storage/storage.md: ## @@ -454,6 +454,16 @@ And you should configure oss related properties in file **zeppelin-site.xml**. Access key secret for you

[GitHub] [zeppelin] jongyoul closed pull request #3007: zeppelin 0.8 version pyspark interpreter error when using ipython

2022-04-20 Thread GitBox
jongyoul closed pull request #3007: zeppelin 0.8 version pyspark interpreter error when using ipython URL: https://github.com/apache/zeppelin/pull/3007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [zeppelin] jongyoul commented on pull request #3007: zeppelin 0.8 version pyspark interpreter error when using ipython

2022-04-20 Thread GitBox
jongyoul commented on PR #3007: URL: https://github.com/apache/zeppelin/pull/3007#issuecomment-1103814288 Let me close it as it's too outdated to handle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] jongyoul closed pull request #2776: Bigquery timestamp formatting fix

2022-04-20 Thread GitBox
jongyoul closed pull request #2776: Bigquery timestamp formatting fix URL: https://github.com/apache/zeppelin/pull/2776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [zeppelin] jongyoul commented on pull request #2776: Bigquery timestamp formatting fix

2022-04-20 Thread GitBox
jongyoul commented on PR #2776: URL: https://github.com/apache/zeppelin/pull/2776#issuecomment-1103810734 I'll close this PR as it's too old to handle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [zeppelin] jongyoul closed pull request #3215: [ZEPPELIN-3167]

2022-04-20 Thread GitBox
jongyoul closed pull request #3215: [ZEPPELIN-3167] URL: https://github.com/apache/zeppelin/pull/3215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [zeppelin] jongyoul commented on pull request #3215: [ZEPPELIN-3167]

2022-04-20 Thread GitBox
jongyoul commented on PR #3215: URL: https://github.com/apache/zeppelin/pull/3215#issuecomment-1103808939 Let me close this PR as there's a similar one. #3216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [zeppelin] jongyoul commented on pull request #2718: ZEPPELIN-3128: The autocomplete in Note Permissions does not work correctly

2022-04-20 Thread GitBox
jongyoul commented on PR #2718: URL: https://github.com/apache/zeppelin/pull/2718#issuecomment-1103807532 Would you mind closing this PR as it's too old? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] jongyoul closed pull request #2346: [gh-pages] Hide pagination btn if there is only 1 page

2022-04-20 Thread GitBox
jongyoul closed pull request #2346: [gh-pages] Hide pagination btn if there is only 1 page URL: https://github.com/apache/zeppelin/pull/2346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [zeppelin] jongyoul commented on pull request #4288: [ZEPPELIN-5632] zeppelin-zengine: Skip load notebook when it is damaged.

2022-04-20 Thread GitBox
jongyoul commented on PR #4288: URL: https://github.com/apache/zeppelin/pull/4288#issuecomment-1103801277 @zjffdu I think this issue introduces more potential problems but it's not related to this PR directly. How about merging it first? It looks like a useful log. WDYT? -- This is an au

[GitHub] [zeppelin] jongyoul merged pull request #4356: Bump async from 2.6.3 to 2.6.4 in /zeppelin-web-angular

2022-04-20 Thread GitBox
jongyoul merged PR #4356: URL: https://github.com/apache/zeppelin/pull/4356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul commented on pull request #4356: Bump async from 2.6.3 to 2.6.4 in /zeppelin-web-angular

2022-04-20 Thread GitBox
jongyoul commented on PR #4356: URL: https://github.com/apache/zeppelin/pull/4356#issuecomment-1103790955 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul merged pull request #4363: [MINOR] Remove unused profile from actions

2022-04-20 Thread GitBox
jongyoul merged PR #4363: URL: https://github.com/apache/zeppelin/pull/4363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4286: [ZEPPELIN-5613] zeppelin-interpreter-parent: Add dependencyManagement for log4j2 in pom.xml

2022-04-20 Thread GitBox
jongyoul commented on code in PR #4286: URL: https://github.com/apache/zeppelin/pull/4286#discussion_r853942778 ## zeppelin-interpreter-parent/pom.xml: ## @@ -33,6 +33,35 @@ 0.9.0-SNAPSHOT Zeppelin: Interpreter Parent + +2.17.1 + + + + + +org.

[GitHub] [zeppelin] jongyoul opened a new pull request, #4363: [MINOR] Remove unused profile from actions

2022-04-20 Thread GitBox
jongyoul opened a new pull request, #4363: URL: https://github.com/apache/zeppelin/pull/4363 ### What is this PR for? Removing unused profile ``` Warning: The requested profile "hadoop2" could not be activated because it does not exist. ``` ### What type of PR is

[GitHub] [zeppelin] jongyoul commented on pull request #4356: Bump async from 2.6.3 to 2.6.4 in /zeppelin-web-angular

2022-04-20 Thread GitBox
jongyoul commented on PR #4356: URL: https://github.com/apache/zeppelin/pull/4356#issuecomment-1103690324 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-20 Thread GitBox
jongyoul commented on PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#issuecomment-1103683323 Thank you for the reply. I feel like it's fairly enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.

2022-04-20 Thread GitBox
jongyoul commented on code in PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#discussion_r853908539 ## zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java: ## @@ -17,43 +17,33 @@ package org.apache.zeppelin.notebo

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.

2022-04-20 Thread GitBox
jongyoul commented on code in PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#discussion_r853906989 ## docs/setup/storage/storage.md: ## @@ -454,6 +454,16 @@ And you should configure oss related properties in file **zeppelin-site.xml**. Access key secret for your

[GitHub] [zeppelin] 0Ams commented on a diff in pull request #4286: [ZEPPELIN-5613] zeppelin-interpreter-parent: Add dependencyManagement for log4j2 in pom.xml

2022-04-19 Thread GitBox
0Ams commented on code in PR #4286: URL: https://github.com/apache/zeppelin/pull/4286#discussion_r853619661 ## zeppelin-interpreter-parent/pom.xml: ## @@ -33,6 +33,35 @@ 0.9.0-SNAPSHOT Zeppelin: Interpreter Parent + +2.17.1 + + + + + +org.apac

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-19 Thread GitBox
Reamer commented on code in PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852759014 ## zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts: ## @@ -160,7 +160,7 @@ export enum OP { /** * [c-s] * ask paragrap

[GitHub] [zeppelin] Reamer commented on pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

2022-04-19 Thread GitBox
Reamer commented on PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#issuecomment-1102245334 > BTW, did you have any experience with PF4J before? I heard it for the first time so I just wonder if you are already familiar with it or not. Not at all, I came across the project

[GitHub] [zeppelin] jasmine-song commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-19 Thread GitBox
jasmine-song commented on code in PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852698712 ## zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts: ## @@ -160,7 +160,7 @@ export enum OP { /** * [c-s] * ask pa

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph

2022-04-18 Thread GitBox
Reamer commented on code in PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852649523 ## zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts: ## @@ -160,7 +160,7 @@ export enum OP { /** * [c-s] * ask paragrap

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852616747 ## zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java: ## @@ -56,6 +56,8 @@ public static void main(String[] args) thr

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852615303 ## zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java: ## @@ -56,6 +56,8 @@ public static void main(String[] args) thr

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852612929 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive statement"

[GitHub] [zeppelin] huage1994 opened a new pull request, #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

2022-04-18 Thread GitBox
huage1994 opened a new pull request, #4362: URL: https://github.com/apache/zeppelin/pull/4362 ### What is this PR for? Currently there's a cancelParagraph method in zeppelin client api, however, there's no cancelNote method. PR is to add a cancelNote method in zeppelin client api.

[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-18 Thread GitBox
huage1994 commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852553473 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive stateme

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

2022-04-18 Thread GitBox
zjffdu commented on code in PR #4360: URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852185434 ## jdbc/src/main/resources/interpreter-setting.json: ## @@ -143,6 +143,13 @@ "defaultValue": "1000", "description": "Query interval for hive statement"

[GitHub] [zeppelin] jongyoul merged pull request #4350: Bump hadoop-common from 2.3.0 to 3.2.3 in /beam

2022-04-18 Thread GitBox
jongyoul merged PR #4350: URL: https://github.com/apache/zeppelin/pull/4350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul commented on pull request #4350: Bump hadoop-common from 2.3.0 to 3.2.3 in /beam

2022-04-18 Thread GitBox
jongyoul commented on PR #4350: URL: https://github.com/apache/zeppelin/pull/4350#issuecomment-1101320146 Will merge it to keep history -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [zeppelin] jongyoul merged pull request #4357: MINOR Update asf.yaml to link with JIRA

2022-04-18 Thread GitBox
jongyoul merged PR #4357: URL: https://github.com/apache/zeppelin/pull/4357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

<    5   6   7   8   9   10   11   12   13   14   >