[GitHub] zeppelin issue #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2018-11-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3240 > Awesome! that is a great news. Just out of curiosity, does the Zeppelin server in KB must be the one which has acess to the Spark_Home or the Spark interpreter which is now a pod? (J

[GitHub] zeppelin issue #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2018-11-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3240 > One question, there is no point using this if I have a Spark clster on YARN (Cloudera/Hortonworks) right? The way I see it this is focusing on having The Spark coming with Zeppelin

[GitHub] zeppelin pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2018-11-24 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3240 [ZEPPELIN-3840] Zeppelin on Kubernetes ### What type of PR is it? This PR adds ability to run Zeppelin on Kubernetes. It aims - Zero configuration to start Zeppelin

[GitHub] zeppelin pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2018-11-24 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3240 ---

[GitHub] zeppelin pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2018-11-24 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3240 [ZEPPELIN-3840] Zeppelin on Kubernetes ### What type of PR is it? This PR adds ability to run Zeppelin on Kubernetes. Key features are - Provides zeppelin-server.yaml

[GitHub] zeppelin issue #3231: [MINOR] Let jenkins print some build summary on failur...

2018-11-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3231 Merge to master, if no further comments. ---

[GitHub] zeppelin issue #3230: [ZEPPELIN-3847] Duplicate results in notebooks due to ...

2018-11-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3230 Thanks @zjffdu, @felixcheung for review. Merge to master and branch-0.8. ---

[GitHub] zeppelin pull request #3231: [MINOR] Let jenkins print some build summary on...

2018-11-17 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3231 [MINOR] Let jenkins print some build summary on failure ### What is this PR for? Currently actual CI build occurs in individual contributor's travis-ci account, and apache Jenkins poll

[GitHub] zeppelin pull request #3231: [MINOR] Let jenkins print some build summary on...

2018-11-17 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3231 ---

[GitHub] zeppelin pull request #3232: [ZEPPELIN-3838] Input function example code inc...

2018-11-17 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3232 [ZEPPELIN-3838] Input function example code incorrect on "What is Dynamic Form" page ### What is this PR for? Input function example screenshot is incorrect on "What

[GitHub] zeppelin pull request #3231: Let jenkins print some build summary on failure

2018-11-17 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3231 Let jenkins print some build summary on failure ### What is this PR for? Currently actual CI build occurs in individual contributor's travis-ci account, and apache Jenkins poll the result

[GitHub] zeppelin pull request #3230: [ZEPPELIN-3847] Duplicate results in notebooks ...

2018-11-17 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3230 [ZEPPELIN-3847] Duplicate results in notebooks due to WS interruption ### What is this PR for? Duplicate results in notebooks after ws reconnect. The problem occurs via duplicated

[GitHub] zeppelin issue #3226: [ZEPPELIN-3095][ZP-25] fix UI when paragraphs run sequ...

2018-11-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3226 Thanks @Savalek for the contribution. I have a few questions. 1. What happens if a browser opens running notebook? Is it correct that `SEQUENTIAL_RUN_STATUS` message

[GitHub] zeppelin issue #3225: docs [branch-0.8]: REST API JSON response status fix

2018-11-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3225 This PR has been merged to branch-0.8. But somehow @asfgit didn't close the PR. @jolks Do you mind close this PR manually? ---

[GitHub] zeppelin issue #3224: docs [master]: REST API JSON response status fix

2018-11-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3224 Thanks @jolks for the contribution. LGTM and merge to master ---

[GitHub] zeppelin issue #3217: [ZEPPELIN-3848] zeppelin-web dev mode does not work

2018-11-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3217 Thanks @felixcheung for review. merge to master. ---

[GitHub] zeppelin issue #3220: ZEPPELIN-3846. Code Completion is broken

2018-11-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3220 LGTM ---

[GitHub] zeppelin issue #3219: [ZEPPELIN-3850] Fix run all paragraph behavior

2018-11-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3219 Thanks @felixcheung for review. Merge to master. ---

[GitHub] zeppelin pull request #3219: [ZEPPELIN-3850] Fix run all paragraph behavior

2018-11-05 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3219 [ZEPPELIN-3850] Fix run all paragraph behavior ### What is this PR for? "Run all paragraphs" button runs only the first paragraph of the note. This PR fixes t

[GitHub] zeppelin pull request #3218: [ZEPPELIN-3849] display note name correctly.

2018-11-05 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3218 [ZEPPELIN-3849] display note name correctly. ### What is this PR for? Master branch displays note id instead of note name. I think it's side effect after change https://github.com

[GitHub] zeppelin issue #3207: [ZEPPELIN-3825] Allow custom service account for GCSNo...

2018-11-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3207 @88sanjay Cool! LGTM ---

[GitHub] zeppelin issue #3216: [ZEPPELIN-3167]

2018-11-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3216 Thanks @NicolasRouquette for the contribution. Looks like CI test is failing at ``` Results : Failed tests: SparkRInterpreterTest.testSparkRInterpreter:88

[GitHub] zeppelin issue #3212: [ZEPPELIN-3837] update how_to_build.md

2018-11-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3212 Merge to master ---

[GitHub] zeppelin issue #3214: [ZEPPELIN-3836] [FOLLOWUP] Update link in README.md

2018-11-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3214 Merge to master ---

[GitHub] zeppelin pull request #3217: [ZEPPELIN-3848] zeppelin-web dev mode does not ...

2018-11-04 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3217 [ZEPPELIN-3848] zeppelin-web dev mode does not work ### What is this PR for? zeppelin-web development mode is broken. `npm run dev` throws error ``` Error: Cannot find module

[GitHub] zeppelin pull request #3214: [ZEPPELIN-3836] [FOLLOWUP] Update link in READM...

2018-11-04 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3214 ---

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-11-04 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3212 [ZEPPELIN-3837] update how_to_build.md ### What is this PR for? how_to_build.md includes some build profiles that has removed/changed. This PR makes how_to_build.md up to dated

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-11-04 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3212 ---

[GitHub] zeppelin pull request #3214: [ZEPPELIN-3836] [FOLLOWUP] Update link in READM...

2018-11-04 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3214 [ZEPPELIN-3836] [FOLLOWUP] Update link in README.md ### What is this PR for? After https://github.com/apache/zeppelin/pull/3211, some link in README.md need to be updated

[GitHub] zeppelin pull request #3214: [ZEPPELIN-3836] [FOLLOWUP] Update link in READM...

2018-11-03 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3214 ---

[GitHub] zeppelin pull request #3214: [ZEPPELIN-3836] [FOLLOWUP] Update link in READM...

2018-11-03 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3214 [ZEPPELIN-3836] [FOLLOWUP] Update link in README.md ### What is this PR for? After https://github.com/apache/zeppelin/pull/3211, some link in README.md need to be updated

[GitHub] zeppelin issue #3207: [ZEPPELIN-3825] Allow custom service account for GCSNo...

2018-11-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3207 Thanks @88sanjay for the contribution. Few problem on CI test has been fixed recently. Do you mind rebase your branch and see if this PR passes CI test just in case? ---

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-11-03 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3212 [ZEPPELIN-3837] update how_to_build.md ### What is this PR for? how_to_build.md includes some build profiles that has removed/changed. This PR makes how_to_build.md up to dated

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-11-03 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3212 ---

[GitHub] zeppelin pull request #3214: [ZEPPELIN-3836] [FOLLOWUP] Update link in READM...

2018-11-03 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3214 [ZEPPELIN-3836] [FOLLOWUP] Update link in README.md ### What is this PR for? After https://github.com/apache/zeppelin/pull/3211, some link in README.md need to be updated

[GitHub] zeppelin issue #3211: [ZEPPELIN-3836] update website url rewrite rule for 0....

2018-11-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3211 Thanks @felixcheung. Merging and deploy this change. ---

[GitHub] zeppelin issue #3213: [ZEPPELIN-3839] Replace | to , in the filename

2018-11-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3213 Thanks @felixcheung review. ---

[GitHub] zeppelin pull request #3213: [ZEPPELIN-3839] Replace | to , in the filename

2018-10-31 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3213 [ZEPPELIN-3839] Replace | to , in the filename ### What is this PR for? A tutorial notebook filename, which includes `|`, is not compatible with windows filesystem. This PR replace

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-10-31 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/3212 ---

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-10-31 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/3212 [ZEPPELIN-3837] update how_to_build.md ### What is this PR for? how_to_build.md includes some build profiles that has removed/changed. This PR makes how_to_build.md up to dated

[GitHub] zeppelin pull request #3212: [ZEPPELIN-3837] update how_to_build.md

2018-10-30 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3212 [ZEPPELIN-3837] update how_to_build.md ### What is this PR for? how_to_build.md includes some build profiles that has removed/changed. This PR makes how_to_build.md up to dated

[GitHub] zeppelin pull request #3211: [ZEPPELIN-3836] update website url rewrite rule...

2018-10-30 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3211 [ZEPPELIN-3836] update website url rewrite rule for 0.8.0 release ### What is this PR for? `https://zeppelin.apache.org/docs/latest` supposed to point latest release version documentation

[GitHub] zeppelin issue #3210: [ZEPPELIN-3835] Update website for 0.8.0 release

2018-10-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3210 @zjffdu @felixcheung please review. ---

[GitHub] zeppelin pull request #3210: [ZEPPELIN-3835] Update website for 0.8.0 releas...

2018-10-29 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3210 [ZEPPELIN-3835] Update website for 0.8.0 release ### What is this PR for? 0.8.0 has released in last June, but what's new section in website still have information of 0.7.x. This PR

[GitHub] zeppelin issue #3061: ZEPELIN-3586. Use hadoop 2.7.3 for embedded spark

2018-07-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3061 LGTM ---

[GitHub] zeppelin issue #3052: [ZEPPELIN-3080] Removing duplicate Date header

2018-07-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3052 LGTM ---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

2018-07-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3049 LGTM ---

[GitHub] zeppelin issue #3050: ZEPPELIN-3581. Add "type": "textarea" to "default.stat...

2018-07-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3050 [CI green](https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/399684108). Merge this to master. ---

[GitHub] zeppelin issue #3051: Fix a broken link in the landing page

2018-07-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3051 Thanks @Byeol for contribution! Merge this as a hotfix. ---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580]

2018-07-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3049 Thanks @oxygen311 for the contribution. Could you resolve conflict and see if it passes CI? ---

[GitHub] zeppelin issue #3050: ZEPPELIN-3581. Add "type": "textarea" to "default.stat...

2018-07-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3050 LGTM ---

[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3033 LGTM ---

[GitHub] zeppelin pull request #3036: [ZEPPELIN-3554] Flaky test - InterpreterContext...

2018-06-19 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/3036 [ZEPPELIN-3554] Flaky test - InterpreterContextTest.testThreadLocal ### What is this PR for? Fix flaky test. See [ZEPL-3554](https://issues.apache.org/jira/browse/ZEPPELIN-3554

[GitHub] zeppelin issue #2991: [ZEPPELIN-3476] change description

2018-05-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2991 LGTM ---

[GitHub] zeppelin issue #2986: ZEPPELIN-2035. BI directional RPC framework between Ze...

2018-05-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2986 I'd like to separate Bi-directional RPC and Bi-directional network connection. Of course Bi directional RPC of course gives lots of benefits. But Bi-directional network connection

[GitHub] zeppelin issue #2986: ZEPPELIN-2035. BI directional RPC framework between Ze...

2018-05-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2986 I was thinking the cases like a (or more) firewalls, NATs between Server and Interpreters. And accepting range of ports on each side is more difficult to configure than accepting a single

[GitHub] zeppelin issue #2986: ZEPPELIN-2035. BI directional RPC framework between Ze...

2018-05-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2986 Thanks @zjffdu for the improvement. Overall looks good to me. I'd like to see CI goes green before merge while it change code a lot. One question. Let's say in the future

[GitHub] zeppelin pull request #2956: [DOC] Fix broken link to writing visualizations...

2018-05-02 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2956 [DOC] Fix broken link to writing visualizations doc ### What is this PR for? This PR fixes broken link to doc. Need to be merged branch-0.8. ### What type of PR is it? Bug Fix

[GitHub] zeppelin issue #2841: [Zeppelin-3224] - Fix "ultimate" visualization

2018-04-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2841 Thanks @Savalek for great improvement. LGTM and merge to master and branch-0.8 if no further comment. ---

[GitHub] zeppelin issue #2911: ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRea...

2018-04-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2911 Thanks @felixalbani. merging it. ---

[GitHub] zeppelin issue #2867: ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRea...

2018-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2867 Thanks @felixalbani for contribution. I'm merging it to master and branch-0.8 if no further comment. ---

[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine

2018-03-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2760 Took a look changes and it looks good to me ---

[GitHub] zeppelin issue #2842: [ZEPPELIN-3300] branch-0.8 broken due to 0.9.0 parent ...

2018-03-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2842 This pullrequest is merged to `branch-0.8`. But asfgit couldn't automatically close it. @weand Could you close it manually? ---

[GitHub] zeppelin issue #2842: [ZEPPELIN-3300] branch-0.8 broken due to 0.9.0 parent ...

2018-03-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2842 Thanks for the fix. Let me merge this to branch-0.8. ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-03-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2763 Thank you. Marked ZEPPELIN-3194 as resolved. ---

[GitHub] zeppelin issue #2829: [ZEPPELIN-3284] z.getInterpreterContext().out().clear(...

2018-03-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2829 Thanks @zjffdu @felixcheung for review. Merge to master and branch-0.8 ---

[GitHub] zeppelin issue #2828: [ZEPPELIN-3283] Remove redundant method InterpreterOut...

2018-03-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2828 Thanks @masyan @zjffdu @felixcheung for review. Merge to master and branch-0.8 ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-03-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2763 @masyan Do you have your JIRA id? ---

[GitHub] zeppelin pull request #2829: [ZEPPELIN-3284] z.getInterpreterContext().out()...

2018-03-02 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/2829 [ZEPPELIN-3284] z.getInterpreterContext().out().clear() broken in Python interpreter ### What is this PR for? ``` %python import time print("Hello") time

[GitHub] zeppelin pull request #2829: [ZEPPELIN-3284] z.getInterpreterContext().out()...

2018-03-02 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/2829 ---

[GitHub] zeppelin pull request #2829: [ZEPPELIN-3284] z.getInterpreterContext().out()...

2018-03-02 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/2829 ---

[GitHub] zeppelin pull request #2829: [ZEPPELIN-3284] z.getInterpreterContext().out()...

2018-03-02 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/2829 [ZEPPELIN-3284] z.getInterpreterContext().out().clear() broken in Python interpreter ### What is this PR for? ``` %python import time print("Hello") time

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

2018-03-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2827 LGTM ---

[GitHub] zeppelin pull request #2829: [ZEPPELIN-3284] z.getInterpreterContext().out()...

2018-03-02 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2829 [ZEPPELIN-3284] z.getInterpreterContext().out().clear() broken in Python interpreter ### What is this PR for? ``` %python import time print("Hello") time

[GitHub] zeppelin pull request #2828: [ZEPPELIN-3283] Remove redundant method Interpr...

2018-03-02 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2828 [ZEPPELIN-3283] Remove redundant method InterpreterOutput.getInterpreterResultMessages() ### What is this PR for? Remove Redundant method `InterpreterOutput.getInterpreterResultMessages

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-03-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2763 Thanks @masyan for great contribution. Looks good to me. I'll merge this to master and branch-0.8 if no further comments. ---

[GitHub] zeppelin issue #2817: [ZEPPELIN-3264] Notebook Snapshot feature.

2018-03-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2817 Interesting feature, thanks @SleepyThread for the contribution. ---

[GitHub] zeppelin issue #2811: [ZEPPELIN-3252] Update the Apache Flink version to 1.4...

2018-02-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2811 [Multiple builds](https://travis-ci.org/wegtam/zeppelin/builds/344196467) fails with ``` artifacts could not be resolved: org.apache.flink:flink-clients_2.10:jar:1.4.1

[GitHub] zeppelin issue #2735: [ZEPPELIN-3177]Resize charts on paragaph resize

2018-02-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2735 Tested and it works well. LGTM and merge to master and branch-0.8. ---

[GitHub] zeppelin issue #2771: ZEPPELIN-3209. Preserve thread context classloader whe...

2018-02-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2771 I ran CI test of this branch https://travis-ci.org/Leemoonsoo/zeppelin/builds/343475153 in my travis account. And build went success. I think previous error was flaky test unrelated

[GitHub] zeppelin issue #2771: ZEPPELIN-3209. Preserve thread context classloader whe...

2018-02-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2771 Okay, let me take a look and see if errors are related to this change or not. ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2763 I'd like to merge this PR to master if we have no further reviews. @masyan Is this PR closed on purpose? ---

[GitHub] zeppelin issue #2770: ZEPPELIN-3207. fix search content not appearing

2018-02-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2770 LGTM! Merge to master and branch-0.8 if no further discussions. ---

[GitHub] zeppelin issue #2771: ZEPPELIN-3209. Preserve thread context classloader whe...

2018-02-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2771 Thanks @sancyx for the contribution. It looks good, but i'd like to see if it passes CI. Could you try setup CI and trigger build? ``` Looks like travis-ci

[GitHub] zeppelin issue #2770: ZEPPELIN-3207. fix search content not appearing

2018-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2770 Tested and fix works well. But it's getting build failure with following error. ``` [INFO] [INFO] /zeppelin/zeppelin-web/src/app/search/result-list.controller.js [INFO

[GitHub] zeppelin issue #2776: Bigquery timestamp formatting fix

2018-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2776 @srikgn Could you try include commits related to this contribution only? ---

[GitHub] zeppelin issue #2775: Googlecloud storage notebook repo

2018-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2775 Thanks for the contribution. But this pullrequests includes unrelated commits to this contribution. @srikgn Could you try include commits related to this contribution only? ---

[GitHub] zeppelin issue #2763: [ZEPPELIN-3194][NEW-INTERPRETER] SAP Universe interpre...

2018-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2763 Cool! Looks great to me. ---

[GitHub] zeppelin issue #2774: [ZEPPELIN-3212] delete extra ">" in notebook-actionBar...

2018-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2774 Merge to master and branch-0.8 ---

[GitHub] zeppelin issue #2774: [ZEPPELIN-3212] delete extra ">" in notebook-actionBar...

2018-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2774 Thanks @Savalek for the improvement. LGTM ---

[GitHub] zeppelin issue #2754: Update configuration.md

2018-02-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2754 Merge this to master and branch-0.8 ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

2018-01-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2709 Thanks @zjffdu for explain. Looks good to me. ---

[GitHub] zeppelin issue #2754: Update configuration.md

2018-01-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2754 Thanks for the fix. LGTM ---

[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter

2018-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2709 in the binary package, how spark/scala-2.11 and spark/scala-2.10 modules will be packaged? ---

[GitHub] zeppelin issue #2745: [ZEPPELIN-3189] NPE on paragraph run via API

2018-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2745 Merge to master if no further comment ---

[GitHub] zeppelin issue #2745: [ZEPPELIN-3189] NPE on paragraph run via API

2018-01-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2745 Thanks @necosta for the fix. LGTM ---

[GitHub] zeppelin issue #2711: ZEPPELIN-3112: Markdown interpreter fails with NPE

2017-12-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2711 LGTM ---

[GitHub] zeppelin issue #2698: [ZEPPELIN-3007] display a note name without any path i...

2017-12-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2698 @tinkoff-dwh Looks good to me! Merge to master if no further comment. ---

[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...

2017-12-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2687 Thanks @kjmrknsn. Merge to master if no further review! ---

[GitHub] zeppelin issue #2696: [ZEPPELIN-3091] Correct aggregation functionality in c...

2017-12-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2696 Thanks @namanmishra91. Looks great to me! Merge to master if no further comment. ---

  1   2   3   4   5   6   7   8   9   10   >