[GitHub] zeppelin issue #1761: [ZEPPELIN-1711] Create Docker Images for Released Zepp...

2016-12-17 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1761 @1ambda awesome!. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-12-13 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @1ambda that sounds awesome job, thank you very much. Now the PR is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #1538: [ZEPPELIN-1386] Docker images for running Apach...

2016-12-12 Thread mfelgamal
GitHub user mfelgamal reopened a pull request: https://github.com/apache/zeppelin/pull/1538 [ZEPPELIN-1386] Docker images for running Apache Zeppelin releases ### What is this PR for? This PR is for making docker images for zeppelin releases. It contains a script

[GitHub] zeppelin pull request #1538: [ZEPPELIN-1386] Docker images for running Apach...

2016-12-12 Thread mfelgamal
Github user mfelgamal closed the pull request at: https://github.com/apache/zeppelin/pull/1538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-12-12 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @bzz @1ambda are there further discussion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-12-08 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @bzz @1ambda the script `start-zeppelin.sh` isn't important, it just enforce using port `8080` and zeppelin home dir `/usr/local/zeppelin`, we can ignore it and use `zeppelin.sh`. --- If your

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-12-01 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @bzz I removed `curl build-base make gcc g++` for decreasing the image size, now it's `301 MB`. And `R` is run well. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-25 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @bzz I think that we need to install `build-base make gcc g++` to build `knitr` package in R. And I wonder if we could remove them after building `knitr`. Is this right? --- If your project

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-24 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 Hi @bzz So far, we have binary versions from 0.5.0 to 0.6.2, which help us building docker image to each version instead of building the source code, but I mean that if you want

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-23 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @1ambda It's good if we did that in apache zeppelin repo. but in this case instead of using the created binary versions, we should build the source code inside the docker. Like

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-18 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @astroshim @bzz @1ambda * Now I added a start-zeppelin.script to zeppelin-base image. It allow user to modify some configs by passing env variables. Also the user can share the logs

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-18 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @1ambda I already use automated build of dockerhub, when push any new commit to my repo on github, the dockerhub builds the images recently. For point 2, It's good point and I will take a look

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-12 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @1ambda Thank you for your review, The issue is solved, you can check again. And Thank you for the suggested enhancement for zeppelin.sh script, I think it will make the image better

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-05 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @astroshim I think it is just a message and the shell run normally. you can run with this command `docker run --rm -it -p 8080:8080 -p 8081:8081 mahmoudelgamal/zeppelin-release:0.5.0 -c bash

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-11-03 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @astroshim R and Python are installed and I think that the tutorials should be run without errors. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-10-23 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @astroshim Thank you for your reviews, Can you check the docker image again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-10-21 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1538 @bzz Thank you for your feedback. A MD documentation page is added to the install section of Zeppelin documentation. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-26 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz For me, no further discussion. looking forward to seeing the PR merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-23 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-20 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz @felixcheung Thank you for your reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-18 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @felixcheung done, and now it checks if the main method is static or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-17 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @felixcheung required changes are done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-15 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz Gentle reminder! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-09 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-08 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz the changes are done, could you take a look at pom file and CI ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-01 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz The following updates are made: 1 - Updating beam version from 0.1 to 0.2 2 - License report is updated for all dependencies Regarding point #2 in the previous message, do

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-30 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz kindly be noted for point # 2: Making user do minimal amount of code is good but the only cons is that the user will be given the default implementations and configurations and can

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-29 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-28 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz Gentle reminder! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-21 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @AhyoungRyu the changes is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-21 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz I updated `.travis.yml` and there is an error while building `Could not find the selected project in the reactor: '!beam'` but the command `-pl '!beam'` run on local without any error

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-17 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @felixcheung the requied changes is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-17 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz Kindly be noted that there is no maven Scala 2.11 build for beam runner Flink. The only available build is beam-runners-flink_2.10 . https://mvnrepository.com/artifact/org.apache.beam

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-08-16 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1334 @bzz The required changes is done, in the recent commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1255: [ZEPPELIN-1258] Add Spark packages support to Livy int...

2016-08-14 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1255 @felixcheung : This PR does not change the code. It is just a change in the configurations. So, it should not affect the tests --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1255: [ZEPPELIN-1258] Add Spark packages support to Livy int...

2016-08-13 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1255 @felixcheung do you have any further comments ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1255: Add Spark packages support to Livy interpreter

2016-08-07 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1255 @felixcheung done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-07 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1255 @felixcheung I suggests this title "Adding packages to livy interpreter", Is it Ok ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-07 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1255 @zjffdu do you have any further comments ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-02 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/zeppelin/pull/1255 I think that the livy itself doesn't support add (--jars/--packages property in spark-submit) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin issue #944: [ZEPPELIN-935] Adding more configurations to ...

2016-06-01 Thread mfelgamal
Github user mfelgamal commented on the issue: https://github.com/apache/incubator-zeppelin/pull/944 @prabhjyotsingh Yes, sure, I have tested these configurations on both livy distributions many times --- If your project is set up for it, you can reply to this email and have