[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-13 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 Yes it is! :) ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-13 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 @zffdu: Sorry for not responding earlier. IMHO, deleting `common.max_count` should be dealt with in a separate PR / bug report since it is completely unrelated to the feature here. Until then

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-09 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 @zhongneu: OK, done. ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-07 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 @zjffdu: Hi! Fair enough. What do you want me to do then? Should I remove the `rowsFetchSize` property? ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-12-02 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 @zjffdu: Sorry for taking so long to respond. It's been a busy week. I've rebased my PR as requested. ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-11-26 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 Is there anything else I can improve? ---

[GitHub] zeppelin pull request #3241: ZEPPELIN-3880: Code refactoring: remove class f...

2018-11-24 Thread monsieurp
GitHub user monsieurp opened a pull request: https://github.com/apache/zeppelin/pull/3241 ZEPPELIN-3880: Code refactoring: remove class files using a Java stream ### What is this PR for? Make use of a Java stream instead of an ugly for-loop to get rid of class files

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-11-24 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 argh! I give up... :( ---

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-11-24 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 I don't know why Jenkins failed. Let's try again. ---

[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...

2018-11-24 Thread monsieurp
Github user monsieurp closed the pull request at: https://github.com/apache/zeppelin/pull/3239 ---

[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...

2018-11-24 Thread monsieurp
GitHub user monsieurp reopened a pull request: https://github.com/apache/zeppelin/pull/3239 Zeppelin 3879: create "maxRows" and "rowsFetchSize" values in interpreter/jdbc/interpreter-setting.json ### What is this PR for? This PR introduces code to co

[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...

2018-11-24 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/3239 Thanks @zjffdu and @aka-demik for your comments. I've updated the PR accordingly. ---

[GitHub] zeppelin pull request #3239: Zeppelin 3879: create "maxRows" and "rowsFetchS...

2018-11-23 Thread monsieurp
GitHub user monsieurp opened a pull request: https://github.com/apache/zeppelin/pull/3239 Zeppelin 3879: create "maxRows" and "rowsFetchSize" values in interpreter/jdbc/interpreter-setting.json ### What is this PR for? This PR introduces code to configure m

[GitHub] zeppelin pull request #2799: Add a bunch of missing annotations to ActiveDir...

2018-02-21 Thread monsieurp
Github user monsieurp closed the pull request at: https://github.com/apache/zeppelin/pull/2799 ---

[GitHub] zeppelin issue #2799: Add a bunch of missing annotations to ActiveDirectoryG...

2018-02-16 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2799 Hi @zjffdu. Can I do something to get this PR merged? ---

[GitHub] zeppelin issue #2799: Add a bunch of missing annotations to ActiveDirectoryG...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2799 https://builds.apache.org/job/zeppelin-pull-request/4115/console says: ``` GitHub pull request #2,799 to apache/zeppelin [EnvInject] - Loading node environment variables. Building

[GitHub] zeppelin issue #2799: Add a bunch of missing annotations to ActiveDirectoryG...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2799 Hi @zjffdu. I'm not quite sure your CI workflow works properly. Jenkins keeps returning a red flag even though this is a clean PR from scratch. ---

[GitHub] zeppelin pull request #2799: Add a bunch of missing annotations to ActiveDir...

2018-02-14 Thread monsieurp
GitHub user monsieurp opened a pull request: https://github.com/apache/zeppelin/pull/2799 Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. ### What is this PR for? Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. Those annotations are

[GitHub] zeppelin pull request #2794: ZEPPELIN-3225: Add a bunch of missing annotatio...

2018-02-14 Thread monsieurp
Github user monsieurp closed the pull request at: https://github.com/apache/zeppelin/pull/2794 ---

[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2794 Ok something is up. I'm going to file a new PR. ---

[GitHub] zeppelin pull request #2794: ZEPPELIN-3225: Add a bunch of missing annotatio...

2018-02-14 Thread monsieurp
GitHub user monsieurp reopened a pull request: https://github.com/apache/zeppelin/pull/2794 ZEPPELIN-3225: Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. ### What is this PR for? Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. Those

[GitHub] zeppelin pull request #2794: ZEPPELIN-3225: Add a bunch of missing annotatio...

2018-02-14 Thread monsieurp
Github user monsieurp closed the pull request at: https://github.com/apache/zeppelin/pull/2794 ---

[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2794 Alright. ---

[GitHub] zeppelin pull request #2794: ZEPPELIN-3225: Add a bunch of missing annotatio...

2018-02-14 Thread monsieurp
GitHub user monsieurp reopened a pull request: https://github.com/apache/zeppelin/pull/2794 ZEPPELIN-3225: Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. ### What is this PR for? Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. Those

[GitHub] zeppelin pull request #2794: ZEPPELIN-3225: Add a bunch of missing annotatio...

2018-02-14 Thread monsieurp
Github user monsieurp closed the pull request at: https://github.com/apache/zeppelin/pull/2794 ---

[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2794 Hi @zjffdu! Cool. I will file another PR after this one. I made a mistake, amended my commit and forced pushed it, which is why the CI build failed. How can I get Jenkins to start a

[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-13 Thread monsieurp
Github user monsieurp commented on the issue: https://github.com/apache/zeppelin/pull/2794 Hey @mebelousov! We also use Active Directory at work. We don't go through the AD connector though but instead rely on the LDAP connector. By the way, there are many improvements

[GitHub] zeppelin pull request #2794: Add a bunch of missing annotations to ActiveDir...

2018-02-13 Thread monsieurp
GitHub user monsieurp opened a pull request: https://github.com/apache/zeppelin/pull/2794 Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. ### What is this PR for? Add a bunch of missing annotations to ActiveDirectoryGroupRealm.java. Those annotations are