[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

2018-01-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2729 I think that can be adjusted via `zeppelin.interpreter.output.limit`? Or help me understand if you meant something else. ---

[GitHub] zeppelin issue #2728: ZEPPELIN-3104. Support Hadoop 3.0

2018-01-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2728 Build number 1433.11 fails, assuming it's not related. Rest looks good. ---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

2018-01-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2725 Tried it on local, works well. ---

[GitHub] zeppelin pull request #2729: [ZEPPELIN-2826] support for carriage return '\r...

2018-01-12 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2729 [ZEPPELIN-2826] support for carriage return '\r', on result window ### What is this PR for? This PR implements carriage return '\r' on result window, currently si

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

2018-01-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2721 Thanks for the review will merge this if no more discussion. ---

[GitHub] zeppelin issue #2717: [ZEPPELIN-3127] Upgrade selenium version

2018-01-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2717 Thanks for the review will merge this if no more discussion. ---

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

2018-01-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2721 Have tested this for FF31, FF57, Chrome-63, Safari-11, Windows7's IE-12 and Windows10's Edge-25 ---

[GitHub] zeppelin pull request #2721: ZEPPELIN-3129: Zepplin UI Doesnt logs out in IE

2018-01-08 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2721 ZEPPELIN-3129: Zepplin UI Doesnt logs out in IE ### What is this PR for? Zepplin UI Doesn't logs out in IE/Edge, its Shows Logout Success and automatically reload the page

[GitHub] zeppelin issue #2717: [ZEPPELIN-3127] Upgrade selenium version

2018-01-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2717 Travis job (https://travis-ci.org/prabhjyotsingh/zeppelin/jobs/326663402) for selenium passed, it fails for 608.[6-10] which is not related to this. Will add support for newer

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

2018-01-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2704 Looks good. ---

[GitHub] zeppelin issue #2717: [ZEPPELIN-3127] Upgrade selenium version

2018-01-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2717 Tried FireFox-56, it works, is failing with some of the flaky tests (https://api.travis-ci.org/v3/job/326228047/log.txt, https://api.travis-ci.org/v3/job/326219155/log.txt) Along

[GitHub] zeppelin issue #2717: [ZEPPELIN-3127] Upgrade selenium version

2018-01-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2717 I had to use gecko because "Firefox is only fully supported at version 47.0.1 or earlier. Support for later versions of firefox is provided by geckodriver"

[GitHub] zeppelin issue #2717: [ZEPPELIN-3127] Upgrade selenium version

2018-01-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2717 Selenium 3.x requires JDK8, guava-23, google.gson-2.8.2, which was conflicting with existing zeppelin-server package, hence have moved if to selenium testing to a new package called

[GitHub] zeppelin pull request #2717: [ZEPPELIN-3127] Upgrade selenium version

2018-01-05 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2717 [ZEPPELIN-3127] Upgrade selenium version ### What is this PR for? We are currently using a very old selenium version (i.e. 2.48.2) this is to upgrade it to 3.8.1

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

2018-01-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2704 This looks OK to me. @jithinchandranj can you add some a small note [here](https://github.com/apache/zeppelin/blob/master/docs/setup/security/shiro_authentication.md#configure-realm

[GitHub] zeppelin issue #2705: ZEPPELIN-3106. User impersonation in SPARK is not work...

2017-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2705 Rest, looks good. ---

[GitHub] zeppelin issue #2694: [ZEPPELIN-3090] Support KnoxSSO Authentication

2017-12-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2694 Thanks for the review will merge this if no more discussion. ---

[GitHub] zeppelin issue #2711: ZEPPELIN-3112: Markdown interpreter fails with NPE

2017-12-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2711 Thanks for the review will merge this if no more discussion. ---

[GitHub] zeppelin pull request #2711: ZEPPELIN-3112: Markdown interpreter fails with ...

2017-12-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2711 ZEPPELIN-3112: Markdown interpreter fails with NPE ### What is this PR for? Since pegdown-parser is not thread-safe while trying to run multiple MarkDown paragraphs at once, sometimes

[GitHub] zeppelin issue #2705: ZEPPELIN-3106. User impersonation in SPARK is not work...

2017-12-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2705 Will try this for both spark and shell interpreter, and post my finding later today. ---

[GitHub] zeppelin issue #2694: [ZEPPELIN-3090] Support KnoxSSO Authentication

2017-12-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2694 Added documentation, CI failure looks unrelated. ---

[GitHub] zeppelin issue #2694: [ZEPPELIN-3090] Support KnoxSSO Authentication

2017-12-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2694 Tested it locally, CI failure looks unrelated. @Leemoonsoo @jongyoul @felixcheung @zjffdu ready for review. The way I have implemented this is, Z-server looks for hadoop-jwt

[GitHub] zeppelin pull request #2694: [ZEPPELIN-3090] Support KnoxSSO Authentication

2017-12-04 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2694 [ZEPPELIN-3090] Support KnoxSSO Authentication ### What is this PR for? Zeppelin to support KnoxSSO Authentication method. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin pull request #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unrespo...

2017-11-23 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2683 ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive if there are too many notebooks ### What is this PR for? Zeppelin UI becomes slow/unresponsive if there are too many notebooks

[GitHub] zeppelin pull request #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unrespo...

2017-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2683 ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 Sure yes, just missed it, have updated it. ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 Sure, thanks a lot let me add that. ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 CI green; will merge this if no more discussion. ---

[GitHub] zeppelin pull request #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unrespo...

2017-11-22 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2683 ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive if there are too many notebooks ### What is this PR for? Zeppelin UI becomes slow/unresponsive if there are too many notebooks

[GitHub] zeppelin pull request #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unrespo...

2017-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2683 ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 @tinkoff-dwh Look's like `expand-collapse.directive.js:44` -> "event.stopPropagation()" was prevening it to close, have fixed it. ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 Sure, I was experimenting with few more infinity scroll, let me try those for performance, then will fix this. ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 Sure, in my todo list. Will find this, if this implementation/UX looks OK ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 @tinkoff-dwh Thank you for the link. This seems to perform well. Preview GIF ![after](https://user-images.githubusercontent.com/674497/33120645-bddf7884-cf98-11e7-87ca

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 Yes, thanks I'm trying to explore infinity scroll. ---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

2017-11-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2683 @tinkoff-dwh Sure let me work on that as well. ---

[GitHub] zeppelin pull request #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unrespo...

2017-11-21 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2683 ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive if there are too many notebooks ### What is this PR for? Zeppelin UI becomes slow/unresponsive if there are too many notebooks

[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...

2017-11-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2678 Merging this if no more discussion. ---

[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...

2017-11-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2678 Thanks for the review, have made the suggested changes ---

[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...

2017-11-20 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2678 ---

[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...

2017-11-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2678 [ZEPPELIN-3063] Notebook loses formatting when importing from 0.6.x ### What is this PR for? Notebook loses formatting (shows table instead of the graph) when importing from 0.6.x

[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...

2017-11-17 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2678 [ZEPPELIN-3063] Notebook loses formatting when importing from 0.6.x ### What is this PR for? Notebook loses formatting (shows table instead of the graph) when importing from 0.6.x if

[GitHub] zeppelin issue #2656: ZEPPELIN-3039. Interpreter logs are mixed together

2017-11-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2656 LGTM! ---

[GitHub] zeppelin issue #2656: ZEPPELIN-3039. Interpreter logs are mixed together

2017-11-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2656 Tested locally, earlier it used to be `zeppelin-interpreter-sh-sh-prabhjyot.singh.lan.log` where first "sh" denotes the type of interpreter (Interpreter group) and second &q

[GitHub] zeppelin issue #2648: ZEPPELIN-3029. Cannot delete an interpreter

2017-11-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2648 Tested locally, works well. LGTM. ---

[GitHub] zeppelin issue #2651: ZEPPELIN-3034. Only apply dynamic form for LivySqlnter...

2017-11-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2651 LGTM! ---

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

2017-11-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2554 Sure here you go [ZEPPELIN-3029](https://issues.apache.org/jira/browse/ZEPPELIN-3029) ---

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

2017-11-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2554 @zjffdu Just found out an issue which is a side effect of this PR, now I cannot delete an interpreter. By that what I mean is now say if I delete angular interpreter from the

[GitHub] zeppelin issue #2629: ZEPPELIN-3005. Refine the error message when interpret...

2017-10-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2629 This looks good, and much cleaner than retuning null. ---

[GitHub] zeppelin issue #2628: [ZEPPELIN-2999] Cannot create shell interpreter withou...

2017-10-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2628 Thanks for the review, will merge this if no more discussion. ---

[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...

2017-10-25 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2628 [ZEPPELIN-2999] Cannot create shell interpreter without timeout property ### What is this PR for? A user can not run any shell interpreter if "shell.command.timeout.millisec

[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...

2017-10-25 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2628 ---

[GitHub] zeppelin issue #2628: [ZEPPELIN-2999] Cannot create shell interpreter withou...

2017-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2628 @toughrogrammer What I think you are looking for is "INFINITE_TIMEOUT = -1L", in which case I would recommend instead of removing this "shell.command.timeout.millisecs"

[GitHub] zeppelin pull request #2628: [ZEPPELIN-2999] Cannot create shell interpreter...

2017-10-22 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2628 [ZEPPELIN-2999] Cannot create shell interpreter without timeout property ### What is this PR for? A user can not run any shell interpreter if "shell.command.timeout.millisecs&qu

[GitHub] zeppelin issue #2625: ZEPPELIN-2988. Zeppelin does not start new Livy sessio...

2017-10-17 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2625 > Restarting it automatically will hide the root cause and confuse users. Make sense, LGTM ---

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2621 Merging this if no more discussion. ---

[GitHub] zeppelin issue #2606: [ZEPPELIN-2970] Enhance Authentication decrypting key ...

2017-10-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2606 @felixcheung yes there were four more, have updated those as well. ---

[GitHub] zeppelin issue #2606: [ZEPPELIN-2970] Enhance Authentication decrypting key ...

2017-10-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2606 Thanks for the review will merge this if no more discussion. CI fails for Job #470.2 with following exception; which is unrelated ``` 1) Search block e2e Test correct count

[GitHub] zeppelin pull request #2606: [ZEPPELIN-2970] Enhance Authentication decrypti...

2017-10-04 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2606 [ZEPPELIN-2970] Enhance Authentication decrypting key generation ### What is this PR for? Overview : The random number generator implemented by nextInt() cannot withstand a

[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

2017-09-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2520 Will merge this if no more discussion. ---

[GitHub] zeppelin issue #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

2017-09-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2560 Sure yes, rest all LGTM ---

[GitHub] zeppelin issue #2564: [ZEPPELIN-2896] Replacing addHeader with setHeader met...

2017-09-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2564 Merging this to master and branch-0.7 if no more discussion. ---

[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...

2017-09-05 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2566 [ZEPPELIN-2903] Make setting of working directory to user-home optional for shell interpreter ### What is this PR for? With ZEPPELIN-2841, it had changed the default working

[GitHub] zeppelin issue #2566: [ZEPPELIN-2903] Make setting of working directory to u...

2017-09-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2566 Merging this to master and branch-0.7 if no more discussion. ---

[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...

2017-09-05 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2566 ---

[GitHub] zeppelin pull request #2566: [ZEPPELIN-2903] Make setting of working directo...

2017-09-05 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2566 [ZEPPELIN-2903] Make setting of working directory to user-home optional for shell interpreter ### What is this PR for? With ZEPPELIN-2841, it had changed the default working directory

[GitHub] zeppelin issue #2521: [ZEPPELIN-2841] fix a problem in shell interpreter . W...

2017-09-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2521 @sanjaydasgupta @vistep have create JIRA for the same https://issues.apache.org/jira/browse/ZEPPELIN-2903. ---

[GitHub] zeppelin issue #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

2017-09-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2560 feasibility ask: Like we support python2, and python3 do you think it makes sense to have 2 different interpreters (at-least for now) one that supports Livy-0.2.0/0.3.0 and other as Livy-4

[GitHub] zeppelin issue #2550: [MINOR] Updated shiro.ini.template to include secure c...

2017-08-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2550 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2455: ZEPPELIN-1515. Notebook: HDFS as a backend storage (Us...

2017-08-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2455 Tested on local, works as expected, have tried on both environments, with and without Kerberos. LGTM, except a minor comment. --- If your project is set up for it, you can reply to

[GitHub] zeppelin issue #2529: [ZEPPELIN-1515] Use Hadoop-FileSystem api to implement...

2017-08-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2529 @zjffdu yes you are right, I originally thought I have a different idea, but now I see, this will eventually be that. Will close this then. --- If your project is set up for it, you can

[GitHub] zeppelin pull request #2529: [ZEPPELIN-1515] Use Hadoop-FileSystem api to im...

2017-08-20 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2529: [ZEPPELIN-1515] Use Hadoop-FileSystem api to implement...

2017-08-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2529 PING --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

2017-08-15 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2524 Thanks for the review will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2529: [ZEPPELIN-1515] Use Hadoop-FileSystem api to im...

2017-08-14 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2529 [ZEPPELIN-1515] Use Hadoop-FileSystem api to implement NotebookRepo ### What is this PR for? With this PR, I attempt to use Hadoop-filesystem API to implement `NotebookRepo`, which

[GitHub] zeppelin pull request #2529: [ZEPPELIN-1515] Use Hadoop-FileSystem api to im...

2017-08-14 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2529: [ZEPPELIN-1515] Use Hadoop-FileSystem api to implement...

2017-08-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2529 @zjffdu @jongyoul @felixcheung @halidhuseynov Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin pull request #2529: use Hadoop-FileSystem api to implement Notebook...

2017-08-14 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2529 use Hadoop-FileSystem api to implement NotebookRepo ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check ou

[GitHub] zeppelin issue #2528: ZEPPELIN-2834 Show Interpreter list as expand collapse...

2017-08-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2528 Also, can you add a functionality expand/collapse all setting (button)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

2017-08-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2524 @1ambda @Leemoonsoo @VipinRathor Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

2017-08-11 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2524 [ZEPPELIN-2846] Add selenium test case for AnyOfRolesAuthorizationFilter ### What is this PR for? This is to test the new feature that was brought in with ZEPPELIN-2825

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

2017-08-11 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

2017-08-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2512 Thank you everyone, for the review. Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

2017-08-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2524 Ready for review, https://travis-ci.org/prabhjyotsingh/zeppelin/builds/263300475. 439.2 Failed which is unrelated (have restarted it). --- If your project is set up for it, you can reply

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

2017-08-10 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2524 [ZEPPELIN-2846] Add selenium test case for AnyOfRolesAuthorizationFilter ### What is this PR for? This is to test the new feature that was brought in with ZEPPELIN-2825

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

2017-08-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2512 @1ambda thanks for the review, have handled your review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

2017-08-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2512 @felixcheung, @AhyoungRyu any views on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

2017-08-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2520 Tested on local (for hive and phoenix) works as expected. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2519: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

2017-08-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2519 @ss77892 Thanks for your contribution, your changes look good, but can you update the description of this PR a bit, specifically this section "What is this PR for?" --- If yo

[GitHub] zeppelin pull request #2516: [ZEPPELIN-2827] Spark's pyspark fails if unsupp...

2017-08-07 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2516: [ZEPPELIN-2827] Spark's pyspark fails if unsupp...

2017-08-07 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2516 [ZEPPELIN-2827] Spark's pyspark fails if unsupported version of matplotlib is present ### What is this PR for? %spark.pyspark paragraphs keep running for more than > 5 min

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

2017-08-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2512 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...

2017-08-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2515 CI looks green https://travis-ci.org/VipinRathor/zeppelin/builds/260833075. Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2516: [ZEPPELIN-2827] Spark's pyspark fails if unsupported v...

2017-08-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2516 Thank you, everyone, for the review. Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2516: [ZEPPELIN-2827] Spark's pyspark fails if unsupported v...

2017-08-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2516 @Leemoonsoo @zjffdu @agoodm please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #2516: [ZEPPELIN-2827] Spark's pyspark fails if unsupp...

2017-08-03 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2516 [ZEPPELIN-2827] Spark's pyspark fails if unsupported version of matplotlib is present ### What is this PR for? %spark.pyspark paragraphs keep running for more than > 5 min

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

2017-08-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2512 CI Green, Ready for review. @Leemoonsoo @1ambda @zjffdu Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2515: [ZEPPELIN-2825] - Fix Zeppelin to support any of the S...

2017-08-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2515 LGTM! +1 for adding documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #2512: [ZEPPELIN-2823] Notebook saved status is wrong ...

2017-08-03 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2512: [ZEPPELIN-2823] Notebook saved status is wrong ...

2017-08-03 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2512 [ZEPPELIN-2823] Notebook saved status is wrong if there was a network disconnect or a flaky network. ### What is this PR for? Notebook content doesn't get saved if there is a

<    1   2   3   4   5   6   7   8   9   10   >