[GitHub] zeppelin issue #2302: [minor] Improve Session

2017-04-29 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2302 @Leemoonsoo @felixcheung @jongyoul Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2291: ZEPPELIN-2459 Zeppelin Usability Improvement for new p...

2017-04-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2291 Tested locally, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung have removed hard coded string "hive" as well. CI fails for; not relavent for this change. ``` Test

[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-04-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2293 @krishna-pandey can you set up travis, https://zeppelin.apache.org/contribution/contributions.html#continuous-integration? --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 > why is zeppelin.jdbc.auth.kerberos.proxy.enable removed? My bad, while fixing the above issues, I thought this is redundant, but I forgot about the case where KERBEROS is enab

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 CI is green; https://travis-ci.org/prabhjyotsingh/zeppelin/builds/225173700 https://travis-ci.org/prabhjyotsingh/zeppelin/builds/225214327 --- If your project is set up

[GitHub] zeppelin pull request #2229: [Zeppelin 2367] Hive JDBC proxy user option sho...

2017-04-24 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2229: [Zeppelin 2367] Hive JDBC proxy user option sho...

2017-04-24 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2229 [Zeppelin 2367] Hive JDBC proxy user option should be available even without kerberos ### What is this PR for? Hive JDBC proxy user option should be available generically

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung Sure what you have recommended does make a lot of sense, have implemented what you have suggested. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Sure, got it, have renamed it to "appendProxyUserToURL". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @felixcheung any specific change that you are looking for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Yes, I thought of few options but this was bit con --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @AhyoungRyu, @felixcheung ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...

2017-04-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 @AhyoungRyu @felixcheung thank you for the review, have made the suggested changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2230: ZEPPELIN-2366 In zeppelin SystemUser fails to authenti...

2017-04-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2230 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2017-04-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 Can you run ldapsearch like `ldapsearch -D "user1" -w pwd -H ldaps://testcore.test.dir.org.com:636 -b "DC=testcore,DC=test,DC=dir,DC=org,DC=com" -s

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2017-04-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 Sounds like `activeDirectoryRealm.groupRolesMap = "CN=aGroupName,OU=groups,DC=SOME_GROUP,DC=COMPANY,DC=COM":"group1"` not configured correctly. I would recomme

[GitHub] zeppelin issue #2231: ZEPPELIN-2150. NoSuchMethodError: org.apache.spark.ui....

2017-04-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2231 LGTM, manually verify it on spark 1.6.1, spark 2.0.0 and spark master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2017-04-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 @ekantheshwara yes, this version should have the above-mentioned fix. Could be a configuration issue, if you can share what exactly are you trying with i.e. is it with file based auth

[GitHub] zeppelin issue #2230: ZEPPELIN-2366 In zeppelin SystemUser fails to authenti...

2017-04-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2230 Tested on local, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #2229: [Zeppelin 2367] Hive JDBC proxy user option sho...

2017-04-06 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2229 [Zeppelin 2367] Hive JDBC proxy user option should be avail even without kerberos ### What is this PR for? Hive JDBC proxy user option should be available generically

[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...

2017-04-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/ Tested locally, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #2034: [ZEPPELIN-2133] All interpreters sometimes thro...

2017-03-31 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2170: [HOTFIX][ZEPPELIN-2149] correct variable name used in ...

2017-03-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2170 Will merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2166: [ZEPPELIN-2288] Fix Cross-Site WebSocket check

2017-03-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2166 Thank you for the contribution. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-03-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2134 Just saw it, this definitely looks better. I don't have a strong opinion, I just saw there is a small diff, hence, highlighting it. This is how it gets displayed in spark/livy

[GitHub] zeppelin issue #2131: ZEPPELIN-2256. poll job progress is called twice

2017-03-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2131 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2138: [ZEPPELIN-2260] [branch-0.7] Skip node,npm install and...

2017-03-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2138 LGTM! tested on local, now zeppelin (without local-repo) take little less time to restart. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...

2017-03-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2107 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2122: Jdbc interpreter sometime doesn't show detailed error ...

2017-03-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2122 CI is green. Please help review this. cc: @Leemoonsoo, @r-kamath, @jongyoul, @cloverhearts. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...

2017-03-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2107 Any thoughts on this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2110: [ZEPPELIN-2234][WIP] Can't display the same chart agai...

2017-03-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2110 @1ambda Thank you for fixing this. Tested on local, works well. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2107: [ZEPPELIN-2149] Each interpreter should have a seperat...

2017-03-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2107 I picked up "Interpreter Name" from UI while creating new interpreter, let me rename this to InterpreterGroup. --- If your project is set up for it, you can reply to

[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...

2017-03-08 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2107 [ZEPPELIN-2149] Each interpreter should have a seperate log file ### What is this PR for? In the current implementation, both spark and spark2 uses spark interpreter, both phoenix

[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...

2017-03-08 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2107: [ZEPPELIN-2149] Each interpreter should have a ...

2017-03-07 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2107 [ZEPPELIN-2149] Each interpreter should have a seperate log file ### What is this PR for? In the current implementation, both spark and spark2 uses spark interpreter, both phoenix

[GitHub] zeppelin issue #2092: [ZEPPELIN-2148] On creation of Bar graph zeppelin UI s...

2017-03-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2092 Thank you @1ambda. Will merge this soon based on reviews in https://github.com/apache/zeppelin/pull/2074. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-03-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2051 Sure thank you @gfalcone, will merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #2074: ZEPPELIN-2148: On creation of Bar graph zeppeli...

2017-03-03 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2074 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2090 I still don't see any builds on your travis (https://travis-ci.org/vipul1409/zeppelin/branches). Can you do a empty commit on this branch (ZEPPELIN-2199) `git commit --amend;git

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2090 I meant https://travis-ci.org/vipul1409/zeppelin/settings instead of "andreaTP". Typo --- If your project is set up for it, you can reply to this email and have your re

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2090 Did you switch on 'zeppelin' repository from https://travis-ci.org/profile (https://zeppelin.apache.org/contribution/contributions.html#continuous-integration) ? Also after

[GitHub] zeppelin issue #2091: Env variable to configure maven central repo

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2091 Did you switch on 'zeppelin' repository from https://travis-ci.org/profile (https://zeppelin.apache.org/contribution/contributions.html#continuous-integration) ? Also after

[GitHub] zeppelin issue #2086: [ZEPPELIN-2167] User with insufficient privileges can ...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2086 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2074 Sure, I'll merge this soon, and have created a new PR https://github.com/apache/zeppelin/pull/2092 as this has merge conflict with master. Please feel free to review that as well

[GitHub] zeppelin pull request #2092: [ZEPPELIN-2148] On creation of Bar graph zeppel...

2017-03-02 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2092 [ZEPPELIN-2148] On creation of Bar graph zeppelin UI shows it as minigraph - 2 ### What is this PR for? This is based on https://github.com/apache/zeppelin/pull/2074#issuecomment

[GitHub] zeppelin pull request #2086: [ZEPPELIN-2167] User with insufficient privileg...

2017-03-02 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2086 [ZEPPELIN-2167] User with insufficient privileges can still restore files by renaming files in/out of Trash ### What is this PR for? User with insufficient privileges can still

[GitHub] zeppelin pull request #2086: [ZEPPELIN-2167] User with insufficient privileg...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2074 @1ambda did you get time to review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2051 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2054 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2088: [ZEPPELIN-2203][WIP] In case of 'spark2' defaul...

2017-03-01 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2088: [ZEPPELIN-2203] In case of 'spark2' default int...

2017-03-01 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2088 [ZEPPELIN-2203] In case of 'spark2' default interpreter, both '%spark' and '%spark2' point to Spark2. ### What is this PR for? In case of 'spark2' default interpreter, both '%spark

[GitHub] zeppelin issue #2086: [ZEPPELIN-2167] User with insufficient privileges can ...

2017-03-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2086 CI is green. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/206609666. Ready for review. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #2086: [ZEPPELIN-2167] User with insufficient privileg...

2017-03-01 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2086: [ZEPPELIN-2167] User with insufficient privileg...

2017-03-01 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2086 [ZEPPELIN-2167] User with insufficient privileges can still restore files by renaming files in/out of Trash ### What is this PR for? User with insufficient privileges can still

[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...

2017-03-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2076 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTes...

2017-03-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2070 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTes...

2017-02-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2070 CI is green. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/206480767. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

2017-02-28 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2070 [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTest.testPublicPrivateNewNote:11… ### What is this PR for? - Just give some static name to note say "" so it

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

2017-02-28 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTes...

2017-02-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2070 Thank you @jongyoul for reviewing this, have made the suggested changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

2017-02-28 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2070 [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTest.testPublicPrivateNewNote:11… ### What is this PR for? - Just give some static name to note say "" so it

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

2017-02-28 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2081: [ZEPPELIN-2155] [HOTFIX] Flaky test: NotebookTest

2017-02-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2081 Thanks @Leemoonsoo for taking care of this, I also had similar solution. Will revert my changes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTes...

2017-02-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2070 CI seems to be stuck at ``` Tests in error: NotebookSecurityRestApiTest.init:49->AbstractTestRestApi.startUpWithAuthenticationEnable:235->AbstractTestRestApi.sta

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

2017-02-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2054 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-02-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2051 Yes, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2074 @r-kamath, @felixcheung Please help review this as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2074: ZEPPELIN-2148: On creation of Bar graph zeppeli...

2017-02-26 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2074 ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph ### What is this PR for? This is an extension https://github.com/apache/zeppelin/pull/2063. Since that had

[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2063 There were conflicts, will create a new PR for branch-0.7. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2058: [ZEPPELIN-2147] zeppelin should redirect to log...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2058 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2063: ZEPPELIN-2148: On creation of Bar graph zeppeli...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2063 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2058: [ZEPPELIN-2147] zeppelin should redirect to log...

2017-02-26 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2058 [ZEPPELIN-2147] zeppelin should redirect to login page after browser session expires ### What is this PR for? Zeppelin should redirect to login page after browser session expires

[GitHub] zeppelin pull request #2063: ZEPPELIN-2148: On creation of Bar graph zeppeli...

2017-02-26 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2063 ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph ### What is this PR for? On creation of Bar graph zeppelin UI shows it as mini graph, and is easily

[GitHub] zeppelin pull request #2064: [ZEPPELIN-2164] Typo in Insufficient Privileges...

2017-02-26 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2064 [ZEPPELIN-2164] Typo in Insufficient Privileges popup of Zeppelin ### What is this PR for? When trying to delete a note of another user Zeppelin correctly throws a popup

[GitHub] zeppelin pull request #2064: [ZEPPELIN-2164] Typo in Insufficient Privileges...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2069 Thank you @felixcheung and @jongyoul for the quick feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2069 I think you are right. I'll close this, and use `ZEPPELIN_INTP_CLASSPATH_OVERRIDES` and use a different path where ever it is really required. --- If your project is set up for it, you

[GitHub] zeppelin pull request #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should ...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2069 Sure, let me check. I wasn't aware. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2069 Sure, let me check. I wasn't aware. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

2017-02-26 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2070 [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTest.testPublicPrivateNewNote:11… ### What is this PR for? - Just give some static name to note say "" so it

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

2017-02-26 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2070 [ZEPPELIN-2155] Flaky test: NotebookTest - NotebookTest.testPublicPrivateNewNote:11… ### What is this PR for? Will do this in two parts, this one is easy. Just give some static

[GitHub] zeppelin issue #2064: [ZEPPELIN-2164] Typo in Insufficient Privileges popup ...

2017-02-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2064 On re-triggering CI is green now. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204868665. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2063 On retrying the same build, CI is green now https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204865706 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2058 On retrying CI is green now. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204880085 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2058 On retrying the same build, CI is green. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204880085 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2057: ZEPPELIN-2057 InterpreterSettingManager for branch-0.7

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2057 I see this is merged in branch-0.7 should we close this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2062 Can you update the doc (https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap) as well, so user reading http://zeppelin.apache.org/docs/0.7.0/security

[GitHub] zeppelin pull request #2069: [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should ...

2017-02-25 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2069 [ZEPPELIN-2177] ZEPPELIN_INTP_CLASSPATH should contain ZEPPELIN_CONF_DIR ### What is this PR for? ZEPPELIN_INTP_CLASSPATH should contain ZEPPELIN_CONF_DIR so if in case of "

[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2058 https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204880085 (229.2) failed but https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204547180 passed. Merging this to master

[GitHub] zeppelin issue #2064: [ZEPPELIN-2164] Typo in Insufficient Privileges popup ...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2064 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2066: [ZEPPELIN-1725] replace cleanDirectory with forceDelet...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2066 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-02-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2063 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2058: [ZEPPELIN-2147] zeppelin should redirect to login page...

2017-02-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2058 Thank you @r-kamath for reviewing this. Have handled your review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2064: [ZEPPELIN-2164] Typo in Insufficient Privileges popup ...

2017-02-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2064 @Leemoonsoo help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2064: [ZEPPELIN-2164] Typo in Insufficient Privileges...

2017-02-23 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2064 [ZEPPELIN-2164] Typo in Insufficient Privileges popup of Zeppelin ### What is this PR for? When trying to delete a note of another user Zeppelin correctly throws a popup

<    1   2   3   4   5   6   7   8   9   >