[GitHub] zeppelin pull request #1554: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-11-16 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1619: [ZEPPELIN-1647] Save roles and use for broadcasting no...

2016-11-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1619 Tried on local, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1554: [WIP] [ZEPPELIN-1320] Run zeppelin interpreter process...

2016-11-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1554 Sure let me check, I think it could be possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1585: ZEPPELIN-1606. Add interpreter option to interpreter-s...

2016-11-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1585 LGTM, I like this idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1514: ZEPPELIN-1516. NPE LivySparkSQLInterpreter thrown with...

2016-10-31 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1514 Sure, got it. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1559: [ZEPPELIN-1461] Doesn't display "description" value in...

2016-10-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1559 Tested on local LGTM. +1 for adding more test cases! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1554: [WIP] [ZEPPELIN-1320] Run zeppelin interpreter process...

2016-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1554 know issue: restart on interpreter does not work as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1554: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-10-23 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1554 [ZEPPELIN-1320] Run zeppelin interpreter process as web front end user Have recreated this from https://github.com/apache/zeppelin/pull/1322 ### What is this PR

[GitHub] zeppelin pull request #1322: [ZEPPELIN-1320] Run zeppelin interpreter proces...

2016-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-10-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 Closing this, will open a new one with merge of https://github.com/apache/zeppelin/pull/1265. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 I just tried it on my local; so basically it skips all the test cases. ``` WARN [2016-10-20 18:17:05,017] ({main} LivyIntegrationTest.java[checkPreCondition]:66) - livy

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 Otherwise yes, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1502: [gh-pages] Separate "Supported Interpreters" table fro...

2016-10-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1502 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-10-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-10-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Also, can you update the doc as well. Rest LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 Yes, that part I agree, it cannot be tested without jar, `org.mockito.Mock` will always mock. @Leemoonsoo @jongyoul @felixcheung any thought about checking in jar(s

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 What I mean to say was, lets mock these till the time we get livy's jar from public repo, how do you think about that ? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 Any thought about using `org.mockito.Mock`; example https://github.com/apache/zeppelin/blob/master/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java#L78

[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1462 I too share same thought as @felixcheung, if we can avoid jar's, can we use `org.mockito.Mock` instead ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

2016-10-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1489 Tested on local, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

2016-10-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1483 nice ! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath do you want to try and merge this ? [This](https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide) will help you. --- If your project is set up for it, you

[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...

2016-09-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...

2016-09-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Thank you @corneadoug, have fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...

2016-09-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Ready for review. CI fails for #7346.9 with; which is unrelated ``` - should provide onclick method *** FAILED ***  The code passed to eventually never

[GitHub] zeppelin issue #1450: ZEPPELIN-1473. It is not necessary to create SQLContex...

2016-09-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1450 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1449: [MINOR][DOC] Change Markdown class name from Markdown ...

2016-09-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1449 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1450: ZEPPELIN-1473. It is not necessary to create SQLContex...

2016-09-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1450 Tested with latest version of LIVY, works as expected. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties mangled

2016-09-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1442 Thank you @randerzander, will merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...

2016-09-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1437 Will merge this in both master and 0.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

2016-09-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1444 Thank you @corneadoug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1444: ZEPPELIN-1456: Flaky Test: AuthenticationIT

2016-09-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1444 ZEPPELIN-1456: Flaky Test: AuthenticationIT ### What is this PR for? This started happening after ZEPPELIN-1144, https://github.com/apache/zeppelin/pull/1330. This test

[GitHub] zeppelin pull request #1442: ZEPPELIN-1459: Zeppelin JDBC URL properties man...

2016-09-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1442 ZEPPELIN-1459: Zeppelin JDBC URL properties mangled ### What is this PR for? While creating connection `DriverManager.getConnection(url, properties);` for JDBC interpreter, phoenix

[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...

2016-09-19 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1437 ZEPPELIN-1454: Wrong property value on interpreter page ### What is this PR for? If for some reason (for example permission issue in file system) while saving interpreter setting

[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1437 @randerzander can you explain a bit more, how do you think this is related. As scope of this PR is only limited to interpreter property being saved (or fail to save) on file system

[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1438 Rest tried, compiled, build. Tested with spark and jdbc interpreter, both works normally. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6

2016-09-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1438 @minahlee diff of InterpreterFactory.java looks different than https://github.com/apache/zeppelin/pull/1333/files#diff-53b87ca4f9616e88837a1b0dd050c01aR995 --- If your project is set up

[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...

2016-09-19 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1437 ZEPPELIN-1454: Wrong property value on interpreter page ### What is this PR for? If for some reason (for example permission issue in file system) while saving interpreter setting, UI

[GitHub] zeppelin issue #1432: [HOT FIX][ZEPPELIN-1144] Fix compilation errors in Not...

2016-09-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1432 Tested on local, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #:

2016-09-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/zeppelin/commit/21a084b170b29dee0f2d57aae22b00c785ef0c8e#commitcomment-19051094 In zeppelin-web/src/app/interpreter/interpreter.controller.js: In zeppelin-web/src/app/interpreter

[GitHub] zeppelin pull request #:

2016-09-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/zeppelin/commit/21a084b170b29dee0f2d57aae22b00c785ef0c8e#commitcomment-19049191 In zeppelin-web/src/app/interpreter/interpreter.controller.js: In zeppelin-web/src/app/interpreter

[GitHub] zeppelin issue #1428: [ZEPPELIN-1439] Support for running multiple version o...

2016-09-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1428 @Leemoonsoo totally missed it. That looks and works awesome! I'll close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1428 [ZEPPELIN-1439] Support for running multiple version of spark ### What is this PR for? Zeppelin to have support for running multiple version of spark. Currently it's limited

[GitHub] zeppelin pull request #1428: [ZEPPELIN-1439] Support for running multiple ve...

2016-09-14 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1428 [ZEPPELIN-1439] Support for running multiple version of spark ### What is this PR for? Zeppelin to have support for running multiple version of spark. Currently it's limited

[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-09-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1426 Here is before and after of this PR that I observe, and I see these 2 changes - now it does not stream output, i.e. it waits for the entire paragraph execution to be finished

[GitHub] zeppelin issue #1421: [ZEPPELIN-1422][zeppelin-interpreter] fix InterpreterP...

2016-09-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1421 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1417: ZEPPELIN-1400. Use relative path to the interpreter se...

2016-09-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1417 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1381: [ZEPPELIN-1390] SparkInterpreter does not work for Spa...

2016-09-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1381 Tested on HDP2.5, on executing both spark and pyspark `sc.version` prints `res0: String = 2.0.0.2.5.0.0-1245` and works as expected. LGTM --- If your project is set up for it, you can

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

2016-09-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1265 @jongyoul Yes I think hiding "per user" make sense, and it can be a fair assumption if user == "anonymous" then shiro is not enabled. --- If your project is set up f

[GitHub] zeppelin issue #1394: rename r directory to 2BWJFTXKJ

2016-09-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1394 Yes, I did both, rename the directory and https://github.com/prabhjyotsingh/zeppelin/blob/5993506b77be84d71ab730c2965572edd73e870e/notebook/2BWJFTXKJ/note.json#L1041 --- If your project

[GitHub] zeppelin pull request #1394: rename r directory to 2BWJFTXKJ

2016-09-01 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1394 rename r directory to 2BWJFTXKJ ### What is this PR for? Rename "R" directory to "2BWJFTXKJ" under notebook directory to make it look like all other notebooks.

[GitHub] zeppelin issue #1319: ZEPPELIN-1319 Use absolute path for ssl truststore and...

2016-09-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1319 @corneadoug Yes, sure. Will merge this soon if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

2016-08-31 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1189 I'll merge this in sometime soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1380: ZEPPELIN-1326: make profile to select dependency of ha...

2016-08-29 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1380 @jongyoul Sure, I see your point, and it make sense as well. Thank you for pointing it out. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1380: Zeppelin 1326

2016-08-29 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1380 Can you share the recommended changes diff ? I originally thought to move repetitive pom.xml from spark and spark-dependency to parent, which can be used by all. --- If your

[GitHub] zeppelin pull request #1380: Zeppelin 1326

2016-08-29 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1380 Zeppelin 1326 ### What is this PR for? Extension of https://github.com/apache/zeppelin/pull/1353 java.lang.ClassNotFoundException

[GitHub] zeppelin issue #1353: ZEPPELIN-1326: make profile to select dependency of ha...

2016-08-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1353 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

2016-08-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1351 IMO shouldn't it be the other way, in tool tip, show the whole number without truncate, generally not to huge number. Otherwise LGTM. --- If your project is set up for it, you can

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

2016-08-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1351 IMO, instead of UI showing "1.41234312421341234213" it should get truncated/ceil/floor to say not more than 3 places of decimal. --- If your project is set up for it, you

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

2016-08-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1351 Can you take care of the trailing decimal as well ? https://cloud.githubusercontent.com/assets/674497/17996351/eae88dde-6b85-11e6-91ea-c77671244484.png;> --- If your proj

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

2016-08-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1362 +1 for @corneadoug, rest LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1364: [MINOR] Remove unnecessary question mark

2016-08-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1364 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1353: ZEPPELIN-1326: make profile to select dependency of ha...

2016-08-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1353 @jongyoul does this looks OK ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1315: [ZEPPELIN-530] Added changes for Credential Provider, ...

2016-08-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1315 Merging this if no more discussion. CI fails for #6786.9 - Which looks unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 @Leemoonsoo yes thats a good suggestion. Let me try and do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1353: ZEPPELIN-1326: make profile to select dependency of ha...

2016-08-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1353 Build fails for #6803-3,4,9. ``` 'npm install --color=false' failed ``` --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1353: ZEPPELIN-1326: make profile to select dependenc...

2016-08-24 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/1353 ZEPPELIN-1326: make profile to select dependency of hadoop-common for JDBC interpreter ### What is this PR for? java.lang.ClassNotFoundException

[GitHub] zeppelin pull request #1353: ZEPPELIN-1326: make profile to select dependenc...

2016-08-24 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/1353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1353: ZEPPELIN-1326: make profile to select dependency of ha...

2016-08-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1353 @jongyoul Sure, have made both changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 Agreed @echarles, the `doAs` part will be a problem, until [ZEPPELIN-1340](https://issues.apache.org/jira/browse/ZEPPELIN-1340) is resolved. Until then for security we may have to run half

[GitHub] zeppelin pull request #1353: ZEPPELIN-1326: make profile to select dependenc...

2016-08-22 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1353 ZEPPELIN-1326: make profile to select dependency of hadoop-common for JDBC interpreter ### What is this PR for? java.lang.ClassNotFoundException

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 Sure, In this PR I was only thinking about the otherwise case i.e. in the environment where hadoop dependencies where not present, and hence start interpreter as end-web-user

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 Yes, you are right, let me do it right away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 @echarles , Yes agreed, will need to update in doc, and a extra toolbar near the check box where user can enable User Impersonate. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 > It's better to use RUNAS ~ and su - ~ @jongyoul How about I make `use RUNAS ~ and su - ~` by default, but if in `zeppelin-env.sh` a property say `USE_SSH_IMPERSONATION` is

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 Yes, I thought about the usage in mac and windows, and initially started of with using `RUNAS ${userName}` for windows and `su - ${userName}` for *nix systems, but then it requires

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1322 CI green! Ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...

2016-08-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1336 Yes, agreed, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1315: [ZEPPELIN-530] Added changes for Credential Provider, ...

2016-08-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1315 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1296: [ZEPPELIN-1302] fix rinterpreter default prop values i...

2016-08-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1296 Thank you for taking care of it. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1322: [ZEPPELIN-1320] Security fix for Shell/Spark an...

2016-08-11 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1322 [ZEPPELIN-1320] Security fix for Shell/Spark and Python Interpreter ### What is this PR for? While running a Notebook using shell, spark, python uses same user as which zeppelin

[GitHub] zeppelin issue #1319: ZEPPELIN-1319 Use absolute path for ssl truststore and...

2016-08-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1319 Good catch, LGTM! CI failure looks unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1310: Apply new mechanism to HbaseInterpreter

2016-08-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1310 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1315: [ZEPPELIN-530] Added changes for Credential Provider, ...

2016-08-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1315 Thank you @rconline for taking care of this. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1305: [ZEPPELIN-1310] Deactivate angular debugging classes

2016-08-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1305 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1281 LGTM! CI is also green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1299: [ZEPPELIN-1304] Show popup when interpreter name is em...

2016-08-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1299 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1281 Sure, let me take a look at it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1300: ZEPPELIN-1305. Fix bug of ZEPPELIN-1215

2016-08-07 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1300 LGTM Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

2016-08-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1257 I'll try it out, in the mean while, can you update screen-shot in description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1247: ZEPPELIN-1254 Make get and save Interpreter bindings c...

2016-08-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1247 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

2016-08-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1257 @astroshim A lot of these complications is already reduced with https://github.com/apache/zeppelin/pull/1236 (which is already avail in master), take a look at it. --- If your project

[GitHub] zeppelin issue #1247: ZEPPELIN-1254 Make get and save Interpreter bindings c...

2016-08-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1247 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1236: [ZEPPELIN-1237] Auto-suggestion of notebook permission...

2016-08-01 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1236 I think a part of this problem is solved by https://github.com/apache/zeppelin/pull/993 ([ZEPPELIN-987](https://issues.apache.org/jira/browse/ZEPPELIN-987)). But, yes I agree this has

[GitHub] zeppelin issue #1236: [ZEPPELIN-1237] Auto-suggestion of notebook permission...

2016-07-30 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1236 I've looked up few products of which the popular ones Outlook (app) limit to 8 results, Outlook (web i.e. owa) limit to 5 results and JIRA does not limits. I don't have a strong

[GitHub] zeppelin issue #1250: [HOTFIX] change 1.5-SNAPSHOT to 1.5-20160502.230123-45

2016-07-30 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1250 have triggered CI again, I'll merge this as a HOTFIX if it doesn't fail for `apache-jar-resource-bundle`. --- If your project is set up for it, you can reply to this email and have your

<    2   3   4   5   6   7   8   9   >