[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Add uName into jobGroupId for checking...

2018-08-05 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/3006 Modified and passed tests. https://travis-ci.org/woowabros/zeppelin/builds/412253387 ---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Add uName into jobGroupId for checking...

2018-08-04 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/3006 It tested successful. https://travis-ci.org/woowabros/zeppelin/builds/412124390 ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-07-05 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 Some test cases failed but after retry, all completed. https://travis-ci.org/woowahan-jaehoon/zeppelin/builds/399891748 ---

[GitHub] zeppelin issue #2780: [ZEPPELIN-3215] Fix to remove pid of interpreter when ...

2018-07-05 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2780 The 1 case failed but after retry, completed. https://travis-ci.org/woowahan-jaehoon/zeppelin/builds/399892045 ---

[GitHub] zeppelin pull request #2880: [ZEPPELIN-3351] Fix build error with 'spark-2.3...

2018-07-04 Thread woowahan-jaehoon
Github user woowahan-jaehoon closed the pull request at: https://github.com/apache/zeppelin/pull/2880 ---

[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix build error with 'spark-2.3' profi...

2018-07-04 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2880 Ok ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-07-04 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 This is already rebased. ---

[GitHub] zeppelin issue #2780: [ZEPPELIN-3215] Fix to remove pid of interpreter when ...

2018-06-30 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2780 Is there any problem? ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-06-30 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 Is there any problem? ---

[GitHub] zeppelin issue #2780: [ZEPPELIN-3215] Fix to remove pid of interpreter when ...

2018-06-29 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2780 Is this dead issue?? ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-06-29 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 Is this dead issue?? ---

[GitHub] zeppelin issue #3006: [ZEPPELIN-3529] Modify jobGroupId for checking user

2018-06-11 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/3006 @felixcheung, you're right. I modified. ---

[GitHub] zeppelin pull request #3006: Modify jobGroupId for checking user

2018-06-05 Thread woowahan-jaehoon
GitHub user woowahan-jaehoon opened a pull request: https://github.com/apache/zeppelin/pull/3006 Modify jobGroupId for checking user ### What is this PR for? Need to check user in jobGroupId because when some paragraph is running, who run paragraph cannot be found

[GitHub] zeppelin pull request #3005: [ZEPPELIN-3528] Ordering by interpreter name in...

2018-06-05 Thread woowahan-jaehoon
GitHub user woowahan-jaehoon opened a pull request: https://github.com/apache/zeppelin/pull/3005 [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group ### What is this PR for? In 'Create new note' diagram, 'Default Interpreter' is ordered by only interpreter

[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix build error with 'spark-2.3' profi...

2018-05-02 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2880 Oh, I missed. It is not urgent. ---

[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix build error with 'spark-2.3' profi...

2018-05-02 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2880 I want to build for supporting spark-2.3. When I built with these commands, ``` ./dev/change_scala_version.sh 2.11 mvn package -DskipTests -Pspark-2.3 -Phadoop-2.7

[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix build error with 'spark-2.3' profi...

2018-05-02 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2880 I modified title and content. Is that enough or, I'll describe more information. ---

[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix to build for spark 2.3

2018-05-02 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2880 @jongyoul, I know that 'spark-2.3' profile is already existed some maven projects but it has some bugs for building with spark-2.3 profile. ---

[GitHub] zeppelin pull request #2880: Fix to build for spark 2.3

2018-03-19 Thread woowahan-jaehoon
GitHub user woowahan-jaehoon opened a pull request: https://github.com/apache/zeppelin/pull/2880 Fix to build for spark 2.3 ### What is this PR for? build for spark 2.3 ### What type of PR is it? Bug Fix ### Todos * [x] - Remove unused import

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-03-19 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @mebelousov No, It couldn't work. :( ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-02-28 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @mebelousov, I tested about `eval` but it maybe cannot be removed. When I removed `eval`, spark interpreter could not be started because `"`s were removed.

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-02-08 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @mebelousov, #2780 is for your case. ---

[GitHub] zeppelin issue #2780: [ZEPPELIN-3215] Fix to remove pid of interpreter when ...

2018-02-08 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2780 If interpreter run normally, `interpreter.sh` wait 259 line(```wait```) until shuting down interpreter. After click 'restart interpreter', zeppelin send shutdown call

[GitHub] zeppelin pull request #2780: [ZEPPELIN-3215] Fix to remove pid of interprete...

2018-02-08 Thread woowahan-jaehoon
GitHub user woowahan-jaehoon opened a pull request: https://github.com/apache/zeppelin/pull/2780 [ZEPPELIN-3215] Fix to remove pid of interpreter when interpreter shu… ### What is this PR for? When user click 'restart interpreter', pid file about interpreter can be remained

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-02-08 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @mebelousov, I found why pid is remained but it isn't related this. I'll request another PR. Thanks. ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-02-07 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @mebelousov 1. `shutdown_hook` in `interpreter.sh` does work without `sleep 0`. `interpreter.sh` is finished after `shutdown_hook` when this got SIGTERM or SIGINT

[GitHub] zeppelin pull request #:

2018-02-07 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the pull request: https://github.com/apache/zeppelin/commit/d3d020c8a3faef00bba41617e51f7df73ee50dec#commitcomment-27416694 In bin/interpreter.sh: In bin/interpreter.sh on line 205: I have a question. Why do you use `eval`? ---

[GitHub] zeppelin pull request #:

2018-02-07 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the pull request: https://github.com/apache/zeppelin/commit/d1fc86b7b2d2012c0323345166c98cc02886e9f1#commitcomment-27416660 In bin/interpreter.sh: In bin/interpreter.sh on line 209: I have a question. Why do you use `eval`? ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2018-01-17 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @mebelousov, I think that some interpreters process can be remain after shutdown zeppelin. Can you check it? ---

[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter

2017-12-31 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2716 @jongyoul Thank you check it. I know that but repository of #2715 is privated so I re-requested. And I'm checking about fail. ---

[GitHub] zeppelin pull request #2715: [ZEPPELIN-3123] Fix to create pid per each inte...

2017-12-30 Thread woowahan-jaehoon
GitHub user woowahan-jaehoon opened a pull request: https://github.com/apache/zeppelin/pull/2715 [ZEPPELIN-3123] Fix to create pid per each interpreter ### What is this PR for? When interpreter policy is not set globally, zeppelin run many interpreters but pid file is still

[GitHub] zeppelin issue #2714: [ZEPPELIN-3121] Fix to create log per each interpreter

2017-12-30 Thread woowahan-jaehoon
Github user woowahan-jaehoon commented on the issue: https://github.com/apache/zeppelin/pull/2714 I seperated issue of pid and log because log has some issue. ---

[GitHub] zeppelin pull request #2714: Fix to create pid/log per each interpreter (#ZE...

2017-12-29 Thread woowahan-jaehoon
GitHub user woowahan-jaehoon opened a pull request: https://github.com/apache/zeppelin/pull/2714 Fix to create pid/log per each interpreter (#ZEPPELIN-3121) ### What is this PR for? When interpreter policy is not set globally, zeppelin run many interpreters but pid/log file