Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@wary Sorry for late response, the CI seems failed, could you help check
that ? It may due to flaky test, you can try to rerun it.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
@pellmont have you verified in from end to end ? It seems doesn't work for
me when I type tab in frontend. I think it may need frontend change as well.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2635
@felixcheung @prabhjyotsingh Could you help review it ? Thanks
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2615
@tinkoff-dwh Could you explain more what kind of issue you try to fix in
this PR ? I don't get it from the PR description.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2627
@namanmishra91 Right, this could be done in a separate ticket. Very
appreciated if you could help on this, I am not a frontend expert.
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2635
ZEPPELIN-3013. Only parse paragraph text when text is updated
### What is this PR for?
Before this PR, each time when paragraph use interpreter, it would parse
the text to get
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2629
Thanks @prabhjyotsingh , will merge it if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
Make sense, will add document for this feature.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2627
Will merge it if no more comments.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2629
@prabhjyotsingh mind to review it ? Thanks
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
Will merge it if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
@Tagar Good point, Currently there's no such things in frontend. For now,
what user see in frontend is that a new interpreter group is created. (For
spark interpreter, a new spark app is started)
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
@Gauravshah It won't be killed. Because JobRunner in zeppelin server
process will poll the job status periodically . Add one more test to verify
it.
---
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/2632
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2632
[HotFix] - Incorrect interpreter dir
### What is this PR for?
This is for the bug hotfix introduced in #2592 . The issue is that new
interpreter created can not run properly because
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
@jongyoul For now, only Interpreter Process's lifecycle is controlled in
TimeoutLifecycleManager. session level control will be done in future if
necessary.
https://github.com/apache/zeppelin
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
@Tagar It won't be killed, because LifecycleManager will know client is
polling job progress via api Interpreter.getProgress.
https://github.com/apache/zeppelin/pull/2631/files#diff
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2631
@Leemoonsoo @jongyoul @Tagar Please help review. Thanks
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2631
ZEPPELIN-2197. Interpreter Lifecycle Manager
### What is this PR for?
This PR implement the lifecycle manager. There're 2 implementions.
* NullLifecycleManager. Nothing is done
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2627
@namanmishra91 Do you mean after after clicking run all, user click one
paragraph of this note to run it ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Thanks @tinkoff-dwh for fixing this. Could you let me know how
SparkRInterpreter is broken, I am curious to know why our CI didn't catch this.
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2629
ZEPPELIN-3005. Refine the error message when interpreter is not binded to
note
### What is this PR for?
More user-friendly error message.
### What type of PR
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2627
Thanks @felixcheung Will add tests for this. Here's some discussion about
this issue.
http://apache-zeppelin-users-incubating-mailing-list.75479.x6.nabble.com/Implementing-run-all-paragraphs
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2625
Merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2626
Merge if no more discussion
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I made another PR #2627 which only change the backend code.
Let me know whether this meet your requirement.
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2627
[ZEPPELIN-2368]. Option to run all paragraphs *sequentially*
### What is this PR for?
This PR change the "run all paragraphs" to be sequentially running.
###
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2626
@Leemoonsoo Please help review. Thanks
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2626
ZEPPELIN-2998. Fix bug in restarting interpreter in scoped mode
### What is this PR for?
Fixed the bug mentioned in
https://github.com/apache/zeppelin/pull/2554#discussion_r136703878
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2625
@prabhjyotsingh Could you help review it ? Thanks
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2542
@malayhm Could you try to return these failed CI build ?
https://travis-ci.org/malayhm/zeppelin/builds/288324042
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2625
ZEPPELIN-2988. Zeppelin does not start new Livy session if yarn livy
session application is killed
### What is this PR for?
This PR will display a warning message when the livy session
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2607
Merge if no more discussion
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2622
I will merge it soon as it fix the flaky travis build as well.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2622
@felixcheung Right, this PR is trying to fix these flaky test.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
IMHOï¼it is better to have integration test for interpreter. Because
interpreter is usually 3rd party library outside zeppelin. Unit test usually
has many assumption which may not be true in real
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
Thanks for the contribution @pellmont , but I don't think it make sense to
make so large change just for unit test. Actually livy interpreter can run
integration which is much better than unit
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2542
ping @malayhm
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2622
ZEPPELIN-2990. Matplotlib sometimes fails in IPythonInterpreter
### What is this PR for?
Trivial fix for matplotlib fail in `IPythonInterpreter`. Besides that, I
also make some minor changes
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I don't understand why it would invoke frontend. Backend
know more context about paragraph status and backend could control the workflow
of paragraph running easily.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2592
Will merge it if no more discussion.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@wary Before I merge this, could you update the title and add '[MINOR]' ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
Thanks @wary Merge it if no more discussion.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
ping @namanmishra91
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2613
will merge if no more discussion
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2620
not yet, it only affects 0.8.0, so won't cause any compatibility break.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2613
@Leemoonsoo parent project must be pom type, but zeppelin-interpreter is
jar. So I have to introduce module `interpreter-parent`. Interpreter dev guide
is updated in the new commit.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I don't see the current behavior is retained in this PR.
Personally I don't think the current behavior needs to be retained. Even we
want to keep the current behavior, it should
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2618
notebook storage is in module zeppelin-zengine. Just found it has jar
conflicts with the native azure and s3 storage. Will keep it pending for now.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I don't mean your PR doesn't do it correctly. I mean you
could do it in an easier approach with less code changes. Just modifying
`persistAndExecuteSingleParagraph` to make it run
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 Thanks for the contribution. But the implementation is a
little complicated to me. I think the easiest implementation is just run
paragraphs sequentially in backend. Look
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2618
ZEPPELIN-2986. Add hadoop-aws and hadoop-azure to zeppelin server
### What is this PR for?
Trivial fix.
### What type of PR is it?
[Improvement]
### Todos
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2613
Yes, it keeps capability. The interpreter is not changed.
interpreter-setting.json is still packaged into interpreter jar, but copied to
interpreter dir as well in this PR. And interpreter
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2592
@Leemoonsoo Do you have any concern about the compatibility break in this
PR ?
* Add throw InterpreterException which is checked exception for the
abstract methods of Interpreter
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2613
ZEPPELIN-2982. Copy interpreter-setting.json to interpreter dir
### What is this PR for?
2 main changes.
* Introduce `interpreter-parent` module, so that all the interpreter can
reuse
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2605
I think the root cause is that there're 2 fields in Job.java to represent
job status. (`aborted` & `status`). Why not just removing `aborted`
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2542
ping @malayhm
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2597
ping @Leemoonsoo
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2603
@Leemoonsoo Is this fix for
[ZEPPELIN-2927](https://issues.apache.org/jira/browse/ZEPPELIN-2927) ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2542
ping @malayhm @Leemoonsoo
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2600
Custom http headers is needed when integrating knox with livy interpreter.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2412
Sorry, I thought there was code conflict. I will merge it soon
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2412
@qwemicheal sorry for late response, would you mind to update the PR ?
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2600
ZEPPELIN-2953 Allow custom http header for livy interpreter
### What is this PR for?
This PR is trying to allow user to add custom http headers when calling
livy rest api. Use just need
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2597
ZEPPELIN-2942. Remove non-remote interpreter approach
### What is this PR for?
This PR is just trying to remove non-remote interpreter approach.
### What type of PR
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2597
@Leemoonsoo Could you help review ? Thanks
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2592
It would not break the existing interpreter. I introduce `Launcher` concept
to allow customize interpreter to launch. But for now all the interpreter still
use `interpreter.sh` to launch it even
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2592
@Leemoonsoo @jongyoul @felixcheung Could you help review it ? Thanks. It is
followup of #2577
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2594
Thanks @tae-jun LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2542
> This makes interpreter impossible to add / update "editor" configuration
without user recreate interpreterSetting
@Leemoonsoo ZEPPELIN-2907 is not resolved, but the issue
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2593
Thanks @felixcheung , that would the biggest milestone for
`IPythonInterpreter` of zeppelin if someone use it for 100 years :)
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2542
ping @malayhm @Leemoonsoo Any update ?
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2592
ZEPPELIN-2685. Improvement on Interpreter class
### What is this PR for?
Main changes on Interpreter
* Add throw InterpreterException for the abstract methods of `Interpreter`,
this would
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2577
@felixcheung I will do the follow up in
https://issues.apache.org/jira/browse/ZEPPELIN-2685
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2577
Thanks, I will merge it to continue the next follow up PR.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2577
@Leemoonsoo @jongyoul @felixcheung Any more comments ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2591
Thanks @jongyoul
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2591
@jongyoul Which code path use vanila gson for handling json ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2591
@jongyoul I hit this issue before, I think just adding `-MM-dd
HH:mm:ss.SSS` into `NotebookImportDeserializer` should be able to resolve this
issue.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2588
Thanks @prabhjyotsingh Will merge it if no more comment
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
LGTM, will merge it if no more comment
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2588
@prabhjyotsingh Could you help review it ? Thanks
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2588
ZEPPELIN-2993. Code Refactoring of ZEPPELIN-1515 follow up
### What is this PR for?
This is a refactoring PR of ZEPPELIN-1515. Because hadoop's FileSystem API
not only works with hdfs
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
That's correct, please go ahead @necosta
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2587
[WIP] [ZEPPELIN-2909]. Support shared SparkContext across language in livy
interpreter
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
Don't worry. This is known issue tracked in ZEPPELIN-2927.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
LGTM, wait for CI pass
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2577
@Leemoonsoo @jongyoul As I mentioned in the PR description, this is not a
perfect PR. If you don't have any more comments, I will merge it and continue
the next PR to improve it. Thanks
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM, just one concern about `PythonCondaInterpreterTest.java`. It is using
mock which may not found potential bugs. I think we can do unit without mock.
But anyway this could be done
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda This is due to IPythonInterpreter, could create a ticket ? I will
fix it in another PR.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Thanks @cloverhearts , Is it possible to add unit test for
`PythonCondaInterpreter` ? Regarding the CI failure, I know this failure and
will fix it in another PR
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts
`There is only one python library path to be added.`
Do you mean the py4j ? IIUC, PythonInterpreter will add py4j to PYTHONPATH,
it doesn't relate
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts Just to clarify my concern. Here's what I see when I use
conda outside of zeppelin.
Step 1. Create enviroment `env_1` using conda, and install pandas
Step 2. Set
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2577
@Leemoonsoo @jongyoul Could you help review ?
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2577
ZEPPELIN-2898. Support Yarn-Cluster for Spark Interpreter
### What is this PR for?
This is the first version for supporting yarn-cluster of
`SparkInterpreter`. I just delegate all
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2562
Will commit if no more comments.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2565
Right, one major reason is security. Sharing SparkContext across users may
introduce potential security issue.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2561
Will merge if no more discussion
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2560
Will commit if no more discussion.
---
901 - 1000 of 1861 matches
Mail list logo
