[GitHub] [zeppelin] FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-24 Thread GitBox
FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-495549253 Nice! One thought: Is the "any chars" needed for some common guard against running empty paragraphs, or could any chars actually be

[GitHub] [zeppelin] FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492659189 We are using %sh pretty much exactly like @Leemoonsoo described it above. I think this is a really cool feature, but I don't think it