[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-05-04 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1534337348 > @huage1994 Please rebase your current branch. I merged #4582 right now. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-26 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1523121562 This PR would be ready for review after #4582 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-18 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1512627023 There still seems to be a problem. I'm working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-04-18 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1512535026 > Hi @huage1994, I have opened [huage1994#2](https://github.com/huage1994/zeppelin/pull/2). These changes should ensure that the tests go through. I have also removed

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2023-01-23 Thread via GitHub
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400410386 > @huage1994 I think we can proceed with this change. Please rebase your branch to the current master. Thanks @Reamer for reminding!  -- This is an automated message from

[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-08 Thread GitBox
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1343912407 > Really great work. I only noted one small thing. > The bigger problem is that currently core-modules are no longer passing in the CI system, so we need to fix the error that