[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-16 Thread via GitHub
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432962218 Thanks @canhtran for the feedback, https://github.com/apache/zeppelin/pull/4558 indeed cause this issue. The workaround is using `mvn clean package -DskipTests -Pflink-113` -- This is

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-02-12 Thread via GitHub
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1427386135 @canhtran How did you build Zeppelin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2023-01-24 Thread via GitHub
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1402059634 @halfvector @zenozeng @PrabhuJoseph @vineethNaroju I have updated this PR and CI is passed now. Feel free to try it to see whether it solves your problems. -- This is an automated

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-12-18 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1357122735 Thanks for the feedback @PrabhuJoseph @zenozeng @vineethNaroju , I am busy on other stuff recently, will take a look at this later. -- This is an automated message from the Apache Git

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-14 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1313401152 > BTW, a test related to this change failed. Is it fine? https://github.com/apache/zeppelin/actions/runs/3448729205/jobs/5755992907 I will fix it -- This is an automated message

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311634940 > > Will merge if no more comments > > No automated tests? Oops, missing in the commit, let me add it. -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311620071 Will merge if no more comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the