Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge would you be willing to address the comments on the code style
and rebase it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge thank you, that is good to know :)
Could you also please update PR description according to your plans? I.e in
case you decide to pursue suggested architecture - what would be
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Yes, this can be done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
> If you are expecting to code the entire DHT from scratch, it's too tough
for me
That is not an expectation here of course.
Let's think about alternatives - another way is to
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@bzz Here is the update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
I tried the DHT code as a separate project
[code](https://gist.github.com/onkarshedge/796ca7fe0698952ffef92690eec0dd40).The
problem I am facing is notes with size greater than 1000 bytes does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Thank you for your explanation, what's your progress on refactoring current
impelemtation?
Let me try to re-visit points 1-5. Also, let's make sure that behavior of
BittorentRepo is
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@bzz I read the [DHT
specification](http://bittorrent.org/beps/bep_0044.html) and here are some
questions and answers.
Answer to point 2) checkpointing and 3) get Revisions
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge thank you for drawing very nice diagram.
Let me be very clear - you did a great job and quite possible that it is
me, as a mentor who under communicate the expectations about the
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge conf object can be obtained on the fly from current
configurations by `ZeppelinConfiguration.create()`. However, as you mentioned,
all repository storages are currently being
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
And also a note on directories..
1] torrent
notes/
17fa195f6c85f72d197d63896b15f456e624/note.json
282f928f9429828e5ef0a422f13d3263e671a2d3/note.json
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@bzz here is the diagram.
[Link to drive]
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@bzz . I will post a diagram of communication for clear view.
`BittorrentNotebookRepo` does not implement/override any `NotebookRepo`
methods. It uses all VFSNotebookRepo methods.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge on the architecture side - could you please elaborate on the
design that you choose, especially regarding `TorrentServlet` - why do you need
a new servlet? What are the parts that
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@khalidhuseynov thanks for helping.
To actually see `TorrentSocket` in action I have to create
a`WebSocketCreator` and a `Servlet`, then add this to jetty server , [at this
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge thanks for this contribution. as i can see, the design issue
on passing `BittorrentNotebookRepo` to `TorrentSocket` was solved by passing
through constructor. also better have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Sorry, was quite a busy week.
Great progress so far, from the first glance and on the formal side of the
contribution:
1. CI is failing, could you please post here the reason of
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@bzz ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Thank you for sharing the progress! Let me look into this and get back to
you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@bzz Design help needed. Connect all the pieces...
`TorrentEngine` - singleton enum . has methods to start,stop a session.
download a torrent from a magnet link and seed a given input
20 matches
Mail list logo
