[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-23 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1242 Thank you @cloverhearts ! Looks good to me, merging if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-23 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 @bzz Thank you. I had remove to try catch. All requests have been completed. Have a Nice Day--! --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-22 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1242 Thank you for your patience! Looks good to me, except minor style issue above? As soon as it is addressed - I think we should be good to merge it to master. --- If your project is set up

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-21 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-17 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 Thank you @bzz ! CI Test of failure seems to be unrelated to my code. It will probably think of other problems. --- If your project is set up for it, you can reply to this email and h

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-17 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1242 Great work @cloverhearts ! Few minor comments above. Also, looks like CI is failing, and if you could post here the reason - other people could help determining if that is relevant to your cha

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-17 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 @jongyoul You have completed the modifications as comments. Please, check to this pr. Thank you! --- If your project is set up for it, you can reply to this email and have your r

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-17 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 retry ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-16 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-03 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1242 I suggest you'd better refactor `runAll` in order to call `run(paragraph)`. `runAll` actually submits all paragraphs into scheduler. How about it? In a api part, it looks good to me. --- If you

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

2016-08-01 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1242 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th