Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
I'm sorry for delay, @mwkang - my plate was full last week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
ping @bzz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Thank you for your patience @mwkang !
Sorry for the late notice, but could you please take a look and make sure
that code conforms the project styleguilde?
Will merge to master asap,
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz I think This PR have some trouble merging to master.
Because When bzz leave comment, I also leave comment immediately.
So bot did not recognize this PR.
Could you mind if you check
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Thanks! In my experience, if in case of CI failure PR author posts the
failure result from logs - that speeds us review a lot!
CI fails now on Spark 1.6 Scala 2.10 and Scala 2.11 profiles
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz Thanks for your review. I rebase on to master and force push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
This looks like an issue fixed in master 10h ago:
```
[31m- should provide onclick method *** FAILED ***[0m
[31m The code passed to eventually never returned normally. Attempted 1
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Ok, good to know, let me look into that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz No, It does not persists every time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
> If you re-trigger CI more (close this PR) - does the same issue
persists every time?
I'm not sure if it persists. I will re-tigger after fix the issue.
---
If your project is set up for it,
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@mwkang thank you for prompt addressing reviews!
If you re-trigger CI more (close this PR) - does the same issue
persists every time?
---
If your project is set up for it, you can reply to
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
I am not sure this error is related with this issue.
```
Failed tests:
ZeppelinSparkClusterTest.zRunTest:204 expected: but was:
```
---
If your project is set up for it, you can
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@jongyoul Sorry, I missed it. I will check. I appreciate your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
I refactor method name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1248
tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
ð for having a test!
Looks good to me, modulo the issue raised above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@jongyoul Can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
18 matches
Mail list logo
