[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1259 Merge it into master and branch-0.6 if there're no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1259 Thanks @echarles for the review. I have exposed sqlContext as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1259 @minahlee Just saw you comment on ZEPPELIN-1260, but @Leemoonsoo has been fast... I have tested the changes, and now sparkr dataframes are working well (with the `spark` variable which

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1259 @bzz Thanks for quick review. Updated the indent. This should be merged to branch-0.6 as well --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1259 Looks great to me, modulo question above. Thank you for prompt fix @Leemoonsoo ! Shall this be merged to master or branch-0.6 as well? Asking as JIRA fix version is not set for this one.