Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1330
I'm sorry for no-reply long time. my plate was full.
I will finish other 2 PRs and then If ZEPPELIN-1437 and ZEPPELIN-1438 are
status is unresolved, I will
try to resolve.
If is it
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1330
Thanks, Merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@Leemoonsoo issues are created under
[ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437) and
[ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438)
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@mwkang @khalidhuseynov Could you handle or at least create issues for
expected problems after merge this PR? I can at least think following two
issues,
- Note list broadcasting
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1330
Thank you @mwkang @khalidhuseynov !
Will merge to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1330
I think it doesn't solve all problems, but definitely in the roadmap. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@mwkang could you re-trigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@mwkang thanks for the contribution! actually this is related to multi-user
note management and there's some work going on under #1392 or #1390 .
In your case, i tested it, and
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@mwkang could you please try close and then re-open this PR to trigger the
CI and see if the same issue persists? Thanks!
\cc @khalidhuseynov for review.
---
If your project is set up for
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@bzz https://github.com/apache/zeppelin/pull/1330#issuecomment-239997747 It
did not reproduce in local. Can you check this?
---
If your project is set up for it, you can reply to this email and
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1330
@bzz I will check it. Thanks for review.
When I fix CI, I'll mention you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1330
Thank you for fixing it @mwkang
CI failure looks somehow relevant, you can not reproduce it locally?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1330
CI error
```
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 76.102 sec
- in org.apache.zeppelin.integration.SparkParagraphIT
Results :
Tests in error:
13 matches
Mail list logo