Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
I'm closing this PR since there'll be better solution for this (e.g.
[ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993)) :)
---
If your project is set up for it, you can
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Short summary and small thought about #1399
1. Using symlink like `local-spark/master` would be safe i think. It
enables user replace his local spark without renaming directories.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1339
In case of
1) Don't have plan to use spark interpreter, just want to use other
interpreters like python, big query.
2) Set SPARK_HOME in interpreter property instead of
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@bzz Just updated `upgrade.md` as your feedback.
@1ambda Sure. Thanks! Please do :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Let me also review this great PR and then give some feedbacks ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Thank you @AhyoungRyu for great job and taking care in addressing the [user
experience
concerns](https://github.com/apache/zeppelin/pull/1339#issuecomment-259683752)!
---
If your project is
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
ping ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
CI is green now, so ready for review.
I updated related docs again based on #1615 and @tae-jun 's feedback as
well.
@bzz Could you take a look this again?
As I mentioned in
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@AhyoungRyu Thanks for taking care of my feedback ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
### To whom may concern about the breaking current UX with this change
This change has many benefits comparing to current embedded Spark as I
wrote in the PR description (and @tae-jun
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@tae-jun Appreciate your nice feedback! Will update again `zeppelin-env.sh`
and `install.md` instead of `README.md` as you suggested(since #1615 is trying
to make it simpler to deliver only
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Tested and worked as expected ð
Fantastic work! But, there are other benefits caused by this change.
Before this change, users couldn't use `SPARK_SUBMIT_OPTIONS` env variable
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@bzz Yeah I also wanted to get more and more feedbacks for this change
since it's a huge change as you said. Thanks for asking and i'm willing to
explain again :)
> ** 1.** Is the
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Guys, what great work here, simplifying the build!
A quick question @AhyoungRyu as it's kind of a big change, and I'm sorry if
that was explained before, but could you please recap:
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Updated the related docs pages
([README.md](https://github.com/apache/zeppelin/pull/1339/files#diff-04c6e90faac2675aa89e2176d2eec7d8),
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@astroshim It passed at last!! Thanks again.
Will update the related docs if there are no further discussions about this
changes :)
---
If your project is set up for it, you can
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
All test passes(except for selenium test) in my own travis
[AhyoungRyu/zeppelin/builds](https://travis-ci.org/AhyoungRyu/zeppelin/builds/174094481),
but Zeppelin travis doesn't even started...
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@astroshim Appreciate for your help! I've just pushed it and let's wait
until it finished :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@Leemoonsoo @jongyoul Sorry for my late update.
I've just added new option: `get-spark` to
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@jongyoul Thanks for your feedback! Yeah I didn't try to cover that case.
So you mean we need to support ppl who are using [this upstart
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@AhyoungRyu Thanks for your effort. LGTM. But I think it would be better to
support non-interactive mode for running the server because some of users
launches Zeppelin as a start-up service for
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
ping ð¯
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
I think
[ZEPPELIN-1101](https://issues.apache.org/jira/browse/ZEPPELIN-1101) can also
be resolved by this change.
>It looks related to ZEPPELIN-1099 which is about removing
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
I think this PR is working well as expected(at least to me haha). So ready
for review again.
@moon If you possible, could you please check this one again? :)
---
If your project is set up
24 matches
Mail list logo
