Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@lresende thank you for verification. I am reverting this PR then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
I have verified that with that by reverting my changes
-PScala2.10/Scala2.11 have the proper behavior and my original issue was that
indeed my build alias had -D for the profile activation.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1400
As moon mentioned, if you use build instruction in
https://github.com/apache/zeppelin#example it doesn't bring any issue.
One of the reason I changed activation rule in #1251 was that using
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@lresende In the [issue
description](https://issues.apache.org/jira/browse/ZEPPELIN-1407), your build
command used `-Dscala-2.11` when you get those errors.
I could reproduce the
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
But unfortunately this wasn't what maven was enforcing, and Scala 2.11
build was failing when -PScala2.11 was being used, and when invoking
dependency:tree with -Pscala2.11 there were few
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@lresende You can see followings from
http://maven.apache.org/guides/introduction/introduction-to-profiles.html.
```
All profiles that are active by default are automatically
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
BTW, the properties on the profile activation, only enables the "default"
to be activated by default, so mvn clean install will not have properties
defined, so will start Scala 2.10...
---
If
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@Leemoonsoo The issue wasn't about -P versus -D, but that the Scala 2.10
was with activation true by default, so even when you did only -Pscala2.11 the
Scala 2.10 profile was being activated.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1400
I'm sorry my comment is bit late. code is already been merged.
But let my write it for the records
Because of all our documents and scripts uses `-Pscala-2.xx` instead of
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1400
Done. master and branch-0.6 - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@felixcheung @Leemoonsoo @bzz Any more comments here ? Should we merge this
to 0.6 branch and master, as it's kind blocking to 2.11
---
If your project is set up for it, you can reply to this
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1400
CI green, any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@bzz Sorry, I had put the profiles activation as if scala 2.11 was the
default, have fixed it now.
three builds still failing with timeout, I will try to force new builds
---
If your
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
This should go for both master and 0.6x release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1400
@bzz @Leemoonsoo Please review, this is more like a hotfix for the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
15 matches
Mail list logo