Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1401
Looks good to me, merging if there is no further discussion.
CI fails on single profile with 1 flaky test
```
[INFO] Zeppelin: Server ... FAILURE
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1401
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1401
@lresende My bad, when I first read I understood that RAT would be included
in one profile that would still build everything. (just like we do with the
-DskipTests)
---
If your project is
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1401
@corneadoug This is exactly what is implemented on this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1401
Then how about we use -DskipRat on all building profiles, and have a
profile that run only RAT without building?
Build time is pretty long, so it would be nice to separate some easy
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1401
@bzz this has now been updated to follow the same pattern used for maven
tests, enable RAT to run by default, but support disabling it with -DskipRat.
Travis CI will run RAT once, on the RAT
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1401
I think having a separate profile it is reasonable approach for CI. Though
I also think there is value in keepinv the default behaviour for local Dev
workflow and make RAT check on by default.
