[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-07 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1406 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-07 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1406 As long as it's still shown somewhere during the PR process, I think its fine? Should we merge this then? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1406 right, I'm not sure if that makes a difference to us --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-07 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1406 @felixcheung Right, this message is showing if you have a CONTRIBUTING.md file in the root of the repository. But we are also using the PR_TEMPLATE that github supports, and we have pretty

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-07 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1406 @felixcheung Yeah right. It makes sense. Then how about putting root `CONTRIBUTING.md` back and providing this link

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1406 Not sure if it's important, the thing with having a file called Contributing.md is that github actually automatically notify the person creating a PR:

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-06 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1406 Good! I like it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-06 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1406 @AhyoungRyu Yes, this one could also be replaced. There is actually a few pages of content inside the docs directory that we may want to move to the website later, so maybe we should create

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

2016-09-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1406 @corneadoug There is one more "how to contribute" link - [http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/#100-opensource](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/#100-opensource) :)