Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts Thanks for the explanation. Keeping search with real time job
monitoring make sense.
LGTM and merge to master. if there're no further discussions.
---
If your project
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
change name for item on select box.
Undefined to Interpreter is not set
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@Leemoonsoo
Thank you for your review a lot.
First, the select box's interpreter shows only the first interpreter,
because it is information about the default interpreter's
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts Thanks for addressing my comment in here.
Seems CI is happy now and the feature is working well i think. But since
I'm not a front-end expert, it would be better if other ppl
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@AhyoungRyu
fix done.
Thank you :)
---
If your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts
Tested again and it works well as expected. Seems there are some changes
after I saw this 2 month ago.
- The result is reset after 10 sec
- User should click
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@AhyoungRyu
Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
CI Green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@bzz
Thank you for your feedback.
The problem with CI is irrelevant to my own.
I think this is probably related to this.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts looks like CI is failing. Do you know the reason? If you try
open\close the PR, can it be reproduced?
---
If your project is set up for it, you can reply to this email and have your
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@corneadoug @AhyoungRyu
Hello,
Could you please review this for pr?
I think the merger is ready.
Thank you
hava a nice day :)
---
If your project is set up for it,
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
CI Error
This is irrelevant to my edits.
It is also verified in other PRs.
```
19:24:48,843 INFO org.apache.zeppelin.integration.ZeppelinIT:189 -
testCreateNotebook
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
add Search button.
If you enter the return key or click the
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
rebase done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
todo list
- [x] Create jobmanager.filter.js (divide file for
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@AhyoungRyu @corneadoug
Thank you very much for your feedback.
Filtering system
I think the filter I added here actually will improve filtering performance
since as
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts Just tested and checked the code.
Overall same feedbacks as @AhyoungRyu
Filtering system
The one you used seems a bit too complicated (also the filter should
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1441
Hi @cloverhearts. Thanks for the improvement!
I just tested and got some small feedbacks :)
1. Is there any particular reason to have dropdown menu next to the filter
bar? If so,
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@corneadoug
sorry, could you please review for this pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
code rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@corneadoug Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts Thanks for the contribution, it looks cool.
I will take a look :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
23 matches
Mail list logo
