Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@anthonycorbacho @khalidhuseynov Thanks for the comment! I agree with you
guys.
This is a breaking change, so yeah we must be careful. So, if we proceed
this, new API URL's prefix will
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@tae-jun thanks for summarizing and giving feedback on REST API. Although
we can't address all at once, but I think it deserves an issue with above
content and feedback logged in there
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@tae-jun This is a great sum of the status of the rest api in zeppelin, and
i think we all agree that currently zeppelin doenst follow rest standard (just
by looking at the endpoint +
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@minahlee Oh, in that context, it makes sense. LGTM.
But, after looking all around Notebook REST API, it works well now but it
doesn't seem RESTful. I summarized current list of REST API:
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@tae-jun the reason I use `PUT` is that `clearAllParagraphOutput` method is
not really deleting `result` field from paragraph, but updating `result` field
to empty.
I was considering using
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@minahlee I have a question about REST API style. Is there any purpose that
you used `PUT` method?
In my opinion, `DELETE` method is more proper since it does not `PUT`
`clear` under a
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@khalidhuseynov Thank you for quick response!
Merging if there is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@minahlee looks much better now! thanks for addressing the issue and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@khalidhuseynov I updated rest api to do privilege check. Could you help
review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@minahlee Awesome! I just changed status to `IN PROGRESS` now. Thanks ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@tae-jun I just added your name to contributor list so you will be able to
set yourself as assignee from now.
---
If your project is set up for it, you can reply to this email and have your
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1565
Thanks @minahlee! I appreciate your kind comment ð
I created a ticket on JIRA:
[ZEPPELIN-1598](https://issues.apache.org/jira/browse/ZEPPELIN-1598)
But, I don't know how to
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1565
Hi @tae-jun, thank you for your interest. I had to rebase this branch to
resolve conflict so you will need too since it is based on mine.
I am planning to finish this PR once #1567
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1565
Hi @minahlee :) This is a cool feature! I have an experience that deleted
output through editing note.json because of huge output stopping Zeppelin web.
By the way, I've wanted a renaming
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@khalidhuseynov Thank you for review. I made "clear paragraph output" in
main page for the case that note's output data is too big so it causes Zeppelin
fail to load note and hang.
Here are
15 matches
Mail list logo
