[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

2016-11-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1679 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

2016-11-29 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1679 @zjffdu It's my misunderstanding. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

2016-11-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1679 @astroshim `InterpreterContext` is only available when interpreting paragraph (after Interpreter is opened). What I need here is to get username when opening interpreter. --- If your project

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

2016-11-29 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1679 Sorry for late review. User name is already passed to interpreter. We can get the user id on interpreterContext.getAuthenticationInfo().getUser() I think passing password

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

2016-11-28 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1679 Looks good to me. CI is green now, so will merge it to master if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

2016-11-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1679 @Leemoonsoo @prabhjyotsingh Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this