Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
Thank you very much @cuspymd for fix and @zjffdu for double-checking!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@bzz I've assigned
[ZEPPELIN-1239](https://issues.apache.org/jira/browse/ZEPPELIN-1239) to me.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@cuspymd please let me know you ASF JIRA user or email and I'll be happy to
assign [ZEPPELIN-1239](https://issues.apache.org/jira/browse/ZEPPELIN-1239) so
attribution is keept for release notes
---
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
Looks great to me. Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@felizbear I've reverted dangle-commas deletion and moved 'google-fonts'
task into 'postinstall'.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@felizbear Thanks for your review.
I think it makes sense. I'll test it after the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
\cc @corneadoug @felizbear for reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@bzz I have checked it works in dev mode after grunt build.
And I decided not to add the task 'googlefonts' to grunt serve.
It's not need to download google fonts every server start in dev m
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@bzz Thanks for your comment. The file 'google-fonts.css' is created during
zeppelin-web build.
You need to run `npm run build`.
---
If your project is set up for it, you can reply to this e
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
ð Idea sounds great to me. It looks like
https://github.com/optimalisatie/grunt-goog-webfont-dl is not maintained but
https://github.com/Mika-/grunt-google-fonts had changes this year.
I
10 matches
Mail list logo
