[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 Will merge into master if there are no more comments then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 @felixcheung Yeah that's my plan :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1750 LGTM! Maybe we can leverage this for more copy to clipboard features? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 CI has passed now. Ready to review again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 For the consistency with other menus in the dropdown menu, I removed the clippy icon and make paragraph id text itself as a button. ![screen shot 2016-12-15 at 2 56 43

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1750 Great but the concerns are with dependencies on Flash with this approach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 @felixcheung I just tested this patch only in dev mode(`npm run start`). But after I checked at `localhost:8080` and found ``` 404