[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

2017-01-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1824 Since this PR merge, [first CI test profile fails](https://travis-ci.org/apache/zeppelin/jobs/188757727) with ``` [ERROR] Failed to execute goal

[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

2017-01-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1824 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

2017-01-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1824 @Leemoonsoo Thanks for review! Now `mvn clean` will execute `npm run clean` (8baaea2) ``` $ zeppelin-web git:(ZEPPELIN-1850/remove-grunt-clean) mvn clean Java HotSpot(TM)

[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

2016-12-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1824 `mvn clean` in `zeppelin-web` module now removes [`bower_components`](https://github.com/apache/zeppelin/blob/master/zeppelin-web/pom.xml#L180). what do you think about making `mvn clean`